Péter Szilágyi
acc622e5fb
Invalidate context.setFlags cache on modification.
2017-01-11 14:38:54 +02:00
Jesse Szwedko
8ef3805c9d
Merge pull request #575 from MaximilianMeister/command-ordering
...
command: enable ordering commands by name
2017-01-09 20:57:14 -08:00
Maximilian Meister
ac772237b9
command: enable ordering commands by name
2017-01-09 16:40:32 +01:00
Jesse Szwedko
8f6a3675e1
Merge pull request #581 from appleboy/patch-2
...
[ci skip] fix template syntax error
2017-01-08 17:29:12 -05:00
Bo-Yi Wu
4267cd827c
[ci skip] Fix template syntax error
2017-01-04 10:28:58 +08:00
Jesse Szwedko
0bdeddeeb0
Merge pull request #569 from urfave/prepare-1-19-1
...
Prep 1.19.1
2016-11-21 20:36:10 -08:00
Jesse Szwedko
0ef6582154
Prep 1.19.1
2016-11-21 20:26:35 -08:00
Jesse Szwedko
3ba36a3127
Merge pull request #568 from kklipsch/master
...
Fix for #556 broke the api for users who were using the ActionFunc
2016-11-21 20:21:12 -08:00
Kasey Klipsch
8fa549846e
#556 broke the api for users who were using the ActionFunc
2016-11-21 09:47:23 -06:00
Jesse Szwedko
b6061c464d
Merge pull request #559 from joshuarubin/completion_fix
...
make shell autocomplete more robust
2016-11-19 11:05:28 -08:00
Jesse Szwedko
7fbcf2396a
Update date of 1.19.0 release in CHANGELOG
...
[ci skip]
2016-11-19 11:04:57 -08:00
Jesse Szwedko
a8fc36b690
Update CHANGELOG
2016-11-19 10:55:36 -08:00
Jesse Szwedko
6a87e37dff
Merge pull request #564 from urfave/altsrc-errorable-flag
...
Make ApplyWithError a public method on errorableFlag
2016-11-19 10:51:37 -08:00
Jesse Szwedko
d71794de19
Make ApplyWithError a public method on errorableFlag
...
Add to altsrc flags. Otherwise, flagSet() was bypassing altsrc's attempt
at shadowing.
2016-11-19 10:51:20 -08:00
Jesse Szwedko
8500a4cefd
Merge pull request #567 from drekar/errorable-flag-panic-fix
...
errorableFlag: scope result of type assertion.
2016-11-19 10:11:24 -08:00
Joshua Rubin
2da42640ad
Merge remote-tracking branch 'origin/master' into completion_fix
2016-11-18 09:28:39 -07:00
drekar
4661a59b20
errorableFlag: scope result of type assertion.
2016-11-17 09:48:03 -10:00
Joshua Rubin
3272baf434
add a test for shell completion using incomplete flags
2016-11-14 10:10:51 -07:00
Joshua Rubin
8dd1962f7b
change "complete" to "shellComplete"
2016-11-14 09:35:22 -07:00
Jesse Szwedko
b4f4786f37
Merge pull request #529 from urfave/prepare-v1.19.0
...
Prepare v1.19.0 release
2016-11-13 15:35:18 -08:00
Jesse Szwedko
dcdea39be2
Add additional entries to changelog for v.19.0 release
2016-11-13 15:04:31 -08:00
Jesse Szwedko
fa7ccb1447
Update changelog
2016-11-13 15:01:04 -08:00
Jesse Szwedko
4c2360f975
Prepare CHANGELOG for v1.19.0
2016-11-13 15:01:04 -08:00
Jesse Szwedko
de551c4450
Backport removal of deprecation warnings
...
#508
2016-11-13 15:01:04 -08:00
Jesse Szwedko
31b79c9a33
Merge pull request #530 from urfave/consider-empty-env-vars
...
Consider empty environment variables as set
2016-11-13 15:00:04 -08:00
Jesse Szwedko
b4a64dc08d
Add windows implementation of Clearenv for tests
...
Apparently `Clearenv` in Windows just sets the variables to ""
2016-11-13 14:59:35 -08:00
Jesse Szwedko
e367fafa3d
Return an error when parsing environment variables for values fails
...
Currently cli silently (aside from IntSlice and Int64Slice which oddly
printed directly to the error stream) ignores failures that occur when
parsing environment variables for their value for flags that define
environment variables. Instead, we should propogate up the error to the
user.
This is accomplished in a backwards compatible manner by adding a new,
internal, interface which defines an applyWithError function that all
flags here define. In v2, when we can modify the interface, we can drop
this secondary interface and modify `Apply` to return an error.
2016-11-13 14:59:35 -08:00
Jesse Szwedko
a00c3f5872
Consider empty environment variables as set
...
When assigning values to flags (also when interogatting via
`context.(Global)IsSet`.
For boolean flags, consider empty as `false`.
Using `syscall.Getenv` rather than `os.LookupEnv` in order to support
older Golang versions.
2016-11-13 14:59:27 -08:00
Jesse Szwedko
7a5dacbc41
Merge pull request #560 from mh-cbon/master
...
Close #558 : detect FormattedError and print their stack trace
2016-11-13 13:44:15 -08:00
mh-cbon
b0a8f25773
558: handle multi formatter errors
2016-11-13 22:34:31 +01:00
Jesse Szwedko
af372e8e2a
Merge branch 'master' into master
2016-11-12 14:32:21 -08:00
Jesse Szwedko
88ae7af8d4
Merge pull request #563 from urfave/print-help-if-no-action
...
If no action is specified on the command or app, print the help documentation
2016-11-12 13:49:46 -08:00
Jesse Szwedko
0113f56d10
If no action is specified on the command or app, print the help documentation
...
Rather than panic'ing or displaying an opaque error message about the
signature which is more confusing to the end user.
Fixes #562
2016-11-12 13:37:07 -08:00
mh-cbon
79591889a9
Close #558 : detect FormattedError and print their stack trace
2016-11-05 10:36:23 +01:00
Joshua Rubin
ea3df26e64
make shell autocomplete more robust
2016-11-04 14:56:28 -06:00
d86a009f5e
Merge pull request #556 from urfave/use-assertions-over-reflection
...
Use type assertions rather than reflection to determine how to call the `Action`
2016-11-02 09:18:01 -04:00
Jesse Szwedko
b377b5d9e9
Use type assertions rather than reflection to determine how to call the Action
...
This has some benefits, but results in possibly less informative error
messaging; however, given that there are only two accepted types,
I think the error messaging is sufficient.
2016-11-01 20:33:12 -07:00
Jesse Szwedko
3eb41f1bb1
Merge pull request #547 from urfave/default-writer
...
Default app.Writer to os.Stdout
2016-10-29 18:45:05 -07:00
Jesse Szwedko
61db37e7ae
Merge branch 'master' into default-writer
2016-10-29 18:36:19 -07:00
Jesse Szwedko
f614c177b7
Merge pull request #543 from wking/app-description
...
app: Add App.Description
2016-10-25 21:54:02 -07:00
Jesse Szwedko
b803494208
Merge pull request #542 from mhmxs/patch-1
...
Display error instead of just say command is incorrect
2016-10-25 21:52:14 -07:00
Richard Kovacs
668cf38bbe
Merge branch 'master' into patch-1
2016-10-24 09:45:24 +02:00
W. Trevor King
3c2bce5807
help: Cleanup AppHelpTemplate trailing whitespace
...
Most of the changes here remove trailing whitespace, but I also add
code to select "AUTHOR" or "AUTHORS" as appropriate instead of the
previous "AUTHOR(S)". The template for listing with an entry per line
is:
{{range $index, $entry := pipeline}}{{if $index}}
{{end}}{{$entry}}{{end}}
That range syntax is discussed in [1].
Also add a unit test, which tests both these whitespace changes and
also the earlier App.Description addition.
[1]: https://golang.org/pkg/text/template/#hdr-Variables
2016-10-22 16:02:21 -07:00
W. Trevor King
0c143a2a26
app: Fix trailing space for Author.String()
...
This code initially landed with lots of space:
'{name} <{email}> '
or:
'{name} '
in 3d718330c6592bb4
2016-10-22 15:58:07 -07:00
Jesse Szwedko
6f2647a880
Merge pull request #544 from runcom/sort-flags
...
flags: sort flags
2016-10-22 10:29:59 -07:00
Jesse Szwedko
64fcd51526
Merge branch 'master' into sort-flags
2016-10-22 10:22:16 -07:00
Jesse Szwedko
3f4989051e
Merge pull request #550 from runcom/test-go-1-7
...
.travis.yml: add go 1.7.x
2016-10-22 09:40:07 -07:00
Antonio Murdaca
d913b71c72
.travis.yml: add go 1.7.x
...
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2016-10-21 10:46:51 +02:00
Antonio Murdaca
c516bce8f1
flags: provide a type to sort flags
...
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2016-10-21 10:37:18 +02:00
Richard Kovacs
4cc2bad36e
Display error instead of just say command is incorrect
2016-10-19 13:31:05 +02:00
