Commit Graph

2429 Commits

Author SHA1 Message Date
meatballhat a210601c03 Merge commit 'ca9df40' into v3-porting 2022-11-07 08:17:12 -05:00
meatballhat 037f2e0b8f Merge commit '254c38e' into v3-porting 2022-11-07 08:16:25 -05:00
meatballhat dc0ad27f40 Merge commit '514a114' into v3-porting 2022-11-07 08:16:02 -05:00
meatballhat 5dcfcce49f Merge commit 'f664246' into v3-porting 2022-11-07 08:15:52 -05:00
meatballhat c19cd3811d Merge commit 'b98c059' into v3-porting 2022-11-07 08:15:18 -05:00
meatballhat a9bf2e7aa5 Merge commit '8b23e7b' into v3-porting 2022-11-07 08:15:11 -05:00
meatballhat ade08d5931 Merge commit '77a5fef' into v3-porting 2022-11-07 08:14:49 -05:00
meatballhat 38546ca7b5 Merge commit 'f394c37' into v3-porting 2022-11-07 08:14:42 -05:00
meatballhat ff6f4b443e Merge commit 'b4df361' into v3-porting 2022-11-07 08:12:31 -05:00
meatballhat 4e3a32787a Merge commit '7b28ca5' into v3-porting 2022-11-07 08:12:19 -05:00
meatballhat 504ec56a3b Merge commit '7357e10' into v3-porting 2022-11-07 08:12:07 -05:00
meatballhat 8c34fbca99 Merge commit 'c6616c3' into v3-porting 2022-11-07 08:11:54 -05:00
meatballhat 140c96c75c Merge commit 'dac1c40' into v3-porting 2022-11-07 08:11:12 -05:00
meatballhat f68da12273 Merge commit '87dedb6' into v3-porting 2022-11-07 08:10:52 -05:00
meatballhat ba1c00ef2c Merge commit '3a1b6de' into v3-porting 2022-11-07 08:10:20 -05:00
meatballhat 63b730ef0a Merge commit '234972e' into v3-porting 2022-11-07 08:10:13 -05:00
meatballhat 3c66d6d757 Merge commit '6ff3e8e' into v3-porting 2022-11-07 08:09:48 -05:00
meatballhat fd3354f651 Merge commit 'af3b50c' into v3-porting 2022-11-07 08:09:29 -05:00
meatballhat 16c0635dd4 Merge commit 'ade5edb' into v3-porting 2022-11-07 08:09:09 -05:00
meatballhat 874d06d6a7 Merge commit 'e3ee4fb' into v3-porting 2022-11-07 08:08:31 -05:00
meatballhat 9aa0dd753f Merge commit 'c8147a4' into v3-porting 2022-11-07 08:05:28 -05:00
meatballhat 25897ce4dd Merge pull request #1525 from urfave/v3-porting
Porting changes from `main` to `v3-dev-main` (circa 2022-10-09)
2022-10-16 14:08:16 -04:00
meatballhat 85ff0c550a Un-regress from v3 porting losses 2022-10-13 08:15:14 -04:00
meatballhat 75aabac594 Use existing goimports installation if available 2022-10-13 07:47:17 -04:00
meatballhat b45820714d Build and run urfave-cli-genflags via its Makefile
so that `go.mod` files don't get all confused
2022-10-13 07:47:17 -04:00
meatballhat 6404f1d1b4 Backfill drop of generated GetDefaultText method 2022-10-10 10:57:06 -04:00
meatballhat 96216756c2 Remove duplicate DocGenerationFlag interface
introduced via merge
2022-10-09 12:41:30 -04:00
meatballhat 64facdbe2f Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting 2022-10-09 12:40:44 -04:00
dearchap 83ea416eb3 Merge pull request #1517 from dearchap/revert_remove_all_flag_interfaces 2022-10-09 11:37:29 -05:00
Naveen Gogineni fcb0bce797 Fix failed test 2022-10-09 10:09:36 -04:00
Naveen Gogineni 924ebdaab2 Fix:(issue_1500). Fix slice flag value duplication issue 2022-10-09 10:09:36 -04:00
Naveen Gogineni ea2893084b Remove extra 3 spaces in last line 2022-10-09 09:59:46 -04:00
Naveen Gogineni 9a9461928a Add test coverage for Command.VisibleCommands() 2022-10-09 09:59:46 -04:00
dearchap a4b7759ad1 Update template.go
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
2022-10-09 09:59:35 -04:00
Naveen Gogineni dccd762cbb Componentize template 2022-10-09 09:59:35 -04:00
Naveen Gogineni c86805de7c Add test case 2022-10-09 09:59:35 -04:00
Naveen Gogineni ae8c5118f2 Fix command help subcommand 2022-10-09 09:59:35 -04:00
Naveen Gogineni 13860a7c4d Fix:(issue_1505) Fix flag alignment in help 2022-10-09 09:59:35 -04:00
Jakub Nowakowski b82e628617 Add unit test for GenericFlag Destination parsing
The test checks if Destination provided in GenericFlag is being set as
expected.
2022-10-09 09:57:25 -04:00
Jakub Nowakowski 01bdec784f Set destination in GenericFlag apply function
The function was missing destination configuration.
2022-10-09 09:57:25 -04:00
meatballhat c5057d195e Only run generate on go 1.19 2022-10-09 09:51:19 -04:00
meatballhat 65c98c86ad Ensure "generate" step runs in CI prior to diff check 2022-10-09 09:51:19 -04:00
Felix Lange 82ea9f70c0 Call FlagStringer in String() method of slice flags
The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.

FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.

To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.

Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
2022-10-09 09:50:12 -04:00
Anatoli Babenia 4959a9fa9b Refactor wrap() and add test for empty line 2022-10-09 09:33:19 -04:00
Anatoli Babenia e14dca7a18 Run go fmt 2022-10-09 09:33:19 -04:00
Anatoli Babenia 05fb755b6a wrap: Simplify loop logic
Suggested by @julian7
2022-10-09 09:33:19 -04:00
Anatoli Babenia d3bb381a0b Fix test for removed trailing whitespace 2022-10-09 09:33:19 -04:00
Anatoli Babenia a6f5ca69f4 wrap: Avoid trailing whitespace for empty lines 2022-10-09 09:33:19 -04:00
Naveen Gogineni 662deaa57b Run v2approve 2022-10-08 10:09:54 -05:00
Naveen Gogineni cf41aab451 Revert changes 2022-10-08 09:57:52 -05:00