Commit Graph

783 Commits

Author SHA1 Message Date
Jesse Szwedko
924042785a Merge pull request #624 from urfave/fetch-needed-commands
Explicitly fetch `goimports`
2017-04-24 11:43:35 -07:00
Jesse Szwedko
1bf0bb96b7 Only support supported Go versions
As described on https://github.com/golang/go/wiki/Go-Release-Cycle

The maintainers do not test compatibility for libraries (e.g. in
golang.org/x/tools) on older versions.
2017-04-24 11:02:41 -07:00
Jesse Szwedko
572dc46db5 Explicitly fetch goimports
Fetching the whole tree was failing on some Go versions and we really
only need goimports.
2017-04-24 10:40:54 -07:00
Jesse Szwedko
8ba6f23b6e Merge pull request #582 from urfave/fix-altsrc-slice-inputs
Fix altsrc slice inputs so that they correctly parse
2017-03-28 18:35:17 -07:00
Jesse Szwedko
beddedeabd Merge branch 'master' into fix-altsrc-slice-inputs 2017-03-27 20:46:54 -07:00
Jesse Szwedko
9e5b04886c Remove logic that exited even if the error was not an OsExiter
This was introduced in #496, but was discovered to be a regression in
the behavior of the library.
2017-03-04 14:33:36 -08:00
Jesse Szwedko
8d8f927bcb Change flag test error checking to use regexp rather than strings
As the error messages changed in 1.8
2017-03-04 14:28:24 -08:00
Jesse Szwedko
2526b57c56 Allow slightly longer lines in Python scripts 2017-02-14 21:17:05 -08:00
Jesse Szwedko
347a9884a8 Merge pull request #589 from josephlr/subcommand-structure
Subcommand structure should be correctly passed to application
2017-01-28 13:39:59 -08:00
Jesse Szwedko
9913f0cef2 Merge branch 'master' into subcommand-structure 2017-01-28 13:35:02 -08:00
Jesse Szwedko
1d38670e45 Merge pull request #587 from guywithnose/master
Pass the ErrWriter on the root app to subcommands
2017-01-28 13:29:39 -08:00
Joe Richey
e109e81e6a Subcommand structure should be correctly copied to main structure 2017-01-23 10:36:28 -08:00
Robert Bittle
4ed366e201
Pass the ErrWriter on the root app to subcommands 2017-01-18 23:29:26 -05:00
Jesse Szwedko
e87dfbb6bb altsrc: Support slices for TOML 2017-01-16 17:34:12 -08:00
Jesse Szwedko
f8347a97c6 Fix altsrc slice inputs so that they correctly parse
Was previously attempting to cast directly from []interface{} to
[]string or []int which Go doesn't support. Instead, we iterate over and
cast each value (error'ing if the value is not the correct format).

Fixes #580
2017-01-16 17:22:11 -08:00
Antonio Fdez
f1be59ff3d added comment to windows filePath check 2017-01-16 17:19:38 -08:00
Antonio Fdez
341ca93b01 fix imports
Sorry, forgot to add imports correctly, needed to edit the file and make the commit using the github online editor, since I can't access from my current location from git.
2017-01-16 17:19:33 -08:00
Antonio Fdez
7b912d9f8f allow to load YAML configuration files on Windows
The funtion `loadDataFrom` does not take care of Windows users since any of the conditions met and it returns an error.

The change looks for the runtime where it's running and then if the filePath contains a `\`
2017-01-16 17:19:29 -08:00
Jesse Szwedko
56a7254df4 Merge pull request #540 from hirose31/fix/handle-multierror
Call HandleExitCoder for all members of MultiError.Errors
2017-01-16 14:20:16 -08:00
HIROSE Masaaki
adec15acf5 Add another ExitCoder to assert that it uses last one 2017-01-13 15:37:09 +09:00
HIROSE Masaaki
286b4b56d9 Document on exit code in case of MultiError is given 2017-01-12 19:12:17 +09:00
HIROSE Masaaki
71ced406af Treat rc first called as exit code
Because default OsExiter is os.Exit.
2017-01-12 18:59:38 +09:00
hirose31
70a2c94089 Merge branch 'master' into fix/handle-multierror 2017-01-12 18:16:34 +09:00
Jesse Szwedko
8ef3805c9d Merge pull request #575 from MaximilianMeister/command-ordering
command: enable ordering commands by name
2017-01-09 20:57:14 -08:00
Joe Richey
0083ae8732 Usage/Description/ArgsUsage correctly copied when using subcommand 2017-01-09 15:57:49 -08:00
Maximilian Meister
ac772237b9
command: enable ordering commands by name 2017-01-09 16:40:32 +01:00
Jesse Szwedko
8f6a3675e1 Merge pull request #581 from appleboy/patch-2
[ci skip] fix template syntax error
2017-01-08 17:29:12 -05:00
Bo-Yi Wu
4267cd827c [ci skip] Fix template syntax error 2017-01-04 10:28:58 +08:00
Jesse Szwedko
0bdeddeeb0 Merge pull request #569 from urfave/prepare-1-19-1
Prep 1.19.1
2016-11-21 20:36:10 -08:00
Jesse Szwedko
0ef6582154 Prep 1.19.1 2016-11-21 20:26:35 -08:00
Jesse Szwedko
3ba36a3127 Merge pull request #568 from kklipsch/master
Fix for #556 broke the api for users who were using the ActionFunc
2016-11-21 20:21:12 -08:00
Kasey Klipsch
8fa549846e #556 broke the api for users who were using the ActionFunc 2016-11-21 09:47:23 -06:00
Jesse Szwedko
b6061c464d Merge pull request #559 from joshuarubin/completion_fix
make shell autocomplete more robust
2016-11-19 11:05:28 -08:00
Jesse Szwedko
7fbcf2396a Update date of 1.19.0 release in CHANGELOG
[ci skip]
2016-11-19 11:04:57 -08:00
Jesse Szwedko
a8fc36b690 Update CHANGELOG 2016-11-19 10:55:36 -08:00
Jesse Szwedko
6a87e37dff Merge pull request #564 from urfave/altsrc-errorable-flag
Make ApplyWithError a public method on errorableFlag
2016-11-19 10:51:37 -08:00
Jesse Szwedko
d71794de19 Make ApplyWithError a public method on errorableFlag
Add to altsrc flags. Otherwise, flagSet() was bypassing altsrc's attempt
at shadowing.
2016-11-19 10:51:20 -08:00
Jesse Szwedko
8500a4cefd Merge pull request #567 from drekar/errorable-flag-panic-fix
errorableFlag: scope result of type assertion.
2016-11-19 10:11:24 -08:00
Joshua Rubin
2da42640ad
Merge remote-tracking branch 'origin/master' into completion_fix 2016-11-18 09:28:39 -07:00
drekar
4661a59b20 errorableFlag: scope result of type assertion. 2016-11-17 09:48:03 -10:00
Joshua Rubin
3272baf434
add a test for shell completion using incomplete flags 2016-11-14 10:10:51 -07:00
Joshua Rubin
8dd1962f7b
change "complete" to "shellComplete" 2016-11-14 09:35:22 -07:00
Jesse Szwedko
b4f4786f37 Merge pull request #529 from urfave/prepare-v1.19.0
Prepare v1.19.0 release
2016-11-13 15:35:18 -08:00
Jesse Szwedko
dcdea39be2 Add additional entries to changelog for v.19.0 release 2016-11-13 15:04:31 -08:00
Jesse Szwedko
fa7ccb1447 Update changelog 2016-11-13 15:01:04 -08:00
Jesse Szwedko
4c2360f975 Prepare CHANGELOG for v1.19.0 2016-11-13 15:01:04 -08:00
Jesse Szwedko
de551c4450 Backport removal of deprecation warnings
#508
2016-11-13 15:01:04 -08:00
Jesse Szwedko
31b79c9a33 Merge pull request #530 from urfave/consider-empty-env-vars
Consider empty environment variables as set
2016-11-13 15:00:04 -08:00
Jesse Szwedko
b4a64dc08d Add windows implementation of Clearenv for tests
Apparently `Clearenv` in Windows just sets the variables to ""
2016-11-13 14:59:35 -08:00
Jesse Szwedko
e367fafa3d Return an error when parsing environment variables for values fails
Currently cli silently (aside from IntSlice and Int64Slice which oddly
printed directly to the error stream) ignores failures that occur when
parsing environment variables for their value for flags that define
environment variables. Instead, we should propogate up the error to the
user.

This is accomplished in a backwards compatible manner by adding a new,
internal, interface which defines an applyWithError function that all
flags here define. In v2, when we can modify the interface, we can drop
this secondary interface and modify `Apply` to return an error.
2016-11-13 14:59:35 -08:00