Commit Graph
8 Commits
Author SHA1 Message Date
Dmitry Kutakov 5998e27dd7 remove unused code 2019-12-31 16:36:01 +01:00
Dmitry Kutakov e17c93181f fix ineffectual assignments
Warnings are produced by "ineffassign" linter
2019-12-30 20:34:27 +01:00
Dmitry Kutakov d7e6dde41e goimports - fix code format 2019-12-30 10:41:15 +01:00
Dmitry Kutakov 0c181376a6 goimports - fix import order
https://github.com/golang/go/wiki/CodeReviewComments#imports
2019-12-30 10:26:21 +01:00
Dmitry Kutakov ef89298b56 refactor tests - drop mock writer
Use bytes.Buffer instead.
2019-12-29 17:18:04 +01:00
Dmitry Kutakov 94a1912e25 reduce stdout logs in tests
Keep the stdout clean if all tests are passed. It helps to debug a broken test, because only a failed test prints to output.
2019-12-29 17:00:19 +01:00
Dmitry Kutakov 8c28ae347a refactor flag names - make it more explicitly
avoid the using 'reflect' package while getting flag names
2019-12-29 08:58:12 +01:00
Dmitry Kutakov 62597fe929 simplify code - eliminate type assertions
"gosimple" linter says:
S1034: assigning the result of this type assertion to a variable (switch f := f.(type)) could eliminate the following type assertions:
	flag.go:267:26
	flag.go:270:28
	flag.go:273:30
	flag.go:276:29
2019-12-26 14:05:50 +01:00