Commit Graph

2405 Commits

Author SHA1 Message Date
Naveen Gogineni
e302525d58 Fix:(issue_1263) FlagNames should return names set via env as well 2022-10-16 19:02:49 -04:00
dearchap
5ac0710c11
Merge pull request #1528 from dearchap/issue_1206
Fix:(issue_1206) Default value shouldnt depend on env variable or val…
2022-10-15 17:58:48 -04:00
Naveen Gogineni
e8b5e4a1d0 Fix windows compile 2022-10-14 17:46:03 -04:00
Naveen Gogineni
6b738dc4e5 Use withEnvHint instead of custom func 2022-10-14 17:46:03 -04:00
Naveen Gogineni
e320fd80a2 Fix windows env error 2022-10-14 17:46:03 -04:00
Naveen Gogineni
729a7c41ce Fix:(issue_1206) Default value shouldnt depend on env variable or value set from cmdline 2022-10-14 17:46:03 -04:00
dearchap
39b1245772
Merge pull request #1533 from dearchap/fix_docs
Cleanup: Fix app.go formatting
2022-10-14 17:43:57 -04:00
Naveen Gogineni
bb8ddda480 Cleanup: Fix app.go formatting 2022-10-14 17:26:56 -04:00
dearchap
adcd0c970a
Merge pull request #1532 from dearchap/fix_docs
Docs: Fix docs from merged PR1498
2022-10-14 17:20:26 -04:00
Naveen Gogineni
7a5db9223d Docs: Fix docs from merged PR1498 2022-10-14 17:13:13 -04:00
dearchap
0d0d329866
Merge pull request #1498 from dearchap/optimize_command_run 2022-10-14 02:46:25 -04:00
dearchap
33d08c39be
Update app.go
Co-authored-by: Dan Buch <dan@meatballhat.com>
2022-10-14 02:46:00 -04:00
89e331ff27
Merge pull request #1526 from urfave/genflags-mod
Build and run `urfave-cli-genflags` via its `Makefile`
2022-10-13 07:44:55 -04:00
Naveen Gogineni
5100c9d4e9 Update docs 2022-10-11 19:40:59 -04:00
Naveen Gogineni
00afca42c8 Add RunAsSubcommand to keep API unchanged 2022-10-11 16:35:54 -04:00
Naveen Gogineni
4a109bc0ce Fix tests 2022-10-11 16:28:12 -04:00
Naveen Gogineni
a9d6b0d821 Changes from code review 2022-10-11 09:18:57 -04:00
Naveen Gogineni
59095aa762 make cmd.Run use varargs 2022-10-10 18:32:56 -04:00
e9f2ca42db
Use existing goimports installation if available 2022-10-10 08:48:50 -04:00
6ec1f4bb44
Merge branch 'main' into genflags-mod 2022-10-09 19:23:54 -04:00
Naveen Gogineni
adcce134f3 Rebase origin 2022-10-09 16:51:42 -05:00
Naveen Gogineni
2047c6630c Cleanup 2022-10-09 16:49:30 -05:00
Naveen Gogineni
00ef229486 Fix docs 2022-10-09 16:49:30 -05:00
Naveen Gogineni
2576c0ce4e Fix docs 2022-10-09 16:49:30 -05:00
Naveen Gogineni
fa21c74096 Fix altsrc tests 2022-10-09 16:49:30 -05:00
Naveen Gogineni
bc9ae33465 Merge latest and fix tests 2022-10-09 16:49:30 -05:00
Naveen Gogineni
d5947d7814 Initial cut 2022-10-09 16:49:30 -05:00
dearchap
f37b9d9b60
Merge pull request #1430 from FGYFFFF/fix/stop_auto_sort_for_help
fix: stop automatic sorting for --help
2022-10-09 16:39:58 -05:00
Naveen Gogineni
bffaf3b78c Update flags.md for docs change 2022-10-09 16:07:55 -05:00
11915a875d
Build and run urfave-cli-genflags via its Makefile
so that `go.mod` files don't get all confused
2022-10-09 11:25:02 -04:00
Naveen Gogineni
81f9145708 Refactor code 2022-10-07 11:17:09 -05:00
Naveen Gogineni
8227be1fe9 Add tests for command.VisibleFlagCategory 2022-10-07 11:06:34 -05:00
Naveen Gogineni
e62a087117 Run make v2approve 2022-10-06 20:55:28 -05:00
Naveen Gogineni
02613e50be Fix tests 2022-10-06 20:53:05 -05:00
范广宇
1ada1a1c06 fix: stop automatic sorting for --help 2022-10-06 17:21:46 -05:00
dearchap
f64acc4404
Merge pull request #1502 from dearchap/issue_1500
Fix:(issue_1500). Fix slice flag value duplication issue
2022-10-06 11:20:29 -04:00
dearchap
fb23ff4aa2
Merge branch 'main' into issue_1500 2022-10-06 11:07:28 -04:00
dearchap
2a4809f3af
Merge pull request #1506 from dearchap/issue_1505
Fix:(issue_1505) Fix flag alignment in help
2022-10-06 11:06:25 -04:00
dearchap
86809cef4b
Merge branch 'main' into issue_1505 2022-10-06 11:06:10 -04:00
dearchap
8f469abc00
Merge pull request #1442 from nkuba/generit-flag-destination-pointer
Configure GenericFlag's Destination type as struct not pointer
2022-10-05 22:21:27 -04:00
Naveen Gogineni
67f293a1e5 Revert main_test 2022-10-05 22:18:45 -04:00
Naveen Gogineni
a9c758e55f Fix compile 2022-10-05 22:15:43 -04:00
Naveen Gogineni
d724a63144 After rebase 2022-10-05 22:10:22 -04:00
Jakub Nowakowski
c472192257 Add unit test for GenericFlag Destination parsing
The test checks if Destination provided in GenericFlag is being set as
expected.
2022-10-05 22:04:46 -04:00
Jakub Nowakowski
a2541e0fe4 Set destination in GenericFlag apply function
The function was missing destination configuration.
2022-10-05 22:04:46 -04:00
Jakub Nowakowski
891ffb017b Add DestinationPointer for flags generator
In this commit I added a DestinationPointer variable that should be set
if the `Destination` should be configured as a pointer for a specific
flag type. It is expected that Generic type which is an interface will
not be a pointer but a struct. Before this change the code compilation
was failing with `type *Generic is pointer to interface, not interface`.

See https://github.com/urfave/cli/issues/1441
2022-10-05 22:04:46 -04:00
dearchap
b68db8d010
Merge pull request #1504 from urfave/generate-in-ci
Ensure "generate" step runs in CI prior to diff check
2022-10-05 20:33:29 -04:00
Naveen Gogineni
194ed2bb9b Remove extra 3 spaces in last line 2022-10-05 20:26:45 -04:00
Naveen Gogineni
d5a1252ef3 Add test coverage for Command.VisibleCommands() 2022-10-05 20:26:45 -04:00
Naveen Gogineni
05db729d66 Do make v2approve 2022-10-05 20:26:45 -04:00