x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
722 Commits 2 Branches 0 Tags 7 MiB
d86a009f5e
Commit Graph

91 Commits

Author SHA1 Message Date
Jesse Szwedko
b377b5d9e9 Use type assertions rather than reflection to determine how to call the Action 
This has some benefits, but results in possibly less informative error
messaging; however, given that there are only two accepted types,
I think the error messaging is sufficient.
 2016-11-01 20:33:12 -07:00
Jesse Szwedko
61db37e7ae Merge branch 'master' into default-writer 2016-10-29 18:36:19 -07:00
Jesse Szwedko
f614c177b7 Merge pull request #543 from wking/app-description 
app: Add App.Description
 2016-10-25 21:54:02 -07:00
W. Trevor King
3c2bce5807 help: Cleanup AppHelpTemplate trailing whitespace 
Most of the changes here remove trailing whitespace, but I also add
code to select "AUTHOR" or "AUTHORS" as appropriate instead of the
previous "AUTHOR(S)".  The template for listing with an entry per line
is:

   {{range $index, $entry := pipeline}}{{if $index}}
   {{end}}{{$entry}}{{end}}

That range syntax is discussed in [1].

Also add a unit test, which tests both these whitespace changes and
also the earlier App.Description addition.

[1]: https://golang.org/pkg/text/template/#hdr-Variables
 2016-10-22 16:02:21 -07:00
Richard Kovacs
4cc2bad36e Display error instead of just say command is incorrect 2016-10-19 13:31:05 +02:00
Jesse Szwedko
508a23430b Default app.Writer to os.Stdout 
As NewApp() does.

Fixes #545
 2016-10-18 20:56:31 -07:00
Dan Buch
dd253d122c
Write err to stderr, exit 1 if err != "" 
Closes #475
 2016-07-24 11:57:51 -04:00
Jesse Szwedko
65da20beab Correctly show help message if -h is provided to subcommand 
Currently, if an action is specified on a subcommand, it ignores the
`-h` and `--help` flags if passed to the subcommand, e.g.:

`foo bar -h`

would call the default action on `bar` rather than show the help
documentation.

Fixes #477
 2016-07-13 14:48:16 -07:00
Dan Buch
3c5afd4757
Hide help command for category tests 2016-06-22 09:48:39 -04:00
Dan Buch
5a3515fdf8
Focus on catching fewer panics in HandleAction 
so that "unknown" panics can still bubble up.
 2016-06-09 17:32:00 -04:00
Matt Farina
2f4ec31264 Fixed spelling and gofmt issues 2016-05-09 09:40:09 -04:00
Dan Buch
dfa9a87bee
Add tests for App.VisibleCategories & App.VisibleCommands 2016-05-08 23:54:12 -04:00
Dan Buch
cc481d6b0e
Adjust command hiding to use similar convention as hidden flags 
plus breaking out "setup" portion of `App.Run` into its own method, cleaning up
some bits of the help templates, and allowing for runtime opt-in of displaying
template errors to stderr.
 2016-05-03 06:54:05 -04:00
Dan Buch
4cae17cfe1
Ensure MultiError returned when both Before and After funcs given 2016-04-28 17:15:16 -04:00
Dan Buch
61d4175525
Merge remote-tracking branch 'origin/master' into txgruppi-develop 2016-04-28 16:20:02 -04:00
Dan Buch
2c0e13ecf8
Revising/adding tests that assert order of operations inside App.Run 2016-04-28 16:05:14 -04:00
Dan Buch
b453bf5940
Clarifying errors returned from HandleAction + tests 2016-04-28 11:03:10 -04:00
Dan Buch
b7329f4968
Switch from multi-return with exit codes to ExitCoder check 2016-04-27 09:12:34 -04:00
Dan Buch
10c8309d84
Merge branch 'develop' of https://github.com/txgruppi/cli into txgruppi-develop 2016-04-25 18:10:10 -04:00
Jesse Szwedko
042842b819 Remove CategorizedHelp from App and allow subcommands to have categories 
Just place all subcommands in categories, the default category will be
"" which will properly format the output (and group commands that have
no category).

Also allow subcommands to have categories.

Lastly, augment the test to check the output.
 2016-03-20 12:17:13 -07:00
Soulou
d0997e8f99 Set Categories as a read-only method and fix tests 2016-03-20 11:35:26 -07:00
adamclerk
cde8418658 Fixes spelling issues and import alphabetical issues 
Using goreportcard.com I noticed a few spelling errors. I really love codegangsta/cli
and wanted to help improve it.
 2016-02-09 09:36:13 -07:00
Jesse Szwedko
d5f087da9d Merge pull request #289 from KSubedi/master 
Added command to have a custom text on the USAGE section of help
 2016-02-06 13:12:10 -08:00
Gregor Noczinski
c462071a52 * Added ability to customize usage error messages 2016-02-06 21:39:35 +01:00
Andreas Kupries
bb4e78eb6a Fixed mishandling of a "-"(dash)-argument causing reordering of cli non-flag arguments. 
Added test demonstrating issue (PASS with fix, FAIL without).
 2016-01-26 15:34:53 -08:00
Gregor Noczinski
f90cd56647 Handle Before and After of Command without handling it as subCommand if there is no subCommand. 2015-12-25 21:45:58 +01:00
Håvard Haugen
7b94fd3aad test: avoid output from "go test" when tests pass 
Some tests where printing to os.Stdout as a side effect even if the
output was not used/checked in the test.
 2015-11-28 18:26:10 +01:00
Jesse Szwedko
4fc241fb17 Update examples to use correct naming convention 
See https://golang.org/pkg/testing/#hdr-Examples
 2015-11-15 13:14:11 -08:00
Kaushal Subedi
c70ad9b688 fixed tests 2015-10-24 23:51:06 -06:00
Tristan Zajonc
c7aac252f1 add tests 2015-08-12 22:14:26 -07:00
Tristan Zajonc
aced6e8739 fix tests 2015-08-12 21:43:14 -07:00
Tarcísio Gruppi
1510d7e722
Updated tests to support exit code 2015-07-28 20:29:13 +02:00
Edward Sheffler III
8ea1232ede Improve vendoring options by removing self-referential imports in tests. 2015-07-20 12:28:51 -07:00
Brian Goff
758ad1e836 Sets a subcommand's parent cmd 
This allows the help output to show the correct/full command path to the
subcommand.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
 2015-07-02 14:47:49 -04:00
Fabian Ruff
a2d4ae5939 Fix global flags processing on top level 
This fixes a regression introduced by #227. When looking up global flags by walking up the parent context's we need to consider the special case when we are starting at the very top and there is no parent context to start the traversal.

Fixes #252
 2015-06-29 23:20:27 +02:00
Dan Buch
4407569431 Merge branch 'master' into fix-231 2015-06-11 01:23:20 -04:00
Jesse Szwedko
55b8924c2b Merge pull request #230 from codegangsta/do-not-swallow-after-error 
Aggregate errors from Before/After
 2015-06-02 20:29:44 -07:00
Jesse Szwedko
2272dad83e Version and help check should look for local flags too 
Now that Global looks up the chain of contexts, the top level should
access the flags without the prefix (i.e. Bool rather than GlobalBool).
 2015-06-02 20:16:44 -07:00
Jesse Szwedko
854c52192c Merge pull request #227 from databus23/global-flags-from-all-parents 
Collect global flags from the full command hierarchy
 2015-06-01 21:25:30 -07:00
Jesse Szwedko
7ed7a51f86 Aggregate errors from Before/After 
Previously `After` would overwrite any error from `Before`.
 2015-06-01 21:14:53 -07:00
Sergey Romanov
f47f7b7e85 Fix panic if Valus in Int/StringSliceFlasg is missing 2015-06-01 01:50:23 +05:00
Fabian Ruff
65d50017d4 search context hierachy for global flags 2015-05-18 23:21:33 +02:00
jszwedko
b8104e5da7 Set writer when running command as app 
Also add test from https://github.com/codegangsta/cli/pull/202 with
slight modifications.
 2015-05-03 18:37:51 -07:00
jszwedko
e842547421 Readd printHelp function back 
But update signature to take a writer. This is a backwards incompatible
change for those overriding the HelpPrinter, but the hope is that this
feature is largely unused and the usage is easily updated.
 2015-05-03 17:43:52 -07:00
jszwedko
daad50e530 Turns out I didn't mean to add ExampleAppCommands at all 2015-03-16 18:48:06 -07:00
jszwedko
474646abed Didn't mean to remove ExampleAppSubcommand 
Also specify struct field initializers
 2015-03-16 18:04:57 -07:00
jszwedko
bf65971a6a Add Command.Aliases and deprecate Command.ShortName 
`Aliases` will be more flexible while still allowing "ShortName"
behaviour via `Aliases`.
 2015-03-09 21:24:57 -07:00
jszwedko
01cdaa065a Merge remote-tracking branch 'origin/master' into add-multi-author-support 
Conflicts:
	app.go
 2015-03-09 19:20:56 -07:00
Harrison
c6592bb487 app, help: add backwards compatibility for Authors 2015-02-21 10:44:00 +11:00
Jesse Szwedko
532d0bc2e3 Merge pull request #151 from imdario/master 
After: companion action for Before
 2015-02-20 16:20:12 -05:00