Jesse Szwedko
d53eb99165
Merge pull request #531 from keloyang/SkipFlagParsing-SkipArgReorder-bugfix
...
bug fix when SkipFlagParsing is false and SkipArgReorder is true
2016-09-17 14:38:06 -07:00
Shukui Yang
5d108a4435
bug fix when SkipFlagParsing is false and SkipArgReorder is true
...
Signed-off-by: Shukui Yang <yangshukui@huawei.com>
2016-09-12 21:30:33 +08:00
Jesse Szwedko
61f519fe5e
Merge pull request #528 from urfave/backport-no-arg-reordering
...
Backport no argument reordering as an option
2016-09-11 20:00:11 -07:00
Frances Bar
3df4b71842
Backport no argument reordering as an option
...
In the unreleased version 2, the argument reordering has been removed
(in f585ec7cb8Fixes #515
2016-09-11 12:04:35 -07:00
86b8c43eaf
Merge pull request #521 from urfave/update-wording-around-gopkgin
...
Update wording around gopkg.in pinning to be more accurate
2016-09-11 14:27:17 -04:00
b425397570
Merge branch 'master' into update-wording-around-gopkgin
2016-09-11 11:43:05 -04:00
bf7166a9d7
Merge pull request #527 from urfave/dereference-flag-pointers
...
Dereference `Flag`s if they are pointers
2016-09-11 11:42:40 -04:00
Jesse Szwedko
e7b1833f53
Dereference Flags if they are pointers
...
When checking if environment variables are set.
We don't support pointer flags currently (though this is the default in
the `v2` branch), but this fixes #516
2016-09-08 21:10:46 -07:00
c723b19a84
Merge pull request #522 from nthnca/typo
...
Fix typo in README
2016-09-05 07:50:38 -04:00
Nathan Bullock
76164d6e36
Fix typo in README
...
cosumized -> customized
2016-09-05 07:16:05 -04:00
Jesse Szwedko
4b62cb6b33
Update wording around gopkg.in pinning to be more accurate
...
Since we have `v1.X` tags, gopkg.in/urfave/cli.v1 will pull the latest
tagged release rather than the `v1` branch. Since there are no tagged
`v2` releases, `gopkg.in` will pull the latest commit of that branch.
Fixes #513
2016-09-03 14:23:36 -07:00
Jesse Szwedko
df95e0708f
Manually set import in altsrc flag generation
...
Otherwise `goimports` switches it to `github.com/urfave/cli`
2016-09-03 14:22:45 -07:00
Jesse Szwedko
33bb4c1213
Merge pull request #511 from grubernaut/f-update-altsrc-import-v1
...
Fix import paths in altsrc
2016-08-28 13:23:14 -07:00
Jake Champlin
c75c862386
Fix import paths in altsrc
...
Uses gopkg.in as the import path for the `altsrc` package.
Fixes : #473
2016-08-27 19:09:14 -04:00
05fe449c81
Merge pull request #508 from urfave/remove-end-user-deprecation-warnings
...
remove the possiblity of end-user's seeing deprecation warnings
2016-08-23 11:25:51 -04:00
2506863832
Merge branch 'master' into remove-end-user-deprecation-warnings
2016-08-22 17:49:40 -04:00
207bb61852
Merge pull request #510 from urfave/skip-gfmrun-below-go1.3
...
Skip gfmrun installation and tests below go1.3
2016-08-22 15:54:13 -04:00
Dan Buch
c0cf41eb54
Skip gfmrun installation and tests below go1.3
2016-08-22 15:26:33 -04:00
Jesse Szwedko
a5ca09a934
fixup! remove the possiblity of end-user's seeing deprecation warnings
2016-08-21 14:06:59 -07:00
Jesse Szwedko
8e6aa34a12
remove the possiblity of end-user's seeing deprecation warnings
...
Instead use deprecation pattern described in
https://blog.golang.org/godoc-documenting-go-code .
Fixes #507
2016-08-21 13:51:55 -07:00
Jesse Szwedko
168c95418e
Ensure that EnvVar struct field exists before interrogating it
...
Otherwise you end up with `<invalid Value>` which, in practice, would
probably work, but this is cleaner.
2016-07-31 20:11:16 -07:00
d60469024a
Merge pull request #502 from urfave/fix-is-set-for-env
...
Fix context.(Global)IsSet to respect environment variables
2016-07-31 23:06:54 -04:00
Jesse Szwedko
6c1f51aa95
Fix context.(Global)IsSet to respect environment variables
...
This appeared to be the least messy approach to hack in support for
IsSet also checking environment variables to see if a particular
cli.Flag was set without making backwards incompatible changes to the
interface.
I intend to fix this more properly in v2, probably by adding another
method to the cli.Flag interface to push the responsibility down as it
occurred to me that it was really the `Flag`s themselves that offer
support for configuration via the environment as opposed to the
`context` or other supporting structures. This opens the door for the
anything implementing the `Flag` interface to have additional sources of
input while still supporting `context.IsSet`.
2016-07-31 14:14:46 -07:00
Jesse Szwedko
b616f60886
Note TOML support in README and CHANGELOG
2016-07-31 12:11:52 -07:00
Jesse Szwedko
a71fcd8f23
Merge pull request #491 from ykanda/toml-support
...
Add TOML config file loader
2016-07-31 12:06:35 -07:00
kandayasu
af0ac0f1f3
Merge branch 'master' into toml-support
2016-07-26 16:04:44 +09:00
Jesse Szwedko
d9021faab6
Merge pull request #500 from npcode/readme-remove-v
...
README: Remove unnecessary 'v' from version numbers
2016-07-25 18:14:03 -07:00
kandayasu
36b7d89bed
Fix typo
2016-07-26 01:37:18 +09:00
kandayasu
812de9e250
type "TomlMap" to private (rename TomlMap -> tomlMap)
2016-07-26 01:37:03 +09:00
Yi EungJun
c59ec842c1
README: Remove unnecessary 'v' from version numbers
...
'partay version v19.99.0' sounds 'partay version version 19.99.0'
because 'v' stands for 'version'.
2016-07-25 23:44:02 +09:00
e43a9fbf1e
Merge pull request #497 from urfave/error-behavior-changelog-mention
...
Refine error handling behavior
2016-07-24 14:53:24 -04:00
kandayasu
dd7cc7a6d2
Merge branch 'master' into toml-support
2016-07-25 02:47:48 +09:00
Dan Buch
e9688813e4
Refine error handling behavior
...
so that exit 1 happens as long as error is non-nil
2016-07-24 12:09:05 -04:00
8ae5b3d5e2
Merge pull request #496 from urfave/write-non-nil-error-message-exit-nonzero
...
Write err to stderr, exit 1 if err != ""
2016-07-24 12:06:30 -04:00
Dan Buch
dd253d122c
Write err to stderr, exit 1 if err != ""
...
Closes #475
2016-07-24 11:57:51 -04:00
492afb9149
Merge pull request #494 from urfave/bump-tested-versions
...
Bump tested go versions
2016-07-23 18:33:46 -04:00
Dan Buch
76fb6d2ab7
Pin testing on go 1.4.2
...
since 1.4.3 is lacking `vet`
2016-07-23 18:16:45 -04:00
Dan Buch
71a99921b4
Bump tested go versions
...
and (maybe?) take advantage of support for N.x version syntax
2016-07-23 17:52:19 -04:00
383ad23a88
Merge pull request #492 from urfave/goimports-iff-available
...
Ignore failed goimports installs
2016-07-23 14:52:09 -04:00
Dan Buch
8d4b6abc2b
Ignore failed goimports installs
...
since we only use it with go versions >= 1.5 anyway
2016-07-23 14:39:14 -04:00
Yasuhiro KANDA
3fc3cd6485
Add TOML config file loader
2016-07-24 01:35:11 +09:00
11c134509d
Merge pull request #485 from urfave/switch-to-gfmrun
...
Switch to renamed gfmrun tool
2016-07-16 12:11:36 -04:00
Dan Buch
2c1fd1510c
Switch to renamed gfmrun tool
2016-07-16 09:12:42 -04:00
ec402ecec5
Merge pull request #482 from urfave/runtests-gen-all
...
Generate all code when checking for changes
2016-07-14 17:11:45 -04:00
Dan Buch
cbaa419c8f
Generate all code when checking for changes
2016-07-14 16:02:57 -04:00
f4ee034378
Merge pull request #481 from urfave/fix-subcommand-help-flag
...
Correctly show help message if `-h` is provided to subcommand
2016-07-14 16:00:57 -04:00
Jesse Szwedko
65da20beab
Correctly show help message if -h is provided to subcommand
...
Currently, if an action is specified on a subcommand, it ignores the
`-h` and `--help` flags if passed to the subcommand, e.g.:
`foo bar -h`
would call the default action on `bar` rather than show the help
documentation.
Fixes #477
2016-07-13 14:48:16 -07:00
Jesse Szwedko
73aa67b7a2
Merge pull request #466 from urfave/flag-context-gen
...
Generate code for flag types and context accessors
2016-07-13 14:07:04 -07:00
Dan Buch
8a7c9b1e68
Merge remote-tracking branch 'origin/master' into flag-context-gen
2016-07-12 13:15:25 -04:00
3a5216227e
Merge pull request #479 from urfave/drop-go1.1.2-testing
...
Drop testing of go1.1.2
2016-07-12 13:14:36 -04:00
