Commit Graph

149 Commits

Author SHA1 Message Date
Michael Schuett 9720ac029c Basic working flag category support 2019-01-27 15:48:00 -05:00
Michael Schuett 9dd96e9e90 Add in Category to Flag interface 2019-01-27 11:41:54 -05:00
Gábor Lipták c6eb2a0510 Correct go vet for Go tip
https://travis-ci.org/cloudflare/logshare/jobs/309796141#L646
2017-11-30 19:43:12 -05:00
Tyler Davis 40263f4d6a Merge branch 'master' into master 2017-10-13 12:05:14 -07:00
Sebastian Sprenger c202606a17 fix golint issues 2017-10-06 07:29:13 +02:00
Tyler Davis 172bb92059 fix named parameter issue 2017-06-28 10:07:25 -07:00
Tyler Davis 530df59178 Pass context into handleExitCoder 2017-06-28 09:52:12 -07:00
Tyler Davis ceee6408d5 Revert "Fix how to do defaults in app.go"
This reverts commit 8906567dc2ad52fd31c50cf02fa606505a1323ba.
2017-06-28 09:38:48 -07:00
Tyler Davis 80b09a4d11 Fix how to do defaults in app.go 2017-06-28 09:38:48 -07:00
Tyler Davis 827da610b4 Add a bit more documentation 2017-06-28 09:38:48 -07:00
Tyler Davis c48a829640 Allow custom exit err handlers 2017-06-28 09:38:48 -07:00
Jesse Szwedko c64d74a5d9 Do not double print errors from Before()
They should be handled by HandleExitCoder() as `After()` errors are.
2017-06-24 19:57:19 -07:00
Harshavardhana baa33cb888 Add support for ExtraInfo. 2017-05-08 09:53:53 -07:00
Harshavardhana f7d6a07f2d Add support for custom help templates. 2017-05-08 09:53:53 -07:00
Kasey Klipsch 8fa549846e #556 broke the api for users who were using the ActionFunc 2016-11-21 09:47:23 -06:00
Joshua Rubin 2da42640ad Merge remote-tracking branch 'origin/master' into completion_fix 2016-11-18 09:28:39 -07:00
Joshua Rubin 8dd1962f7b change "complete" to "shellComplete" 2016-11-14 09:35:22 -07:00
Jesse Szwedko e367fafa3d Return an error when parsing environment variables for values fails
Currently cli silently (aside from IntSlice and Int64Slice which oddly
printed directly to the error stream) ignores failures that occur when
parsing environment variables for their value for flags that define
environment variables. Instead, we should propogate up the error to the
user.

This is accomplished in a backwards compatible manner by adding a new,
internal, interface which defines an applyWithError function that all
flags here define. In v2, when we can modify the interface, we can drop
this secondary interface and modify `Apply` to return an error.
2016-11-13 14:59:35 -08:00
Jesse Szwedko 0113f56d10 If no action is specified on the command or app, print the help documentation
Rather than panic'ing or displaying an opaque error message about the
signature which is more confusing to the end user.

Fixes #562
2016-11-12 13:37:07 -08:00
Joshua Rubin ea3df26e64 make shell autocomplete more robust 2016-11-04 14:56:28 -06:00
Jesse Szwedko b377b5d9e9 Use type assertions rather than reflection to determine how to call the Action
This has some benefits, but results in possibly less informative error
messaging; however, given that there are only two accepted types,
I think the error messaging is sufficient.
2016-11-01 20:33:12 -07:00
Jesse Szwedko 61db37e7ae Merge branch 'master' into default-writer 2016-10-29 18:36:19 -07:00
Jesse Szwedko f614c177b7 Merge pull request #543 from wking/app-description
app: Add App.Description
2016-10-25 21:54:02 -07:00
W. Trevor King 0c143a2a26 app: Fix trailing space for Author.String()
This code initially landed with lots of space:

  '{name}  <{email}> '

or:

  '{name} '

in 3d718330 (app, help: add support for multiple authors, 2015-01-31).
The doubled space between the name and email was removed in c6592bb4
(app, help: add backwards compatibility for Authors, 2015-02-21), but
a trailing space remained in both the email and email-less cases.
This commit removes that trailing space.
2016-10-22 15:58:07 -07:00
Richard Kovacs 4cc2bad36e Display error instead of just say command is incorrect 2016-10-19 13:31:05 +02:00
Jesse Szwedko 508a23430b Default app.Writer to os.Stdout
As NewApp() does.

Fixes #545
2016-10-18 20:56:31 -07:00
W. Trevor King c4a46a7df2 app: Add App.Description
So you can describe what the application is for without requiring
users to drill down into a particular command.
2016-10-12 08:06:41 -07:00
Jesse Szwedko a5ca09a934 fixup! remove the possiblity of end-user's seeing deprecation warnings 2016-08-21 14:06:59 -07:00
Jesse Szwedko 8e6aa34a12 remove the possiblity of end-user's seeing deprecation warnings
Instead use deprecation pattern described in
https://blog.golang.org/godoc-documenting-go-code.

Fixes #507
2016-08-21 13:51:55 -07:00
Radek Simko bef215fe3e app: Allocate Metadata map automatically 2016-07-11 07:39:58 +01:00
Dan Buch 5c7afce5b8 Add help command before category scan/sort 2016-06-22 09:34:24 -04:00
Dan Buch 5a3515fdf8 Focus on catching fewer panics in HandleAction
so that "unknown" panics can still bubble up.
2016-06-09 17:32:00 -04:00
Jesse Szwedko 024b4c6240 Update references to codegangsta to urfave (new org name)
Also add notice to README
2016-05-22 14:42:23 -07:00
Matt Farina 07ce8bf79c Cleaned up else per golint
When an if ends in a return the else is not required. golint
detects these conditions and found these.
2016-05-09 10:15:05 -04:00
Matt Farina 2f110bd745 Cleaned up exported func comments per golint 2016-05-09 10:12:59 -04:00
Matt Farina 2f4ec31264 Fixed spelling and gofmt issues 2016-05-09 09:40:09 -04:00
Dan Buch 97d2df6dd7 Merge remote-tracking branch 'origin/master' into psmit-hidden_command 2016-05-08 18:44:38 -04:00
Matt Farina 6f0b442222 Update to ErrWriter and make available on app 2016-05-06 12:14:26 -04:00
Matt Farina 2a256d4c53 Provide a variable for writing output with a default of os.Stderr 2016-05-05 10:26:53 -04:00
Dan Buch cc481d6b0e Adjust command hiding to use similar convention as hidden flags
plus breaking out "setup" portion of `App.Run` into its own method, cleaning up
some bits of the help templates, and allowing for runtime opt-in of displaying
template errors to stderr.
2016-05-03 06:54:05 -04:00
Dan Buch 4b4c07bd4f Ensure HandleAction/HandleExitCoder work correctly with *ExitError
Closes #376
2016-05-02 11:32:22 -04:00
Gert-Jan Timmer a90e2e4ff1 Fix #376 NewExitError not working, reflect vals[0] cast to Interface() was missing 2016-05-02 17:06:14 +02:00
meatballhat e0d7cbbe2c Merge pull request #372 from codegangsta/deprecation-cleanups
Cleaning up the recently-introduced deprecations
2016-05-01 09:18:56 -04:00
Dan Buch 007295e509 Cleaning up the recently-introduced deprecations
to ensure the intent, responsibility, and migration path are all more clear.
2016-05-01 09:09:54 -04:00
Dan Buch fed78b8bab Rework of hidden flag impl plus some Action func corrections 2016-05-01 08:36:17 -04:00
meatballhat e671f0b23b Merge pull request #339 from jack230230/master
Add App.Metadata
2016-04-30 09:36:46 -04:00
王振威 f72d405107 Change Extras to Metadata 2016-04-30 10:42:07 +08:00
Dan Buch 06c01a4bba A few tweaks based on feedback in #361 2016-04-29 03:01:57 -04:00
Dan Buch 4cae17cfe1 Ensure MultiError returned when both Before and After funcs given 2016-04-28 17:15:16 -04:00
Dan Buch b453bf5940 Clarifying errors returned from HandleAction + tests 2016-04-28 11:03:10 -04:00