meatballhat
63b730ef0a
Merge commit '234972e' into v3-porting
2022-11-07 08:10:13 -05:00
meatballhat
3c66d6d757
Merge commit '6ff3e8e' into v3-porting
2022-11-07 08:09:48 -05:00
meatballhat
fd3354f651
Merge commit 'af3b50c' into v3-porting
2022-11-07 08:09:29 -05:00
meatballhat
16c0635dd4
Merge commit 'ade5edb' into v3-porting
2022-11-07 08:09:09 -05:00
meatballhat
874d06d6a7
Merge commit 'e3ee4fb' into v3-porting
2022-11-07 08:08:31 -05:00
meatballhat
9aa0dd753f
Merge commit 'c8147a4' into v3-porting
2022-11-07 08:05:28 -05:00
meatballhat
25897ce4dd
Merge pull request #1525 from urfave/v3-porting
...
Porting changes from `main` to `v3-dev-main` (circa 2022-10-09)
2022-10-16 14:08:16 -04:00
meatballhat
85ff0c550a
Un-regress from v3 porting losses
2022-10-13 08:15:14 -04:00
meatballhat
75aabac594
Use existing goimports installation if available
2022-10-13 07:47:17 -04:00
meatballhat
b45820714d
Build and run urfave-cli-genflags via its Makefile
...
so that `go.mod` files don't get all confused
2022-10-13 07:47:17 -04:00
meatballhat
6404f1d1b4
Backfill drop of generated GetDefaultText method
2022-10-10 10:57:06 -04:00
meatballhat
96216756c2
Remove duplicate DocGenerationFlag interface
...
introduced via merge
2022-10-09 12:41:30 -04:00
meatballhat
64facdbe2f
Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting
2022-10-09 12:40:44 -04:00
83ea416eb3
Merge pull request #1517 from dearchap/revert_remove_all_flag_interfaces
2022-10-09 11:37:29 -05:00
fcb0bce797
Fix failed test
2022-10-09 10:09:36 -04:00
924ebdaab2
Fix:(issue_1500). Fix slice flag value duplication issue
2022-10-09 10:09:36 -04:00
ea2893084b
Remove extra 3 spaces in last line
2022-10-09 09:59:46 -04:00
9a9461928a
Add test coverage for Command.VisibleCommands()
2022-10-09 09:59:46 -04:00
a4b7759ad1
Update template.go
...
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org >
2022-10-09 09:59:35 -04:00
dccd762cbb
Componentize template
2022-10-09 09:59:35 -04:00
c86805de7c
Add test case
2022-10-09 09:59:35 -04:00
ae8c5118f2
Fix command help subcommand
2022-10-09 09:59:35 -04:00
13860a7c4d
Fix:(issue_1505) Fix flag alignment in help
2022-10-09 09:59:35 -04:00
b82e628617
Add unit test for GenericFlag Destination parsing
...
The test checks if Destination provided in GenericFlag is being set as
expected.
2022-10-09 09:57:25 -04:00
01bdec784f
Set destination in GenericFlag apply function
...
The function was missing destination configuration.
2022-10-09 09:57:25 -04:00
meatballhat
c5057d195e
Only run generate on go 1.19
2022-10-09 09:51:19 -04:00
meatballhat
65c98c86ad
Ensure "generate" step runs in CI prior to diff check
2022-10-09 09:51:19 -04:00
82ea9f70c0
Call FlagStringer in String() method of slice flags
...
The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.
FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.
To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.
Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
2022-10-09 09:50:12 -04:00
4959a9fa9b
Refactor wrap() and add test for empty line
2022-10-09 09:33:19 -04:00
e14dca7a18
Run go fmt
2022-10-09 09:33:19 -04:00
05fb755b6a
wrap: Simplify loop logic
...
Suggested by @julian7
2022-10-09 09:33:19 -04:00
d3bb381a0b
Fix test for removed trailing whitespace
2022-10-09 09:33:19 -04:00
a6f5ca69f4
wrap: Avoid trailing whitespace for empty lines
2022-10-09 09:33:19 -04:00
662deaa57b
Run v2approve
2022-10-08 10:09:54 -05:00
cf41aab451
Revert changes
2022-10-08 09:57:52 -05:00
1a31a6e2fc
Revert "Remove all flag interfaces"
...
This reverts commit 268cb973f8
2022-10-08 09:47:46 -05:00
9166808eb5
Merge pull request #1510 from urfave/v3-porting
...
Porting to v3
2022-10-05 22:22:08 -04:00
meatballhat
a851a773a8
Point docs tests at v3
2022-10-03 10:12:37 -04:00
meatballhat
f8faf77e43
Post-porting fixes for v3
2022-10-03 10:06:01 -04:00
meatballhat
5db9db6d38
Remove nonexistent phony targets
...
so that running `make` or `make all` only runs targets that exist.
2022-10-03 09:46:48 -04:00
8ef92d2a24
Remove un-needed func
2022-10-03 09:46:31 -04:00
c2ecb4469f
Remove un-needed func
2022-10-03 09:46:31 -04:00
57ff098ca7
Fix:(issue_557) Make help output consistent between different invocations
2022-10-03 09:46:18 -04:00
4c637d8ac7
Fix:(issue_557) Change app help name
2022-10-03 09:35:00 -04:00
126297af13
Add more test cases
2022-10-03 09:34:46 -04:00
1e30f50959
make v2approve
2022-10-03 09:34:46 -04:00
d213683bee
Rebase main, update flag-spec.yaml to add Action field
2022-10-03 09:34:46 -04:00
f9ceca5dfa
Add more tests about flag-level action
2022-10-03 08:29:30 -04:00
e2e14ec6ef
feat: flag action
2022-10-03 08:28:44 -04:00
a2c3729797
fix: Context.Set no such flag
2022-10-03 08:15:41 -04:00
meatballhat
dearchap
Jakub Nowakowski
Felix Lange
Anatoli Babenia
Wendell Sun
torwang