Jakub Nowakowski
a2541e0fe4
Set destination in GenericFlag apply function
...
The function was missing destination configuration.
2022-10-05 22:04:46 -04:00
Jakub Nowakowski
891ffb017b
Add DestinationPointer for flags generator
...
In this commit I added a DestinationPointer variable that should be set
if the `Destination` should be configured as a pointer for a specific
flag type. It is expected that Generic type which is an interface will
not be a pointer but a struct. Before this change the code compilation
was failing with `type *Generic is pointer to interface, not interface`.
See https://github.com/urfave/cli/issues/1441
2022-10-05 22:04:46 -04:00
dearchap
b68db8d010
Merge pull request #1504 from urfave/generate-in-ci
...
Ensure "generate" step runs in CI prior to diff check
2022-10-05 20:33:29 -04:00
Naveen Gogineni
194ed2bb9b
Remove extra 3 spaces in last line
2022-10-05 20:26:45 -04:00
Naveen Gogineni
d5a1252ef3
Add test coverage for Command.VisibleCommands()
2022-10-05 20:26:45 -04:00
Naveen Gogineni
05db729d66
Do make v2approve
2022-10-05 20:26:45 -04:00
dearchap
0b2aca7ccc
Update template.go
...
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
2022-10-05 20:26:45 -04:00
Naveen Gogineni
8f6acfe15d
Componentize template
2022-10-05 20:26:45 -04:00
Naveen Gogineni
6504da449b
Add test case
2022-10-05 20:26:45 -04:00
Naveen Gogineni
2da6e68555
Fix command help subcommand
2022-10-05 20:26:45 -04:00
Naveen Gogineni
2ee2548476
Fix:(issue_1505) Fix flag alignment in help
2022-10-05 20:26:45 -04:00
dearchap
3c5c3a4aa9
Merge pull request #1508 from fjl/slice-flag-stringer
...
Call FlagStringer in String() method of slice flags
2022-10-05 20:25:01 -04:00
Felix Lange
5ff1c8dc91
Merge branch 'main' into slice-flag-stringer
2022-10-05 19:53:02 +02:00
Naveen Gogineni
a27294dcd0
Run make v2approve
2022-10-05 09:37:31 -04:00
Naveen Gogineni
2da03245be
Fix failed test
2022-10-05 09:36:22 -04:00
Naveen Gogineni
fe6f62b9b2
Fix:(issue_1500). Fix slice flag value duplication issue
2022-10-05 09:36:22 -04:00
dearchap
8335f5435f
Merge pull request #1513 from abitrolly/patch-1
...
wrap: Avoid trailing whitespace for empty lines
2022-10-05 08:33:35 -04:00
Anatoli Babenia
15b278907e
Refactor wrap() and add test for empty line
2022-10-04 13:13:52 +03:00
Anatoli Babenia
359e5a8d84
Run go fmt
2022-10-04 10:40:11 +03:00
Anatoli Babenia
1d2696072f
wrap: Simplify loop logic
...
Suggested by @julian7
2022-10-04 10:30:31 +03:00
Anatoli Babenia
59d580978e
Fix test for removed trailing whitespace
2022-10-03 19:05:46 +03:00
Anatoli Babenia
3f7774aaa3
wrap: Avoid trailing whitespace for empty lines
2022-10-03 18:53:26 +03:00
a851a773a8
Point docs tests at v3
2022-10-03 10:12:37 -04:00
f8faf77e43
Post-porting fixes for v3
2022-10-03 10:06:01 -04:00
5db9db6d38
Remove nonexistent phony targets
...
so that running `make` or `make all` only runs targets that exist.
2022-10-03 09:46:48 -04:00
Naveen Gogineni
8ef92d2a24
Remove un-needed func
2022-10-03 09:46:31 -04:00
Naveen Gogineni
c2ecb4469f
Remove un-needed func
2022-10-03 09:46:31 -04:00
Naveen Gogineni
57ff098ca7
Fix:(issue_557) Make help output consistent between different invocations
2022-10-03 09:46:18 -04:00
Naveen Gogineni
4c637d8ac7
Fix:(issue_557) Change app help name
2022-10-03 09:35:00 -04:00
Wendell Sun
126297af13
Add more test cases
2022-10-03 09:34:46 -04:00
Wendell Sun
1e30f50959
make v2approve
2022-10-03 09:34:46 -04:00
Wendell Sun
d213683bee
Rebase main, update flag-spec.yaml to add Action field
2022-10-03 09:34:46 -04:00
Wendell Sun
f9ceca5dfa
Add more tests about flag-level action
2022-10-03 08:29:30 -04:00
Wendell Sun
e2e14ec6ef
feat: flag action
2022-10-03 08:28:44 -04:00
torwang
a2c3729797
fix: Context.Set no such flag
2022-10-03 08:15:41 -04:00
Naveen Gogineni
e9e87f624d
Add unit tests
2022-10-03 08:15:23 -04:00
Naveen Gogineni
d2acd0ed55
Fix:(issue_1197) Set destination field from altsrc for slice flags
2022-10-03 08:15:23 -04:00
1c3ebfab32
Accept the MKDOCS_REMOTE_GITHUB_TOKEN var as intended
2022-10-03 08:15:01 -04:00
9ed5a09fbb
Use correct env var for global flags
2022-10-03 08:14:38 -04:00
d6c9f6a898
Replace a few more custom make targets
2022-10-03 08:14:38 -04:00
0593812915
Only run make v2diff on go 1.19.x + ubuntu-latest
2022-10-03 08:14:38 -04:00
2bec081c3a
Use windows compatible path append
2022-10-03 08:14:38 -04:00
d9d960a58a
Run make target after the Makefile is available
2022-10-03 08:14:37 -04:00
8cc0a9c5da
Move more functionality into internal/build/build.go
...
and use make targets in CI, pass flag spec YAML through yq
includes result of running `make v2approve`
2022-10-03 08:14:37 -04:00
Naveen Gogineni
8e3fa067e0
Fix: Help name consistency among app/commands and subcommands
2022-10-03 07:59:02 -04:00
Naveen Gogineni
e13c16bb10
Fix: dont generate pointer for dest for Generic flag
2022-10-03 07:58:43 -04:00
0658d61a0e
Set codecov status thresholds to 5%
...
and rename file to be less dotty
2022-10-03 07:49:45 -04:00
Naveen Gogineni
9c5b385796
Add additional test to fix codecov
2022-10-03 07:48:57 -04:00
Naveen Gogineni
5b96605ae5
Add additional test to fix codecov
2022-10-03 07:48:57 -04:00
Naveen Gogineni
2a5960c1cb
Add coverage threshold
2022-10-03 07:48:57 -04:00
