Jakub Nowakowski
a2541e0fe4
Set destination in GenericFlag apply function
...
The function was missing destination configuration.
2 years ago
Jakub Nowakowski
891ffb017b
Add DestinationPointer for flags generator
...
In this commit I added a DestinationPointer variable that should be set
if the `Destination` should be configured as a pointer for a specific
flag type. It is expected that Generic type which is an interface will
not be a pointer but a struct. Before this change the code compilation
was failing with `type *Generic is pointer to interface, not interface`.
See https://github.com/urfave/cli/issues/1441
2 years ago
dearchap
b68db8d010
Merge pull request #1504 from urfave/generate-in-ci
...
Ensure "generate" step runs in CI prior to diff check
2 years ago
Naveen Gogineni
194ed2bb9b
Remove extra 3 spaces in last line
2 years ago
Naveen Gogineni
d5a1252ef3
Add test coverage for Command.VisibleCommands()
2 years ago
Naveen Gogineni
05db729d66
Do make v2approve
2 years ago
dearchap
0b2aca7ccc
Update template.go
...
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
2 years ago
Naveen Gogineni
8f6acfe15d
Componentize template
2 years ago
Naveen Gogineni
6504da449b
Add test case
2 years ago
Naveen Gogineni
2da6e68555
Fix command help subcommand
2 years ago
Naveen Gogineni
2ee2548476
Fix:(issue_1505) Fix flag alignment in help
2 years ago
dearchap
3c5c3a4aa9
Merge pull request #1508 from fjl/slice-flag-stringer
...
Call FlagStringer in String() method of slice flags
2 years ago
Felix Lange
5ff1c8dc91
Merge branch 'main' into slice-flag-stringer
2 years ago
Naveen Gogineni
a27294dcd0
Run make v2approve
2 years ago
Naveen Gogineni
2da03245be
Fix failed test
2 years ago
Naveen Gogineni
fe6f62b9b2
Fix:(issue_1500). Fix slice flag value duplication issue
2 years ago
dearchap
8335f5435f
Merge pull request #1513 from abitrolly/patch-1
...
wrap: Avoid trailing whitespace for empty lines
2 years ago
Anatoli Babenia
15b278907e
Refactor `wrap()` and add test for empty line
2 years ago
Anatoli Babenia
359e5a8d84
Run `go fmt`
2 years ago
Anatoli Babenia
1d2696072f
wrap: Simplify loop logic
...
Suggested by @julian7
2 years ago
Anatoli Babenia
59d580978e
Fix test for removed trailing whitespace
2 years ago
Anatoli Babenia
3f7774aaa3
wrap: Avoid trailing whitespace for empty lines
2 years ago
Dan Buch
a851a773a8
Point docs tests at v3
2 years ago
Dan Buch
f8faf77e43
Post-porting fixes for v3
2 years ago
Dan Buch
5db9db6d38
Remove nonexistent phony targets
...
so that running `make` or `make all` only runs targets that exist.
2 years ago
Naveen Gogineni
8ef92d2a24
Remove un-needed func
2 years ago
Naveen Gogineni
c2ecb4469f
Remove un-needed func
2 years ago
Naveen Gogineni
57ff098ca7
Fix:(issue_557) Make help output consistent between different invocations
2 years ago
Naveen Gogineni
4c637d8ac7
Fix:(issue_557) Change app help name
2 years ago
Wendell Sun
126297af13
Add more test cases
2 years ago
Wendell Sun
1e30f50959
make v2approve
2 years ago
Wendell Sun
d213683bee
Rebase main, update flag-spec.yaml to add Action field
2 years ago
Wendell Sun
f9ceca5dfa
Add more tests about flag-level action
2 years ago
Wendell Sun
e2e14ec6ef
feat: flag action
2 years ago
torwang
a2c3729797
fix: Context.Set no such flag
2 years ago
Naveen Gogineni
e9e87f624d
Add unit tests
2 years ago
Naveen Gogineni
d2acd0ed55
Fix:(issue_1197) Set destination field from altsrc for slice flags
2 years ago
Dan Buch
1c3ebfab32
Accept the `MKDOCS_REMOTE_GITHUB_TOKEN` var as intended
2 years ago
Dan Buch
9ed5a09fbb
Use correct env var for global flags
2 years ago
Dan Buch
d6c9f6a898
Replace a few more custom make targets
2 years ago
Dan Buch
0593812915
Only run `make v2diff` on go `1.19.x` + `ubuntu-latest`
2 years ago
Dan Buch
2bec081c3a
Use windows compatible path append
2 years ago
Dan Buch
d9d960a58a
Run make target after the Makefile is available
2 years ago
Dan Buch
8cc0a9c5da
Move more functionality into internal/build/build.go
...
and use make targets in CI, pass flag spec YAML through yq
includes result of running `make v2approve`
2 years ago
Naveen Gogineni
8e3fa067e0
Fix: Help name consistency among app/commands and subcommands
2 years ago
Naveen Gogineni
e13c16bb10
Fix: dont generate pointer for dest for Generic flag
2 years ago
Dan Buch
0658d61a0e
Set codecov status thresholds to 5%
...
and rename file to be less dotty
2 years ago
Naveen Gogineni
9c5b385796
Add additional test to fix codecov
2 years ago
Naveen Gogineni
5b96605ae5
Add additional test to fix codecov
2 years ago
Naveen Gogineni
2a5960c1cb
Add coverage threshold
2 years ago