Commit Graph
26 Commits
Author SHA1 Message Date
Robert Liebowitz 3e069af0ca Merge pull request #1106 from mostynb/windows_drive_letter
Don't assume a fixed windows drive letter in tests
2020-04-14 06:33:23 -04:00
Robert Liebowitz dd51d24ce6 Merge pull request #1091 from rliebz/document-exit-errors
Update docs and tests around cli.Exit
2020-03-25 17:52:14 -04:00
Robert Liebowitz 959cf9de8a Update docs and tests around cli.Exit
Some of the docs were lacking or incomplete concerning how to properly
use cli.Exit, cli.HandleExitCoder, and the ExitErrHandler field on cli.App.
This change aims to clarify the usage of those pieces.

I also noticed that we have two identical functions now: cli.Exit and
cli.NewExitError. Since the latter seems to be more recent and less well
documented, I went ahead and marked it as deprecated so that we can keep
our public interface small.

Also added a missing test case for behavior that's been around a while
but was not documented or tested.

Related: #1089
2020-03-24 20:32:39 -04:00
Robert Liebowitz d648edd48d Merge pull request #1083 from AkihiroSuda/hide-help-command
Add HideHelpCommand
2020-03-06 07:46:02 -05:00
Robert Liebowitz 3cc9946b2a Merge pull request #1080 from saschagrunert/refactor-flag-default
Refactor '(default: …)' flag string into utility function
2020-03-05 08:19:39 -05:00
Robert Liebowitz d04c0883fc Merge pull request #1062 from zhsj/fix-zsh
Fix zsh completion scripts
2020-02-11 06:41:51 -05:00
Robert Liebowitz cc46cf9c34 Merge pull request #1067 from tsubasaxZZZ/patch-3
Added & before cli flag
2020-02-11 06:24:56 -05:00
Robert Liebowitz 2c91ec6a5b Merge pull request #1046 from urfave/lynncyrin-patch-1
Remove Appveyor button
2020-01-18 19:16:47 -05:00
Robert Liebowitz 31587d847f Merge pull request #1028 from vkd/fix-code-format
Fix code format (goimports)
2019-12-30 11:14:15 -05:00
Robert Liebowitz 25e0c70969 Merge pull request #1023 from urfave/lynncyrin-patch-2
Issue template copy updates
2019-12-27 10:47:53 -05:00
Robert Liebowitz b5bef8e0b6 Merge branch 'clean-help-printer' into help-printer-v2 2019-10-20 23:41:33 -04:00
Robert Liebowitz 9ab178d174 Make app help behavior consistent with commands 2019-10-17 05:50:38 -04:00
Robert Liebowitz bab428af09 Ensure command help always prints with overridden print functions 2019-10-17 05:12:17 -04:00
Robert Liebowitz a14194aa33 Improve documentation for HelpPrinter/HelpPrinterCustom 2019-10-16 07:57:33 -04:00
Robert Liebowitz b52cca036a Simplify duplicated function call 2019-10-16 07:24:21 -04:00
Robert Liebowitz e2a8dfe314 Decouple help printer for custom templates 2019-10-16 07:17:13 -04:00
Robert Liebowitz f5306b622f Ensure infinite loop cannot occur in parsing 2019-10-11 23:00:48 -04:00
Robert Liebowitz df740f6562 Fix infinite loop flag parsing with short options 2019-10-11 23:00:45 -04:00
Robert Liebowitz 7d46b6d7f1 Avoid panic for missing flag value
Currently, in cases where a flag value is required but not passed and
short-option handling is enabled, a panic will occur due to a nil
pointer dereference. This prevents that situation from occurring,
instead propagating the appropriate error.
2019-09-18 09:49:27 +05:30
Robert Liebowitz 06e3d38d88 Avoid panic for missing flag value
Currently, in cases where a flag value is required but not passed and
short-option handling is enabled, a panic will occur due to a nil
pointer dereference. This prevents that situation from occurring,
instead propagating the appropriate error.
2019-09-13 06:11:09 -04:00
Robert Liebowitz a77c440b84 Merge branch 'master' into combined 2019-08-06 22:33:49 -04:00
Robert LiebowitzandAjitem Sahasrabuddhe 8d31c5e167 Update README.md
Co-Authored-By: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
2019-08-05 07:05:07 -04:00
Robert Liebowitz 03153b9cf8 Allow combining short flags globally 2019-08-05 06:38:23 -04:00
Robert Liebowitz b44660ac3d Consider case when sorting strings
This makes sorting flags and other sections consistent with how most
command line tools function, by placing both flags `-A` and `-a` before
a flag `-B`.
2017-10-28 03:00:11 -04:00
Robert Liebowitz cbbe4c1a2c Add tests for custom flag prefix/env hints 2017-09-18 00:44:42 -04:00
rliebz 11d45572f9 Export funcs to configure flag prefix/env hints
This will allow users to customize the prefix section or env hint
section of the flag entries in the help menu without having to
reimplement the rest of the logic required in defining FlagStringer.
2017-09-18 00:00:27 -04:00