Merge branch 'master' into master

.github/workflows/cli.yml

@@ -58,8 +58,9 @@ jobs:
           go run build.go gfmrun docs/v2/manual.md
           go run build.go toc docs/v2/manual.md
 
-      - name: Send Coverage Report
+      - name: Upload coverage to Codecov
-        if: success()
+        if: success() && matrix.go == 1.13 && matrix.os == 'ubuntu-latest'
-        env:
+        uses: codecov/codecov-action@v1
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        with:
-        run: bash <(curl -s https://codecov.io/bash)
+          token: 0a8cc73b-bb7c-480b-8626-38a461643761
+          fail_ci_if_error: true

app.go

@@ -13,7 +13,7 @@ import (
 )
 
 var (
-	changeLogURL            = "https://github.com/urfave/cli/blob/master/CHANGELOG.md"
+	changeLogURL            = "https://github.com/urfave/cli/blob/master/docs/CHANGELOG.md"
 	appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL)
 	contactSysadmin         = "This is an error in the application.  Please contact the distributor of this application if this is not you."
 	errInvalidActionType    = NewExitError("ERROR invalid Action type. "+

appveyor.yml

@@ -20,7 +20,6 @@ install:
   - go version
   - go env
   - go get github.com/urfave/gfmrun/cmd/gfmrun
-  - go get golang.org/x/tools/cmd/goimports
   - go mod tidy
 
 build_script:

category.go

@@ -1,5 +1,6 @@
 package cli
 
+// CommandCategories interface allows for category manipulation
 type CommandCategories interface {
 	// AddCommand adds a command to a category, creating a new category if necessary.
 	AddCommand(category string, command *Command)

errors.go

@@ -48,6 +48,7 @@ func (m *multiError) Errors() []error {
 	return errs
 }
 
+// ErrorFormatter is the interface that will suitably format the error output
 type ErrorFormatter interface {
 	Format(s fmt.State, verb rune)
 }

flag_path.go

@@ -72,7 +72,7 @@ func (f *PathFlag) Apply(set *flag.FlagSet) error {
 	return nil
 }
 
-// String looks up the value of a local PathFlag, returns
+// Path looks up the value of a local PathFlag, returns
 // "" if not found
 func (c *Context) Path(name string) string {
 	if fs := lookupFlagSet(name, c); fs != nil {