diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 5601b19..eb6da39 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -58,8 +58,9 @@ jobs: go run build.go gfmrun docs/v2/manual.md go run build.go toc docs/v2/manual.md - - name: Send Coverage Report - if: success() - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} - run: bash <(curl -s https://codecov.io/bash) + - name: Upload coverage to Codecov + if: success() && matrix.go == 1.13 && matrix.os == 'ubuntu-latest' + uses: codecov/codecov-action@v1 + with: + token: 0a8cc73b-bb7c-480b-8626-38a461643761 + fail_ci_if_error: true diff --git a/app.go b/app.go index 09b13be..c04e9af 100644 --- a/app.go +++ b/app.go @@ -13,7 +13,7 @@ import ( ) var ( - changeLogURL = "https://github.com/urfave/cli/blob/master/CHANGELOG.md" + changeLogURL = "https://github.com/urfave/cli/blob/master/docs/CHANGELOG.md" appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL) contactSysadmin = "This is an error in the application. Please contact the distributor of this application if this is not you." errInvalidActionType = NewExitError("ERROR invalid Action type. "+ diff --git a/appveyor.yml b/appveyor.yml index 6ae54b2..f1cae90 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -20,10 +20,9 @@ install: - go version - go env - go get github.com/urfave/gfmrun/cmd/gfmrun - - go get golang.org/x/tools/cmd/goimports - go mod tidy build_script: - go run build.go vet - go run build.go test - - go run build.go gfmrun docs/v1/manual.md \ No newline at end of file + - go run build.go gfmrun docs/v1/manual.md diff --git a/category.go b/category.go index d9e73a0..867e390 100644 --- a/category.go +++ b/category.go @@ -1,5 +1,6 @@ package cli +// CommandCategories interface allows for category manipulation type CommandCategories interface { // AddCommand adds a command to a category, creating a new category if necessary. AddCommand(category string, command *Command) diff --git a/errors.go b/errors.go index be58903..344b436 100644 --- a/errors.go +++ b/errors.go @@ -48,6 +48,7 @@ func (m *multiError) Errors() []error { return errs } +// ErrorFormatter is the interface that will suitably format the error output type ErrorFormatter interface { Format(s fmt.State, verb rune) } diff --git a/flag_path.go b/flag_path.go index d6b23c3..a322857 100644 --- a/flag_path.go +++ b/flag_path.go @@ -72,7 +72,7 @@ func (f *PathFlag) Apply(set *flag.FlagSet) error { return nil } -// String looks up the value of a local PathFlag, returns +// Path looks up the value of a local PathFlag, returns // "" if not found func (c *Context) Path(name string) string { if fs := lookupFlagSet(name, c); fs != nil {