Merge pull request #741 from corruptmemory/expose-value
Exposed the `value` accessor in `Context`
This commit is contained in:
commit
108d39a38e
@ -114,8 +114,8 @@ func (c *Context) Lineage() []*Context {
|
||||
return lineage
|
||||
}
|
||||
|
||||
// value returns the value of the flag corresponding to `name`
|
||||
func (c *Context) value(name string) interface{} {
|
||||
// Value returns the value of the flag corresponding to `name`
|
||||
func (c *Context) Value(name string) interface{} {
|
||||
return c.flagSet.Lookup(name).Value.(flag.Getter).Get()
|
||||
}
|
||||
|
||||
|
@ -3,8 +3,8 @@ package cli
|
||||
import (
|
||||
"context"
|
||||
"flag"
|
||||
"sort"
|
||||
"os"
|
||||
"sort"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
@ -328,7 +328,7 @@ func TestContextPropagation(t *testing.T) {
|
||||
parent := NewContext(nil, nil, nil)
|
||||
parent.Context = context.WithValue(context.Background(), "key", "val")
|
||||
ctx := NewContext(nil, nil, parent)
|
||||
val := ctx.Value("key")
|
||||
val := ctx.Context.Value("key")
|
||||
if val == nil {
|
||||
t.Fatal("expected a parent context to be inherited but got nil")
|
||||
}
|
||||
|
@ -121,8 +121,8 @@ func TestFlagsFromEnv(t *testing.T) {
|
||||
a := App{
|
||||
Flags: []Flag{test.flag},
|
||||
Action: func(ctx *Context) error {
|
||||
if !reflect.DeepEqual(ctx.value(test.flag.Names()[0]), test.output) {
|
||||
t.Errorf("ex:%01d expected %q to be parsed as %#v, instead was %#v", i, test.input, test.output, ctx.value(test.flag.Names()[0]))
|
||||
if !reflect.DeepEqual(ctx.Value(test.flag.Names()[0]), test.output) {
|
||||
t.Errorf("ex:%01d expected %q to be parsed as %#v, instead was %#v", i, test.input, test.output, ctx.Value(test.flag.Names()[0]))
|
||||
}
|
||||
return nil
|
||||
},
|
||||
|
Loading…
Reference in New Issue
Block a user