Dmitry Kutakov
e17c93181f
fix ineffectual assignments
...
Warnings are produced by "ineffassign" linter
2019-12-30 20:34:27 +01:00
Robert Liebowitz
31587d847f
Merge pull request #1028 from vkd/fix-code-format
...
Fix code format (goimports)
2019-12-30 11:14:15 -05:00
lynn [they]
3eb5aec62b
Merge branch 'master' into fix-code-format
2019-12-30 02:22:41 -08:00
lynn [they]
af412c04ba
Merge pull request #1027 from vkd/fix-goimports
...
Fix import order (goimports)
2019-12-30 02:21:42 -08:00
Dmitry Kutakov
d7e6dde41e
goimports - fix code format
2019-12-30 10:41:15 +01:00
Dmitry Kutakov
0c181376a6
goimports - fix import order
...
https://github.com/golang/go/wiki/CodeReviewComments#imports
2019-12-30 10:26:21 +01:00
lynn [they]
995ba0a892
Merge pull request #1026 from vkd/refactor-tests-drop-buffer-writer
...
Refactor tests - drop mock writer
2019-12-29 17:08:06 -08:00
lynn [they]
9b991ba730
Merge branch 'master' into refactor-tests-drop-buffer-writer
2019-12-29 16:55:36 -08:00
lynn [they]
2beb7f00d3
Merge pull request #1024 from vkd/refactor-flag-names
...
Refactor the getting flag names - make it more explicit
2019-12-29 16:54:44 -08:00
lynn [they]
8d51211b11
Merge branch 'master' into refactor-flag-names
2019-12-29 16:50:52 -08:00
lynn [they]
34b298bfe2
Merge branch 'master' into refactor-tests-drop-buffer-writer
2019-12-29 16:50:46 -08:00
lynn [they]
e7b45ac3a3
Merge pull request #1025 from vkd/reduce-stdout-logs-on-tests
...
Reduce the stdout logs in tests
2019-12-29 16:48:58 -08:00
Dmitry Kutakov
ef89298b56
refactor tests - drop mock writer
...
Use bytes.Buffer instead.
2019-12-29 17:18:04 +01:00
Dmitry Kutakov
94a1912e25
reduce stdout logs in tests
...
Keep the stdout clean if all tests are passed. It helps to debug a broken test, because only a failed test prints to output.
2019-12-29 17:00:19 +01:00
Dmitry Kutakov
8c28ae347a
refactor flag names - make it more explicitly
...
avoid the using 'reflect' package while getting flag names
2019-12-29 08:58:12 +01:00
Robert Liebowitz
25e0c70969
Merge pull request #1023 from urfave/lynncyrin-patch-2
...
Issue template copy updates
2019-12-27 10:47:53 -05:00
lynn [they]
31ff2100f5
fix more copy paste tragedy
2019-12-27 04:54:31 -08:00
lynn [they]
726724e850
fix bad copy paste, h/t @rliebz
2019-12-27 04:52:51 -08:00
lynn [they]
13f3b29497
Update v2-bug-report.md
2019-12-27 04:32:02 -08:00
lynn [they]
61ac69a278
Update v1-bug-report.md
2019-12-27 04:31:38 -08:00
lynn [they]
db3269ccb9
Merge pull request #1018 from vkd/eliminate-type-assertions
...
simplify code - eliminate type assertions
2019-12-27 04:24:42 -08:00
lynn [they]
5737de6621
Create question.md
2019-12-27 03:44:05 -08:00
Dmitry Kutakov
62597fe929
simplify code - eliminate type assertions
...
"gosimple" linter says:
S1034: assigning the result of this type assertion to a variable (switch f := f.(type)) could eliminate the following type assertions:
flag.go:267:26
flag.go:270:28
flag.go:273:30
flag.go:276:29
2019-12-26 14:05:50 +01:00
lynn [they]
a56a0b93c8
Merge pull request #1016 from urfave/uncomment
...
Uncomment manual sections
2019-12-25 16:32:03 -08:00
Lynn
9c3c74b491
Revert "test changing line endings"
...
This reverts commit 813b4dd1d0
2019-12-25 09:20:44 -08:00
Lynn
813b4dd1d0
test changing line endings
2019-12-25 09:18:50 -08:00
Lynn
56dac7449a
remove appveyor
2019-12-25 09:11:53 -08:00
Lynn
8ac2777fb3
revert some stuff
2019-12-25 09:11:42 -08:00
Lynn
9c44406c87
refactor
2019-12-25 09:10:48 -08:00
Lynn
65d28dcc47
Merge remote-tracking branch 'origin' into github-actions-windows
2019-12-25 09:03:27 -08:00
Lynn
9000236c46
Merge branch 'uncomment' of github.com:urfave/cli into uncomment
2019-12-25 08:34:37 -08:00
Lynn
e491e7987e
Merge remote-tracking branch 'origin' into uncomment
2019-12-25 08:34:27 -08:00
lynn [they]
d7ea1670bd
Merge branch 'master' into uncomment
2019-12-25 08:27:22 -08:00
lynn [they]
c7f04148e9
Merge pull request #1008 from urfave/lynncyrin-patch-8
...
Add required flags documentation
2019-12-25 08:15:23 -08:00
Lynn
b4af22b7cc
bump ci
2019-12-25 08:14:39 -08:00
lynn [they]
78a8ee98a9
Merge branch 'master' into lynncyrin-patch-8
2019-12-25 08:06:25 -08:00
Lynn
82aed76272
uncomment
2019-12-25 08:05:23 -08:00
lynn [they]
aa1b27192c
Merge pull request #1001 from urfave/lynncyrin-patch-6
...
Update Github Actions to always run tests
2019-12-25 08:00:10 -08:00
lynn [they]
fe731866a5
Merge branch 'master' into lynncyrin-patch-6
2019-12-25 07:51:13 -08:00
lynn [they]
723f284a6e
Merge pull request #1014 from urfave/lynncyrin-patch-12
...
Fix 2.1.0 regression
2019-12-25 07:50:32 -08:00
Lynn Cyrin
5b57b2bf67
add changelog
2019-12-24 09:46:31 -08:00
Lynn Cyrin
b429f0381c
fix identation diff
2019-12-24 09:35:38 -08:00
Lynn Cyrin
c806e29aa5
fix doc tests
2019-12-24 09:34:31 -08:00
Lynn Cyrin
35510ee0f9
reduce diff
2019-12-24 08:58:40 -08:00
Lynn Cyrin
11777de30c
reduce diff
2019-12-24 08:58:27 -08:00
Lynn Cyrin
5d74b7723a
reduce diff
2019-12-24 08:56:36 -08:00
Lynn Cyrin
9eb7426ac3
add a fix
2019-12-24 08:55:31 -08:00
Lynn Cyrin
1651eec7b8
add a fix
2019-12-24 08:53:59 -08:00
Lynn Cyrin
b62c6419cb
new tests
2019-12-24 07:49:37 -08:00
Lynn Cyrin
7b57234c15
update gitignore
2019-12-24 07:23:36 -08:00
