Commit Graph

1903 Commits

Author SHA1 Message Date
Lynn Cyrin
b0ed044b01
add regression test to its own file 2019-08-25 09:16:41 -07:00
Lynn Cyrin
c542fb3bed
temp remove 2019-08-25 09:04:51 -07:00
Lynn Cyrin
15dc34ea12
more accurate regression reproduction 2019-08-25 08:54:06 -07:00
Sascha Grunert
38d0ac6296
Removed GetTakesFile and stick to type assertions
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
2019-08-25 17:50:18 +02:00
Lynn Cyrin
e042de5cb4
Merge remote-tracking branch 'origin/master' into pass-through-regression 2019-08-25 07:33:41 -07:00
Sascha Grunert
a1cf7f44b6
Add TakesFile to fish shell completion
The new `TakesFile` flag will be now consumed by the fish shell
completion generator.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2019-08-25 13:58:18 +02:00
Lynn Cyrin (they/them)
fa6797beef
Merge pull request #876 from urfave/lynncyrin-patch-1
Bump go version to 1.10 in readme
2019-08-24 18:58:52 -07:00
Audrius Butkevicius
82eb0d70cb
Merge branch 'master' into lynncyrin-patch-1 2019-08-25 01:04:33 +01:00
Audrius Butkevicius
2344c98f67
Merge pull request #860 from saschagrunert/takes-file-not-all
Update `TakesFile` flag to apply only to supported flags
2019-08-25 01:04:17 +01:00
Lynn Cyrin (they/them)
edd8cb2068
Bump go version to 1.10 in readme
Closes https://github.com/urfave/cli/issues/875
2019-08-24 14:44:56 -07:00
Lynn Cyrin (they/them)
68ee2bc4af
Merge branch 'master' into takes-file-not-all 2019-08-24 14:34:15 -07:00
Audrius Butkevicius
55de011cf8
Merge pull request #873 from urfave/show-test-failures
build: show failures when running tests
2019-08-24 11:55:28 +01:00
Audrius Butkevicius
d3edef887a
Update build.go 2019-08-24 11:34:03 +01:00
Lynn Cyrin
c2d1a13208
Revert "check length"
This reverts commit 1095838cca.
2019-08-24 03:05:50 -07:00
Sascha Grunert
959d9ec36b
Merge branch 'master' into takes-file-not-all 2019-08-24 11:23:51 +02:00
Lynn Cyrin (they/them)
7d62a9d054
Merge branch 'master' into show-test-failures 2019-08-24 00:50:42 -07:00
Lynn Cyrin
1095838cca
check length 2019-08-24 00:49:29 -07:00
[[ BOT ]] Lynn Cyrin
29ad6ee6ad
DRY 2019-08-23 20:09:08 -07:00
Audrius Butkevicius
392c1de1a2
Merge pull request #874 from saschagrunert/go-mod-cleanup
Cleanup go modules
2019-08-23 22:51:39 +01:00
Sascha Grunert
487c723673
Cleanup go modules
These two dependencies are not really needed, which can be
reproduced via:

```
> export GO111MODULE=on && go mod tidy
```

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2019-08-23 10:30:11 +02:00
[[ BOT ]] Lynn Cyrin
4fb1878feb
show test failures 2019-08-22 21:56:20 -07:00
[[ BOT ]] Lynn Cyrin
8469a9de07
show test failures 2019-08-22 21:42:07 -07:00
[[ BOT ]] Lynn Cyrin
74cd3bc3fe
cleanup tests 2019-08-22 21:29:33 -07:00
[[ BOT ]] Lynn Cyrin
6e8917398c
comment out tests 2019-08-22 21:23:34 -07:00
[[ BOT ]] Lynn Cyrin
e265f5087f
cleanup tests 2019-08-22 21:22:37 -07:00
[[ BOT ]] Lynn Cyrin
4381738fb5
wip regression test 2019-08-22 20:43:52 -07:00
Aaron Berns
52a016034a adjust custom-error related interface, struct and methods to reflect change in RequiredFlag interface 2019-08-20 15:39:18 -04:00
Aaron Berns
eb1734ba59 change RequiredFlagsErr to RequiredFlagErr, update to struct for custom message 2019-08-20 14:50:57 -04:00
Aaron Berns
fffdd82c00 add ability to combine multiple error strings to Error() function 2019-08-20 11:09:53 -04:00
Aaron Berns
ed4ac1876d update requiredFlagsErr interface, errRequiredFlags struct and associated functions to handle map 2019-08-20 10:39:55 -04:00
Aaron Berns
addd467e5b update checkRequiredFlags function to check RequiredFlagsErr field and return map of missing flag names with matching bool for RequiredFlagsErr value 2019-08-20 10:03:29 -04:00
Aaron Berns
a064d9082c manually add FlagsErrRequired field and function to generated flags 2019-08-20 08:56:35 -04:00
Aaron Berns
95f45c1e60 add RequiredFlagsErr interface 2019-08-19 12:06:19 -04:00
Lynn Cyrin (they/them)
23c8303026
Merge pull request #862 from russoj88/UpdateREADME_gopkg.in_v1
Rewrite the "pinning to v1" section.
2019-08-17 11:24:05 -07:00
russoj88
6a25af9641
Merge branch 'master' into UpdateREADME_gopkg.in_v1 2019-08-17 10:01:35 -07:00
Audrius Butkevicius
ecd576e779
Merge pull request #868 from urfave/lynncyrin-patch-1
Modernize readme
2019-08-17 16:51:43 +01:00
Lynn Cyrin (they/them)
e11183fe50
Modernize readme
I assume that people no longer care about what the package was named many years ago
2019-08-17 02:44:49 -07:00
russoj88
3bc62c4fde Mimic v2 example code from above. 2019-08-15 12:30:29 -07:00
russoj88
62b8a7cc2c Add "Using v1 releases" to table of contents. 2019-08-14 11:21:56 -07:00
russoj88
cc091db561
Update README.md
Only instruct on right way to use library.

Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>
2019-08-14 11:21:40 -07:00
russoj88
f529dad70c
Update README.md
Include suggestion to put example in.

Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>
2019-08-14 11:20:58 -07:00
russoj88
f2c26bab77 Rewrite the "pinning to v1" section. 2019-08-13 21:10:38 -07:00
Sascha Grunert
3681b057c5
Update TakesFile flag to apply only to supported flags
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2019-08-13 09:43:57 +02:00
Audrius Butkevicius
6cc7e987c4
Merge pull request #856 from FaranIdo/master
Add Subcommand fallback call to ExitErrHandler, fixing #816
2019-08-12 21:30:37 +01:00
FaranIdo
08c24e22ed add missing ExitErrHandler in command + matching test, fixing #816 2019-08-12 00:29:46 +03:00
Ajitem Sahasrabuddhe
7e49cc210a
Merge pull request #848 from saschagrunert/fish-shell
Add fish shell completion support
2019-08-10 09:01:16 +00:00
Ajitem Sahasrabuddhe
4e42a2f02c
Merge branch 'master' into fish-shell 2019-08-10 08:47:31 +00:00
Ajitem Sahasrabuddhe
8b18c71e1a
Merge pull request #851 from saschagrunert/takes-file
Add `TakesFile` indicator to flag
2019-08-10 08:47:23 +00:00
Ajitem Sahasrabuddhe
56d12d0c2f
Merge branch 'master' into fish-shell 2019-08-09 17:21:24 +05:30
Sascha Grunert
c6c200864d
Merge branch 'master' into takes-file 2019-08-09 13:48:36 +02:00