Commit Graph

2622 Commits

Author SHA1 Message Date
Naveen Gogineni 42eb492258 Rename function 2022-10-02 10:39:54 -04:00
Naveen Gogineni 42d8058ed9 Fix:(issue_1094) Dont execute Before/After handlers during shell completion 2022-10-02 10:39:54 -04:00
Hayden 2b1a8cad54 rename filename to dirPath 2022-10-02 10:37:49 -04:00
Hayden 87f003f087 pass in correct root 2022-10-02 10:37:35 -04:00
Hayden d217a5ac6c wip: add --walk flag to gfrun to accept directory 2022-10-02 10:37:24 -04:00
Hayden 8036eac8dc add tags and boost for pages 2022-10-02 10:36:43 -04:00
Hayden 7cfafe8f80 add tags plugin 2022-10-02 10:36:36 -04:00
Hayden 18f8e6df0b update sidebar configuration 2022-10-02 10:36:20 -04:00
Hayden edaf885773 breakup v2 documentation 2022-10-02 10:36:14 -04:00
Hayden 1ae70fcadd split v1 docs into individual pages 2022-10-02 10:36:06 -04:00
meatballhat 76bb9f100b Shift supported go versions
and approve word-wrapping changes to godoc
2022-10-02 10:30:39 -04:00
meatballhat cbc7f1ad1d Use goimports as formatting standard
given some disagreement with gofmt that seems to have shown up in 1.19
2022-10-02 10:26:48 -04:00
meatballhat 67b3de0285 Turn off docs publishing from v3 series 2022-10-02 09:19:29 -04:00
meatballhat a5313eb2d5 Add missing go.sum entries for go 1.16.x 2022-10-02 08:50:29 -04:00
meatballhat d8de3b5483 Tidy up top-level go.mod 2022-10-02 08:50:29 -04:00
meatballhat 2ca91434a8 Move genflags tool to cmd/ and pin to previous release
to alleviate problems caused by the circular dependency of using the
same code as a library that is potentially being generated to adhere to
a different API.
2022-10-02 08:50:29 -04:00
Naveen Gogineni 45a1375078 Changes from code review 2022-10-01 19:46:52 -04:00
Naveen Gogineni bc99b5865c issue_62: Make slice options more posix like 2022-10-01 19:46:20 -04:00
Dokiy 02eb392916 Fix After not run 2022-10-01 19:18:06 -04:00
Dokiy 67f592aadb Fix HideHelp 2022-10-01 19:17:49 -04:00
miyado dd9cd61bef Fix for TimestampFlag.GetValue to return empty string without value 2022-10-01 19:17:07 -04:00
Felix Lange 72cbb3db6a Call FlagStringer in String() method of slice flags
The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.

FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.

To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.

Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
2022-09-30 15:01:22 +02:00
meatballhat 40d886b0e6 Add stub for v3 docs + point gfmrun there instead 2022-09-30 08:13:34 -04:00
meatballhat 507530d5f7 Merge branch 'main' into generate-in-ci 2022-09-29 20:51:19 -04:00
meatballhat d4a5c397f4 Accept current godoc for v2 2022-09-29 20:46:53 -04:00
meatballhat cb040b67a0 Only run generate on go 1.19 2022-09-29 20:44:37 -04:00
meatballhat 6491ddec12 Merge pull request #1503 from urfave/rm-nonexistent-phonies
Remove nonexistent phony targets
2022-09-29 20:43:05 -04:00
meatballhat 38abd8db41 Ensure "generate" step runs in CI prior to diff check 2022-09-29 11:31:40 -04:00
meatballhat ac4e5143d2 Remove nonexistent phony targets
so that running `make` or `make all` only runs targets that exist.
2022-09-29 11:24:42 -04:00
meatballhat 22ff9a34c9 Soft revert go.mod version bump 2022-09-29 07:59:21 -04:00
dearchap de83493182 Merge pull request #1499 from dearchap/issue_557
Fix help results inconsistency
2022-09-23 08:15:07 -04:00
dearchap a81e201383 Merge pull request #1337 from xwjdsh/feat/flag-action
Flag-level Action
2022-09-22 07:43:28 -04:00
Naveen Gogineni d6395333f1 Remove un-needed func 2022-09-21 18:28:31 -04:00
Naveen Gogineni aecd7c159a Remove un-needed func 2022-09-21 18:28:31 -04:00
Naveen Gogineni 4c9651575c Approval for public API change 2022-09-21 18:28:31 -04:00
Naveen Gogineni e925d26b97 Fix:(issue_557) Make help output consistent between different invocations 2022-09-21 18:28:31 -04:00
Naveen Gogineni 0ee87b411a Fix:(issue_557) Change app help name 2022-09-21 18:28:31 -04:00
dearchap 9f465af482 Merge pull request #1497 from Torwang1/main
fix: Context.Set no such flag
2022-09-20 20:16:49 -04:00
torwang 3005438a1f fix: Context.Set no such flag 2022-09-20 16:15:59 +08:00
Wendell Sun 47f6782a90 Add more test cases 2022-09-17 16:05:26 +09:00
Wendell Sun 7570aace82 make v2approve 2022-09-16 00:42:24 +09:00
Wendell Sun b33117618a Rebase main, update flag-spec.yaml to add Action field 2022-09-16 00:38:20 +09:00
Wendell Sun 602471bf21 Add more tests about flag-level action 2022-09-16 00:07:15 +09:00
Wendell Sun 619958c3d2 Add ActionableFlag interface instead of modifying Flag interface directly 2022-09-16 00:07:14 +09:00
Wendell Sun 14366f7030 feat: flag action 2022-09-16 00:07:12 +09:00
dearchap 880a802dc8 Merge pull request #1495 from dearchap/issue_1197
Fix:(issue_1197) Set destination field from altsrc for slice flags
2022-09-15 07:15:04 -04:00
Naveen Gogineni c8dc60b5e6 Add unit tests 2022-09-12 13:40:37 -04:00
Naveen Gogineni 9e51113ba4 Fix:(issue_1197) Set destination field from altsrc for slice flags 2022-09-12 13:40:37 -04:00
meatballhat 9120e06825 Merge pull request #1493 from urfave/fix-mkdocs-remote
Accept the `MKDOCS_REMOTE_GITHUB_TOKEN` var as intended
2022-09-12 10:15:51 -04:00
meatballhat 93a3190684 Bump declared module and internal usage to /v3/ 2022-09-12 07:51:51 -04:00