Kir Kolyshkin
3df9a3cd86
Don't call open("") ( #1336 )
...
strings.Split(s, sep) returns a slice of a single element containing s
if sep is not found in s. This is true even if s is empty.
As a result, every call to flagFromEnvOrFile results in an attempt to
open a file with empty name. This is seen from strace as
[pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
...
To fix, check if the string is empty before calling ReadFile.
This also fixes cases where filePath is non-empty but has extra commas.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
3 years ago
Chenxiao Zhao
1bf639b391
remove useless variable declarations ( #1330 )
3 years ago
Daniel Mil
175bb8742c
Bump yaml.v2 version to 2.2.8 ( #1326 )
...
* Bump yamlv2 version
* Update max binary size to fix security vulnerability
3 years ago
Robert Liebowitz
5d61a2f46e
Bump Go version range in CI to 1.15-1.17 ( #1323 )
3 years ago
badcw
e855c4cd1d
fix: Nil pointer when getting context's flagSet( #1325 ) ( #1327 )
...
* fix: Nil pointer when getting context's flagSet in UsageError function(#1325 )
* test: add unit test for nil flagset in Context
3 years ago
Anthony Fok
c2cf7ed6df
Bump github.com/cpuguy83/go-md2man/v2 to v2.0.1 ( #1321 )
...
Also fix test expectation for man contents: dash and underscore
are no longer escaped with backslash in go-md2man v2.0.1
See cpuguy83/go-md2man#74
3 years ago
Anthony Fok
a7d59840f4
Fix reversed Got/Expected in expectFileContent in docs_test.go ( #1320 )
3 years ago
Mritunjay Kumar Sharma
9afa0745ed
docs: Added some deprecated parts in migrating to v2 ( #1319 )
...
Co-authored-by: Robert Liebowitz <rliebz@gmail.com>
3 years ago
Tom Limoncelli
56bfa4be20
DOCS: Replace deprecated functions ( #1317 )
3 years ago
William Wilson
e8d8173889
Make test case compatible with Go 1.17 ( #1299 )
...
* Make test case compatible with Go 1.17
* tweak test case to bring coverage back up
3 years ago
John Olheiser
12b7dfd08c
Remove extraneous line from generated markdown ( #1311 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com>
3 years ago
JayCeeJr
1259f1efc9
Unnecessary words ( #1304 )
...
It is unclear what `as the default` means.
Much more concise to remove it.
3 years ago
Robert Liebowitz
67d7f9403d
Remove stalebot ( #1300 )
3 years ago
Ally Dale
58d113dd73
fix #1239 : slice flag value don't append to default values from ENV or file ( #1240 )
...
* fix #1239 : slice flag value don't append to default values from ENV or file
* remove test code
3 years ago
Link Dupont
6373f5bf65
feat(docs): Include Description and UsageText in docs output ( #1287 )
...
Include Description as part of the DESCRIPTION section, and put UsageText (if it is non-zero) into the Usage subsection.
3 years ago
Ashwani
b5d4a04c7f
Resolved a grammatical error ( #1281 )
3 years ago
Derek Smith
443c6a54a8
fix(UsageText): consistent indent for help UsageText output ( #1279 )
...
Signed-off-by: Derek Smith <dsmith@goodwaygroup.com>
3 years ago
Derek Smith
581b769cf3
feat(docs): add UsageText to docs output for markdown and man page generation ( #1171 )
...
* feat(docs): add UsageText to docs output for markdown and man page generation
* feat(docs): updated tests, DRYd up code, cleaned up string logic
* fix(lint): fixed go1.15 lint errors
3 years ago
Naveen Gogineni
6936697647
Change min binary size
3 years ago
Naveen Gogineni
7cd7ff7dd5
Remove reflect from flag_test
3 years ago
Naveen Gogineni
50c71ed517
Remove reflect calls for doc generation
3 years ago
Robert Liebowitz
e79ceb69ff
Merge pull request #1258 from dearchap/visible_interface
...
Fix(issue #631 ). Remove reflect calls for Hidden field
3 years ago
Robert Liebowitz
75602a4cfe
Merge pull request #1236 from vipally/ally_fix_default_val
...
bug fix #1235 : default value changes with parsed values on slice flags
3 years ago
Robert Liebowitz
ab52d6f3a9
Merge branch 'master' into ally_fix_default_val
3 years ago
Robert Liebowitz
b1a2d969f8
Merge pull request #1270 from rliebz/no-cov-token
...
Update GitHub action
3 years ago
Robert Liebowitz
80ba835e26
Update GitHub action
...
Bump go version to 1.16 and drop the codecov token, which is now
documented as not required for public repositories.
3 years ago
Robert Liebowitz
b7da09a687
Merge pull request #1255 from cpacifying/master
...
UsageText to be passed from Command to App in startApp
3 years ago
Robert Liebowitz
45eecb1d94
Merge pull request #1264 from dearchap/cleanup_context
...
Cleanup context.go
3 years ago
Robert Liebowitz
45952a7d1b
Merge pull request #1251 from davidsbond/timestamp-destination
...
Add Destination field to TimestampFlag
4 years ago
Naveen Gogineni
07e1fdf17d
Cleanup context.go
4 years ago
Naveen Gogineni
df595c0d85
Fix(issue #631 ). Remove reflect calls for Hidden field
4 years ago
cpacifying
9433f216ff
UsageText to be passed from Command to App in startApp
4 years ago
David Bond
f2bed637fd
Add Destination field to TimestampFlag
...
Adds a `Destination` field for the `TimestampFlag` type that allows you to specify a pointer to
a `Timestamp` rather than having to grab the `Timestamp` from the `cli.Context` using the flag
name.
4 years ago
lynn (they)
13ded1e7c4
Merge pull request #1229 from urfave/lynncyrin-patch-1
...
Don't let stale bot close "help wanted" issues
4 years ago
Ally Dale
06f6815b8d
revert docs/v2/manual.md
4 years ago
Ally Dale
ef9430e77e
fix #1238 : accept multi-value input on sclice flags
4 years ago
AllyDale
c98b85d392
bug fix #1235 : default value changes with parsed values on slice flags
4 years ago
Robert Liebowitz
92d77844fe
Merge pull request #1232 from corburn/patch-2
...
remove repeated comment
4 years ago
Jason Travis
1985ecfdc0
remove repeated comment
4 years ago
Robert Liebowitz
5378891c91
Merge pull request #1210 from jcgregorio/fix-context-value
...
Fix Context.Value.
4 years ago
Robert Liebowitz
795a8adacb
Merge pull request #1208 from Madhur1997/master
...
Display `(accepts multiple inputs)` in the help description for Slice flags.
4 years ago
Robert Liebowitz
498b50b3e1
Merge pull request #1214 from anicoll/flag_lineage_fix
...
fix for parent context not setting child flags
4 years ago
lynn (they)
e1a74460d4
Merge pull request #1227 from nmi/fix_man_section
...
make the man page section selectable
4 years ago
lynn (they)
de20a55d0e
Merge pull request #1228 from zwass/patch-1
...
Link to godoc for v2
4 years ago
Joe Gregorio
d56c85cef5
Add test for the else path.
4 years ago
Joe Gregorio
b8debb6845
Fix Context.Value.
...
Before this change the added test would crash on a nil
pointer dereference because the original code would
only look in the local fileSet and not across all
the fileSets.
4 years ago
Madhur batra
e73d6e133d
Merge branch 'master' of https://github.com/urfave/cli
4 years ago
Nobuhiro MIKI
ed2ee4bc4a
make the man page section selectable
...
Signed-off-by: Nobuhiro MIKI <nob@bobuhiro11.net>
4 years ago
Zach Wasserman
797d5a8d46
Link directly to pkg.go.dev
4 years ago
Andrew Nicoll
06e7bdec34
add test for nil
4 years ago