Ajitem Sahasrabuddhe
daf1f71152
Update cli.yml
...
fix syntax error
2020-01-13 22:11:38 +05:30
Ajitem Sahasrabuddhe
8fe6194446
Merge branch 'master' into github-actions-windows
2020-01-13 22:10:45 +05:30
Ajitem Sahasrabuddhe
aee5241828
Merge branch 'master' into patch-1
2020-01-13 22:09:06 +05:30
Ajitem Sahasrabuddhe
fd475c44f2
Merge branch 'master' into doc-update-pr-template
2020-01-13 22:08:21 +05:30
Ajitem Sahasrabuddhe
d46d4eedc4
Merge pull request #1037 from urfave/master-is-failing-maybe
...
Check if master is failing
2020-01-13 22:07:56 +05:30
Ajitem Sahasrabuddhe
c4dc71ebad
Update cli.yml
...
update to nodejs 12 LTS
2020-01-13 19:02:13 +05:30
Ajitem Sahasrabuddhe
c5a0ee66b0
Update README.md
...
remove cli failing message
2020-01-13 19:01:37 +05:30
Ajitem Sahasrabuddhe
1ba20ea977
Update .github/workflows/cli.yml
...
Co-Authored-By: Robert Liebowitz <rliebz@gmail.com>
2020-01-13 18:59:36 +05:30
Ajitem Sahasrabuddhe
8915e44661
Merge branch 'master' into github-actions-windows
2020-01-13 11:29:49 +05:30
Ajitem Sahasrabuddhe
e02ef3d3c0
fix path for github actions
2020-01-13 11:22:47 +05:30
Ajitem Sahasrabuddhe
300b9985aa
fix github-actions for windows
2020-01-13 11:15:07 +05:30
Ajitem Sahasrabuddhe
f0c866e24c
try install markdown-toc globally
2020-01-13 10:59:32 +05:30
Ajitem Sahasrabuddhe
f4f10b5c16
fix dumb indentation error
2020-01-13 10:57:42 +05:30
Ajitem Sahasrabuddhe
fb0d7af151
setup node to run markdown toc
2020-01-13 10:56:43 +05:30
Ajitem Sahasrabuddhe
3e125a1865
use npx to run the package instead of npm installing it
2020-01-13 10:52:14 +05:30
j0n3lson
78ba678e4e
Modifications per review
2020-01-10 01:04:12 -08:00
lynn [they]
0b3b172855
Update README.md
2020-01-09 17:53:28 -08:00
lynn [they]
dadc675f58
Update stale.yml
2020-01-09 17:48:35 -08:00
j0n3lson
ab81cf7eac
Use a more k8s/release friendly PR template.
2020-01-09 17:11:23 -08:00
lynn [they]
3b8f4b9b22
Merge pull request #1019 from urfave/lynncyrin-patch-1
...
Create question template
2020-01-06 12:26:05 -08:00
lynn [they]
3963383574
Merge branch 'master' into lynncyrin-patch-1
2020-01-06 10:18:00 -08:00
lynn [they]
017c485e4c
Merge pull request #1031 from vkd/fix-ineffectual-assignments
...
Fix ineffectual assignments
2019-12-31 19:05:39 -08:00
lynn [they]
0da978137a
Merge branch 'master' into fix-ineffectual-assignments
2019-12-31 19:03:38 -08:00
lynn [they]
b4314428e9
Merge pull request #1032 from vkd/remove-unused
...
Remove unused code
2019-12-31 19:02:34 -08:00
Dmitry Kutakov
5998e27dd7
remove unused code
2019-12-31 16:36:01 +01:00
Dmitry Kutakov
e17c93181f
fix ineffectual assignments
...
Warnings are produced by "ineffassign" linter
2019-12-30 20:34:27 +01:00
Robert Liebowitz
31587d847f
Merge pull request #1028 from vkd/fix-code-format
...
Fix code format (goimports)
2019-12-30 11:14:15 -05:00
lynn [they]
3eb5aec62b
Merge branch 'master' into fix-code-format
2019-12-30 02:22:41 -08:00
lynn [they]
af412c04ba
Merge pull request #1027 from vkd/fix-goimports
...
Fix import order (goimports)
2019-12-30 02:21:42 -08:00
Dmitry Kutakov
d7e6dde41e
goimports - fix code format
2019-12-30 10:41:15 +01:00
Dmitry Kutakov
0c181376a6
goimports - fix import order
...
https://github.com/golang/go/wiki/CodeReviewComments#imports
2019-12-30 10:26:21 +01:00
lynn [they]
995ba0a892
Merge pull request #1026 from vkd/refactor-tests-drop-buffer-writer
...
Refactor tests - drop mock writer
2019-12-29 17:08:06 -08:00
lynn [they]
9b991ba730
Merge branch 'master' into refactor-tests-drop-buffer-writer
2019-12-29 16:55:36 -08:00
lynn [they]
2beb7f00d3
Merge pull request #1024 from vkd/refactor-flag-names
...
Refactor the getting flag names - make it more explicit
2019-12-29 16:54:44 -08:00
lynn [they]
8d51211b11
Merge branch 'master' into refactor-flag-names
2019-12-29 16:50:52 -08:00
lynn [they]
34b298bfe2
Merge branch 'master' into refactor-tests-drop-buffer-writer
2019-12-29 16:50:46 -08:00
lynn [they]
e7b45ac3a3
Merge pull request #1025 from vkd/reduce-stdout-logs-on-tests
...
Reduce the stdout logs in tests
2019-12-29 16:48:58 -08:00
Dmitry Kutakov
ef89298b56
refactor tests - drop mock writer
...
Use bytes.Buffer instead.
2019-12-29 17:18:04 +01:00
Dmitry Kutakov
94a1912e25
reduce stdout logs in tests
...
Keep the stdout clean if all tests are passed. It helps to debug a broken test, because only a failed test prints to output.
2019-12-29 17:00:19 +01:00
Dmitry Kutakov
8c28ae347a
refactor flag names - make it more explicitly
...
avoid the using 'reflect' package while getting flag names
2019-12-29 08:58:12 +01:00
Martin Lees
21ae70fe62
Removed trailing " that makes ci fail
...
Editing this on my phone, not 100% sure if this will work but we'll see
2019-12-28 23:41:32 +01:00
Martin Lees
3f80cc798f
Merge branch 'master' into patch-1
2019-12-28 23:35:18 +01:00
Robert Liebowitz
25e0c70969
Merge pull request #1023 from urfave/lynncyrin-patch-2
...
Issue template copy updates
2019-12-27 10:47:53 -05:00
lynn [they]
31ff2100f5
fix more copy paste tragedy
2019-12-27 04:54:31 -08:00
lynn [they]
726724e850
fix bad copy paste, h/t @rliebz
2019-12-27 04:52:51 -08:00
lynn [they]
13f3b29497
Update v2-bug-report.md
2019-12-27 04:32:02 -08:00
lynn [they]
61ac69a278
Update v1-bug-report.md
2019-12-27 04:31:38 -08:00
lynn [they]
db3269ccb9
Merge pull request #1018 from vkd/eliminate-type-assertions
...
simplify code - eliminate type assertions
2019-12-27 04:24:42 -08:00
lynn [they]
5737de6621
Create question.md
2019-12-27 03:44:05 -08:00
Dmitry Kutakov
62597fe929
simplify code - eliminate type assertions
...
"gosimple" linter says:
S1034: assigning the result of this type assertion to a variable (switch f := f.(type)) could eliminate the following type assertions:
flag.go:267:26
flag.go:270:28
flag.go:273:30
flag.go:276:29
2019-12-26 14:05:50 +01:00
