Commit Graph

805 Commits

Author SHA1 Message Date
Dan Buch
86e4f9526d
Merge branch 'master' of https://github.com/joshuarubin/cli into joshuarubin-master 2016-06-08 10:31:40 -04:00
8b2531778f Merge pull request #446 from jamescun/master
Fix ActionFunc signature of ShowAppHelp action
2016-06-08 10:31:04 -04:00
Joshua Rubin
f621deee5a
fix panic getting visible flags 2016-06-08 04:27:57 -06:00
James Cunningham
e97f74a570
fix ActionFunc signature of ShowAppHelp action 2016-06-07 16:28:10 +01:00
Jesse Szwedko
3f702904c5 Merge pull request #439 from urfave/migrators
Migrator touchup and testing
2016-06-06 21:19:42 -07:00
edb24d02aa Merge pull request #445 from tianon/spaces-changelog
Add note about #441 (replace tabs with spaces for alignment) in CHANGELOG.md
2016-06-02 04:47:49 -04:00
Dan Buch
c413767d25
Fixing some flake8 gripes 2016-06-02 04:45:13 -04:00
Dan Buch
6dcb4fdfa4
Migrator script output tweaks, debug logging 2016-06-02 04:43:31 -04:00
Dan Buch
73acde8e69
Make migrators ordered, clean up some duplication 2016-06-02 04:37:36 -04:00
Tianon Gravi
dedc6e1474 Add note about #441 (replace tabs with spaces for alignment) in CHANGELOG.md 2016-06-01 20:11:31 -07:00
Jesse Szwedko
01a3382359 Merge pull request #444 from urfave/more-v1-examples
Add more v1 API examples
2016-06-01 20:01:28 -07:00
Dan Buch
288b636ba3
Modifying full API example for more migrator exercise 2016-06-01 22:27:52 -04:00
Dan Buch
92b70c22ac
Add more v1 -> v2 migrators 2016-06-01 19:11:05 -04:00
67c661770a Merge branch 'master' into more-v1-examples 2016-06-01 18:52:25 -04:00
41d262f932 Merge pull request #441 from tianon/spaces-for-alignment
Switch "printHelp" tabwriter padchar to space
2016-06-01 18:43:28 -04:00
Tianon Gravi
a121e978f7 Switch "printHelp" tabwriter padchar to space
Using tabs for alignment is troubling if the output is used for anything besides display in a terminal (or if the user's terminal allows for adjustment of the default tab size), as noted by the documentation for `tabwriter` (https://golang.org/pkg/text/tabwriter/#Writer.Init):

> (for correct-looking results, tabwidth must correspond to the tab width in the viewer displaying the result)

The safer solution is to use `' '` as the `padchar`, which only carries the assumption of a fixed-width font (which is a more reasonable assumption than a fixed, constant tab size).
2016-06-01 15:27:03 -07:00
Dan Buch
b5c48311fa
Ensure the full API example really runs 2016-06-01 14:06:51 -04:00
Dan Buch
1c81757e1f
Add more v1 API examples 2016-06-01 13:28:27 -04:00
8ce0f0c9e3 Merge branch 'v2' into migrators 2016-06-01 11:34:07 -04:00
2f3de598bf Merge pull request #443 from urfave/merging-from-v1
Merging from v1
2016-06-01 11:33:55 -04:00
Dan Buch
cb1e4c2d5e
Merge remote-tracking branch 'origin/v1' into v2 2016-06-01 11:18:40 -04:00
1433f8165e Merge pull request #442 from urfave/appveyor-badge
Update appveyor badge URL
2016-06-01 11:00:42 -04:00
Dan Buch
0990e4b2ad
Update appveyor badge URL
to point to new team name
2016-06-01 10:46:39 -04:00
ddb6f44179 Merge pull request #440 from urfave/more-v1-examples
Enable more examples as runnable in README
2016-06-01 09:49:21 -04:00
Dan Buch
733431d5c2
Wrap a long line 2016-05-31 20:59:09 -04:00
Dan Buch
cbd0e8231b
Add migrator for stringly values of flag "Name"
and reorganize things a bit for less jumpy editing
2016-05-31 20:58:12 -04:00
Dan Buch
c9011d8351
Add migrators for context.Args() indexing and EnvVars 2016-05-31 16:39:56 -04:00
Dan Buch
41310fbe1b
Enable more examples as runnable in README
so that they can be verified by the migrator script over in the v2 branch.
2016-05-31 15:49:48 -04:00
Dan Buch
e3a099f7c5
Cleanups per flake8 and code review 2016-05-30 15:24:16 -04:00
Dan Buch
659e1c1e0b
Fill in migrations for cli.Exit and BoolFlag with Value 2016-05-30 15:16:19 -04:00
1d13fa8140 Merge branch 'v2' into migrators 2016-05-30 14:00:32 -04:00
Dan Buch
2cfb957033
Run migration tests via ./runtests 2016-05-30 13:59:45 -04:00
Dan Buch
586b49ded8
Give up and use sudo on OS X again 2016-05-30 12:44:41 -04:00
Dan Buch
9158c1189d
Add dir with flake8 to path better-er 2016-05-30 12:40:13 -04:00
Dan Buch
b4db7c2b27
Do sudo-tastic system install os OS X 2016-05-30 12:34:33 -04:00
Dan Buch
27f4b751e4
Try a system pip install on OS X 2016-05-30 12:29:35 -04:00
Dan Buch
0ecae535a8
Where is flake8 on OS X? 2016-05-30 12:24:05 -04:00
Dan Buch
e5ba2f41c7
Ensure we're in the right dir before continuing 2016-05-30 11:09:37 -04:00
Dan Buch
5565a03705
Migrate and build extracted v1 examples 2016-05-30 11:02:49 -04:00
Dan Buch
3914ca9d5f
Update docs around migration script
and ensure ~/.local/bin is in PATH on OS X
2016-05-30 10:54:06 -04:00
Dan Buch
462217f9fc
Allow zero+ paths in migration script
and run the self-tests on Windows, too.
2016-05-30 10:46:00 -04:00
Dan Buch
6d59b40b68
Skip flake8 bits on Windows
since pip isn't already there, installing it is a bit of a pain, and the results
*should* be the same on all platforms
2016-05-30 10:27:44 -04:00
Dan Buch
e9027a59ef
Do a user-level install with pip 2016-05-30 10:23:21 -04:00
Dan Buch
b47e152395
Handle migration of both files and dirs 2016-05-30 10:21:13 -04:00
Dan Buch
eadd3918f1
Correct some flake8 bits 2016-05-30 09:53:47 -04:00
Dan Buch
80190b203c
Rename migration script and add more migrators 2016-05-30 09:51:12 -04:00
Jesse Szwedko
dddab48818 Merge pull request #438 from urfave/show-bool-default
Show BoolFlag default value in help usage
2016-05-28 12:03:46 -07:00
3b03164c92 Merge branch 'v2' into show-bool-default 2016-05-28 04:49:10 -04:00
Jesse Szwedko
459201f506 Merge pull request #421 from urfave/minimize-struct-copying
Minimize copying while keeping things safe-ish
2016-05-27 20:00:23 -07:00
9a18ffad6c Merge pull request #437 from urfave/formarlly
TRIVIAL formally -> formerly
2016-05-27 14:54:26 -04:00