Commit Graph

1833 Commits

Author SHA1 Message Date
Jesse Szwedko
e7b1833f53 Dereference Flags if they are pointers
When checking if environment variables are set.

We don't support pointer flags currently (though this is the default in
the `v2` branch), but this fixes #516
2016-09-08 21:10:46 -07:00
c723b19a84 Merge pull request #522 from nthnca/typo
Fix typo in README
2016-09-05 07:50:38 -04:00
Nathan Bullock
76164d6e36 Fix typo in README
cosumized -> customized
2016-09-05 07:16:05 -04:00
Jesse Szwedko
4b62cb6b33 Update wording around gopkg.in pinning to be more accurate
Since we have `v1.X` tags, gopkg.in/urfave/cli.v1 will pull the latest
tagged release rather than the `v1` branch. Since there are no tagged
`v2` releases, `gopkg.in` will pull the latest commit of that branch.

Fixes #513
2016-09-03 14:23:36 -07:00
Jesse Szwedko
df95e0708f Manually set import in altsrc flag generation
Otherwise `goimports` switches it to `github.com/urfave/cli`
2016-09-03 14:22:45 -07:00
lewo
6aa0ab6903 Merge branch 'v2' into v2-completion 2016-09-01 09:35:02 +02:00
c72728f424 Merge pull request #514 from grubernaut/f-default-value-text
Add DefaultValue text for flags
2016-08-31 13:44:05 -04:00
Jake Champlin
c8d66d7eda
Lowercase TOC to pass tests 2016-08-30 11:12:22 -04:00
Jake Champlin
51cebd042a
Update TOC in README 2016-08-30 10:56:28 -04:00
Jake Champlin
33b5174be4 Merge branch 'v2' into f-default-value-text 2016-08-30 10:53:16 -04:00
Jake Champlin
7d56512ecc
Add documentation, remove quotes by default 2016-08-30 10:52:24 -04:00
Jesse Szwedko
2616eeb540 Merge pull request #512 from grubernaut/f-update-altsrc-import-v2
Update altsrc imports to gopkg.in
2016-08-28 13:23:17 -07:00
Jesse Szwedko
33bb4c1213 Merge pull request #511 from grubernaut/f-update-altsrc-import-v1
Fix import paths in altsrc
2016-08-28 13:23:14 -07:00
Jake Champlin
e0556cf9e8
Add DefaultValue text for flags
Allows a user to override the default value of a flag in the displayed help output.

Ex:
```
cli.IntFlag{
	Name: "foo, f",
	DefaultText: "random foo",
	Value: "bar",
}
```

Running `(app.name) -h` will now yield:

```
--foo value     (default: "random foo")
```

Fixes: #504
2016-08-28 03:14:39 -04:00
Jake Champlin
2ab83fab2a
Force generation of flag types to use gopkg import 2016-08-28 01:36:49 -04:00
Jake Champlin
b93207160f
Update altsrc imports to gopkg.in
Updates altsrc imports to use `gopkg.in/urfave/cli.v2`

Fixes: #505
2016-08-27 19:14:15 -04:00
Jake Champlin
c75c862386
Fix import paths in altsrc
Uses gopkg.in as the import path for the `altsrc` package.

Fixes: #473
2016-08-27 19:09:14 -04:00
a095a5a896 Merge pull request #506 from grubernaut/v2
Abstract dependency and test execution with Makefile
2016-08-26 09:56:24 -04:00
Jake Champlin
3a3228c0e4
Abstract dependency and test execution with Makefile
Abstract the `runtests` script with a makefile, and update travis tests to use makefile abstraction.
2016-08-26 08:34:05 -04:00
05fe449c81 Merge pull request #508 from urfave/remove-end-user-deprecation-warnings
remove the possiblity of end-user's seeing deprecation warnings
2016-08-23 11:25:51 -04:00
adf6897aa2 Merge pull request #509 from urfave/merging-from-v1
Merging from v1
2016-08-23 11:25:16 -04:00
Dan Buch
812fa64d8e
Skip migrations on go < 1.3
because there won't be a `gfmrun` around to extract examples
2016-08-22 17:54:51 -04:00
2506863832 Merge branch 'master' into remove-end-user-deprecation-warnings 2016-08-22 17:49:40 -04:00
Dan Buch
87f9c6d44a
Merge remote-tracking branch 'origin/master' into merging-from-v1 2016-08-22 17:47:11 -04:00
207bb61852 Merge pull request #510 from urfave/skip-gfmrun-below-go1.3
Skip gfmrun installation and tests below go1.3
2016-08-22 15:54:13 -04:00
Dan Buch
c0cf41eb54
Skip gfmrun installation and tests below go1.3 2016-08-22 15:26:33 -04:00
Dan Buch
c5d3a341c4
Adjust some gfmrun output matches
which I assume became mismatched during merge
2016-08-22 14:56:38 -04:00
Dan Buch
81c242dda6
Merge remote-tracking branch 'origin/master' into merging-from-v1 2016-08-22 14:41:56 -04:00
Jesse Szwedko
a5ca09a934 fixup! remove the possiblity of end-user's seeing deprecation warnings 2016-08-21 14:06:59 -07:00
Jesse Szwedko
8e6aa34a12 remove the possiblity of end-user's seeing deprecation warnings
Instead use deprecation pattern described in
https://blog.golang.org/godoc-documenting-go-code.

Fixes #507
2016-08-21 13:51:55 -07:00
Antoine Eiche
8a8d8691bd Add migrator for bash related names
It migrates
- BashComplete -> ShellComplete
- EnableBashCompletion -> EnableShellCompletion
- BashCompletionFlag -> GenerateCompletionFlag
2016-08-01 14:40:20 +02:00
Jesse Szwedko
168c95418e Ensure that EnvVar struct field exists before interrogating it
Otherwise you end up with `<invalid Value>` which, in practice, would
probably work, but this is cleaner.
2016-07-31 20:11:16 -07:00
d60469024a Merge pull request #502 from urfave/fix-is-set-for-env
Fix context.(Global)IsSet to respect environment variables
2016-07-31 23:06:54 -04:00
Jesse Szwedko
6c1f51aa95 Fix context.(Global)IsSet to respect environment variables
This appeared to be the least messy approach to hack in support for
IsSet also checking environment variables to see if a particular
cli.Flag was set without making backwards incompatible changes to the
interface.

I intend to fix this more properly in v2, probably by adding another
method to the cli.Flag interface to push the responsibility down as it
occurred to me that it was really the `Flag`s themselves that offer
support for configuration via the environment as opposed to the
`context` or other supporting structures. This opens the door for the
anything implementing the `Flag` interface to have additional sources of
input while still supporting `context.IsSet`.
2016-07-31 14:14:46 -07:00
Jesse Szwedko
b616f60886 Note TOML support in README and CHANGELOG 2016-07-31 12:11:52 -07:00
Jesse Szwedko
a71fcd8f23 Merge pull request #491 from ykanda/toml-support
Add TOML config file loader
2016-07-31 12:06:35 -07:00
Antoine Eiche
94bc26fd1c Refactoring names from bash to shell
The refactoring is required since completion is also supported for zsh
shell.

Refactoring details:
- flag generate-bash-completion -> generate-completion
- var  EnableBashCompletion     -> EnableShellCompletion
- var  BashComplete             -> ShellComplete
- var  BashCompletionFlag       -> GenerateCompletionFlag
- type BashCompleteFunc         -> ShellCompleteFunc
2016-07-26 15:32:03 +02:00
Antoine Eiche
34a8b004d2 Documentation regarding the init-completion flag 2016-07-26 15:32:03 +02:00
Antoine Eiche
7640bef0eb Add --init-completion flag to print completion code
This flag takes as input 'bash' or 'zsh' and generates the completion
code for the specified shell.
2016-07-26 15:32:03 +02:00
kandayasu
af0ac0f1f3 Merge branch 'master' into toml-support 2016-07-26 16:04:44 +09:00
Jesse Szwedko
d9021faab6 Merge pull request #500 from npcode/readme-remove-v
README: Remove unnecessary 'v' from version numbers
2016-07-25 18:14:03 -07:00
kandayasu
36b7d89bed Fix typo 2016-07-26 01:37:18 +09:00
kandayasu
812de9e250 type "TomlMap" to private (rename TomlMap -> tomlMap) 2016-07-26 01:37:03 +09:00
Yi EungJun
c59ec842c1 README: Remove unnecessary 'v' from version numbers
'partay version v19.99.0' sounds 'partay version version 19.99.0'
because 'v' stands for 'version'.
2016-07-25 23:44:02 +09:00
Dan Buch
363d9c9a31
Add a hack so that zsh completion only runs for zsh 2016-07-24 17:29:13 -04:00
Dan Buch
1cbb9a7f30
Merge branch 'zsh' of https://github.com/jereksel/cli into jereksel-zsh 2016-07-24 17:12:43 -04:00
e43a9fbf1e Merge pull request #497 from urfave/error-behavior-changelog-mention
Refine error handling behavior
2016-07-24 14:53:24 -04:00
kandayasu
dd7cc7a6d2 Merge branch 'master' into toml-support 2016-07-25 02:47:48 +09:00
Dan Buch
e9688813e4
Refine error handling behavior
so that exit 1 happens as long as error is non-nil
2016-07-24 12:09:05 -04:00
8ae5b3d5e2 Merge pull request #496 from urfave/write-non-nil-error-message-exit-nonzero
Write err to stderr, exit 1 if err != ""
2016-07-24 12:06:30 -04:00