Dan Buch
76bb9f100b
Shift supported go versions
...
and approve word-wrapping changes to godoc
2 years ago
Dan Buch
cbc7f1ad1d
Use goimports as formatting standard
...
given some disagreement with gofmt that seems to have shown up in 1.19
2 years ago
Dan Buch
67b3de0285
Turn off docs publishing from v3 series
2 years ago
Dan Buch
a5313eb2d5
Add missing go.sum entries for go 1.16.x
2 years ago
Dan Buch
d8de3b5483
Tidy up top-level go.mod
2 years ago
Dan Buch
2ca91434a8
Move genflags tool to cmd/ and pin to previous release
...
to alleviate problems caused by the circular dependency of using the
same code as a library that is potentially being generated to adhere to
a different API.
2 years ago
Naveen Gogineni
45a1375078
Changes from code review
2 years ago
Naveen Gogineni
bc99b5865c
issue_62: Make slice options more posix like
2 years ago
Dokiy
02eb392916
Fix After not run
2 years ago
Dokiy
67f592aadb
Fix HideHelp
2 years ago
miyado
dd9cd61bef
Fix for TimestampFlag.GetValue to return empty string without value
2 years ago
Felix Lange
72cbb3db6a
Call FlagStringer in String() method of slice flags
...
The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.
FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.
To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.
Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
2 years ago
Dan Buch
40d886b0e6
Add stub for v3 docs + point gfmrun there instead
2 years ago
Dan Buch
507530d5f7
Merge branch 'main' into generate-in-ci
2 years ago
Dan Buch
d4a5c397f4
Accept current godoc for v2
2 years ago
Dan Buch
cb040b67a0
Only run generate on go 1.19
2 years ago
Dan Buch
6491ddec12
Merge pull request #1503 from urfave/rm-nonexistent-phonies
...
Remove nonexistent phony targets
2 years ago
Dan Buch
38abd8db41
Ensure "generate" step runs in CI prior to diff check
2 years ago
Dan Buch
ac4e5143d2
Remove nonexistent phony targets
...
so that running `make` or `make all` only runs targets that exist.
2 years ago
Dan Buch
22ff9a34c9
Soft revert go.mod version bump
2 years ago
dearchap
de83493182
Merge pull request #1499 from dearchap/issue_557
...
Fix help results inconsistency
2 years ago
dearchap
a81e201383
Merge pull request #1337 from xwjdsh/feat/flag-action
...
Flag-level Action
2 years ago
Naveen Gogineni
d6395333f1
Remove un-needed func
2 years ago
Naveen Gogineni
aecd7c159a
Remove un-needed func
2 years ago
Naveen Gogineni
4c9651575c
Approval for public API change
2 years ago
Naveen Gogineni
e925d26b97
Fix:(issue_557) Make help output consistent between different invocations
2 years ago
Naveen Gogineni
0ee87b411a
Fix:(issue_557) Change app help name
2 years ago
dearchap
9f465af482
Merge pull request #1497 from Torwang1/main
...
fix: Context.Set no such flag
2 years ago
torwang
3005438a1f
fix: Context.Set no such flag
2 years ago
Wendell Sun
47f6782a90
Add more test cases
2 years ago
Wendell Sun
7570aace82
make v2approve
2 years ago
Wendell Sun
b33117618a
Rebase main, update flag-spec.yaml to add Action field
2 years ago
Wendell Sun
602471bf21
Add more tests about flag-level action
2 years ago
Wendell Sun
619958c3d2
Add ActionableFlag interface instead of modifying Flag interface directly
2 years ago
Wendell Sun
14366f7030
feat: flag action
2 years ago
dearchap
880a802dc8
Merge pull request #1495 from dearchap/issue_1197
...
Fix:(issue_1197) Set destination field from altsrc for slice flags
2 years ago
Naveen Gogineni
c8dc60b5e6
Add unit tests
2 years ago
Naveen Gogineni
9e51113ba4
Fix:(issue_1197) Set destination field from altsrc for slice flags
2 years ago
Dan Buch
9120e06825
Merge pull request #1493 from urfave/fix-mkdocs-remote
...
Accept the `MKDOCS_REMOTE_GITHUB_TOKEN` var as intended
2 years ago
Dan Buch
93a3190684
Bump declared module and internal usage to `/v3/`
2 years ago
Dan Buch
9eea32aacd
Accept the `MKDOCS_REMOTE_GITHUB_TOKEN` var as intended
2 years ago
Dan Buch
69f4122db9
Merge pull request #1490 from urfave/maint-build-cleanups
...
Move more functionality into internal/build/build.go
2 years ago
Dan Buch
a425337371
Use correct env var for global flags
2 years ago
Dan Buch
7d9264aea1
Replace a few more custom make targets
2 years ago
Dan Buch
1a851c7ac9
Only run `make v2diff` on go `1.19.x` + `ubuntu-latest`
2 years ago
Dan Buch
da7efeb63b
Use windows compatible path append
2 years ago
Dan Buch
ff1138c969
Run make target after the Makefile is available
2 years ago
Dan Buch
12a3c62e50
Move more functionality into internal/build/build.go
...
and use make targets in CI, pass flag spec YAML through yq
includes result of running `make v2approve`
2 years ago
dearchap
375e5dfc1d
Merge pull request #1489 from dearchap/fix_help_name_consistency
...
Fix: Help name consistency among app/commands and subcommands
2 years ago
Naveen Gogineni
8339b59554
Fix: Help name consistency among app/commands and subcommands
2 years ago