linter fixes

code cleanup
changing some test code to ensure uniformity

help.go

@@ -94,7 +94,7 @@ var helpCommand = Command{
 			return ShowCommandHelp(c, args.First())
 		}
 
-		ShowAppHelp(c)
+		_ = ShowAppHelp(c)
 		return nil
 	},
 }
@@ -134,7 +134,7 @@ var VersionPrinter = printVersion
 
 // ShowAppHelpAndExit - Prints the list of subcommands for the app and exits with exit code.
 func ShowAppHelpAndExit(c *Context, exitCode int) {
-	ShowAppHelp(c)
+	_ = ShowAppHelp(c)
 	os.Exit(exitCode)
 }
 
@@ -168,11 +168,11 @@ func printCommandSuggestions(commands []Command, writer io.Writer) {
 		}
 		if os.Getenv("_CLI_ZSH_AUTOCOMPLETE_HACK") == "1" {
 			for _, name := range command.Names() {
-				fmt.Fprintf(writer, "%s:%s\n", name, command.Usage)
+				_, _ = fmt.Fprintf(writer, "%s:%s\n", name, command.Usage)
 			}
 		} else {
 			for _, name := range command.Names() {
-				fmt.Fprintf(writer, "%s\n", name)
+				_, _ = fmt.Fprintf(writer, "%s\n", name)
 			}
 		}
 	}
@@ -217,7 +217,7 @@ func printFlagSuggestions(lastArg string, flags []Flag, writer io.Writer) {
 			// match if last argument matches this flag and it is not repeated
 			if strings.HasPrefix(name, cur) && cur != name && !cliArgContains(flag.GetName()) {
 				flagCompletion := fmt.Sprintf("%s%s", strings.Repeat("-", count), name)
-				fmt.Fprintln(writer, flagCompletion)
+				_, _ = fmt.Fprintln(writer, flagCompletion)
 			}
 		}
 	}
@@ -245,7 +245,7 @@ func DefaultCompleteWithFlags(cmd *Command) func(c *Context) {
 
 // ShowCommandHelpAndExit - exits with code after showing help
 func ShowCommandHelpAndExit(c *Context, command string, code int) {
-	ShowCommandHelp(c, command)
+	_ = ShowCommandHelp(c, command)
 	os.Exit(code)
 }
 
@@ -287,7 +287,7 @@ func ShowVersion(c *Context) {
 }
 
 func printVersion(c *Context) {
-	fmt.Fprintf(c.App.Writer, "%v version %v\n", c.App.Name, c.App.Version)
+	_, _ = fmt.Fprintf(c.App.Writer, "%v version %v\n", c.App.Name, c.App.Version)
 }
 
 // ShowCompletions prints the lists of commands within a given context
@@ -326,11 +326,11 @@ func printHelpCustom(out io.Writer, templ string, data interface{}, customFunc m
 		// If the writer is closed, t.Execute will fail, and there's nothing
 		// we can do to recover.
 		if os.Getenv("CLI_TEMPLATE_ERROR_DEBUG") != "" {
-			fmt.Fprintf(ErrWriter, "CLI TEMPLATE ERROR: %#v\n", err)
+			_, _ = fmt.Fprintf(ErrWriter, "CLI TEMPLATE ERROR: %#v\n", err)
 		}
 		return
 	}
-	w.Flush()
+	_ = w.Flush()
 }
 
 func printHelp(out io.Writer, templ string, data interface{}) {
@@ -363,7 +363,7 @@ func checkHelp(c *Context) bool {
 
 func checkCommandHelp(c *Context, name string) bool {
 	if c.Bool("h") || c.Bool("help") {
-		ShowCommandHelp(c, name)
+		_ = ShowCommandHelp(c, name)
 		return true
 	}
 
@@ -372,7 +372,7 @@ func checkCommandHelp(c *Context, name string) bool {
 
 func checkSubcommandHelp(c *Context) bool {
 	if c.Bool("h") || c.Bool("help") {
-		ShowSubcommandHelp(c)
+		_ = ShowSubcommandHelp(c)
 		return true
 	}