From 7c756af2b40ecdd2e547dd656c7e5a55b1ea097b Mon Sep 17 00:00:00 2001 From: Benjamin Kane Date: Fri, 27 Nov 2020 21:30:44 -0800 Subject: [PATCH 1/3] Add link to pkg.go.dev docs --- docs/v2/manual.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/v2/manual.md b/docs/v2/manual.md index e99afc1..94febaf 100644 --- a/docs/v2/manual.md +++ b/docs/v2/manual.md @@ -45,7 +45,7 @@ cli v2 manual There are a small set of breaking changes between v1 and v2. Converting is relatively straightforward and typically takes less than an hour. Specific steps are included in -[Migration Guide: v1 to v2](../migrate-v1-to-v2.md). +[Migration Guide: v1 to v2](../migrate-v1-to-v2.md). Also see the [pkg.go.dev docs](https://pkg.go.dev/github.com/urfave/cli/v2) for v2 API documentation. ## Getting Started From d5643c884a0c70a2b995f757aa28e31693615d5d Mon Sep 17 00:00:00 2001 From: Joe Gregorio Date: Sun, 6 Dec 2020 10:00:13 -0500 Subject: [PATCH 2/3] Fix workflows/cli.yml. The ::set-env and ::add-path commands no longer work and need to to be replaced. See: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ --- .github/workflows/cli.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 9fa056e..06dbb80 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -11,7 +11,6 @@ on: - v1 jobs: - test: strategy: matrix: @@ -27,10 +26,10 @@ jobs: - name: Set GOPATH, PATH and ENV run: | - echo "::set-env name=GOPATH::$(dirname $GITHUB_WORKSPACE)" - echo "::set-env name=GO111MODULE::on" - echo "::set-env name=GOPROXY::https://proxy.golang.org" - echo "::add-path::$(dirname $GITHUB_WORKSPACE)/bin" + echo "GOPATH=$(dirname $GITHUB_WORKSPACE)" >> $GITHUB_ENV + echo "GO111MODULE=on" >> $GITHUB_ENV + echo "GOPROXY=https://proxy.golang.org" >> $GITHUB_ENV + echo "$(dirname $GITHUB_WORKSPACE)/bin" >> $GITHUB_PATH shell: bash - name: Checkout Code @@ -74,10 +73,10 @@ jobs: - name: Set GOPATH, PATH and ENV run: | - echo "::set-env name=GOPATH::$(dirname $GITHUB_WORKSPACE)" - echo "::set-env name=GO111MODULE::on" - echo "::set-env name=GOPROXY::https://proxy.golang.org" - echo "::add-path::$(dirname $GITHUB_WORKSPACE)/bin" + echo "GOPATH=$(dirname $GITHUB_WORKSPACE)" >> $GITHUB_ENV + echo "GO111MODULE=on" >> $GITHUB_ENV + echo "GOPROXY=https://proxy.golang.org" >> $GITHUB_ENV + echo "$(dirname $GITHUB_WORKSPACE)/bin" >> $GITHUB_PATH shell: bash - name: Checkout Code From 57d60cd57026a7f5a90b32f854a4b3674ca1b2ae Mon Sep 17 00:00:00 2001 From: Wlad Gumenyuk <50965068+wgumenyuk@users.noreply.github.com> Date: Sun, 27 Dec 2020 18:30:11 +0100 Subject: [PATCH 3/3] Fix: typo Corrected "eror" to "error" on line 331. --- app.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.go b/app.go index 779733e..2c97251 100644 --- a/app.go +++ b/app.go @@ -328,7 +328,7 @@ func (a *App) RunContext(ctx context.Context, arguments []string) (err error) { // RunAndExitOnError calls .Run() and exits non-zero if an error was returned // // Deprecated: instead you should return an error that fulfills cli.ExitCoder -// to cli.App.Run. This will cause the application to exit with the given eror +// to cli.App.Run. This will cause the application to exit with the given error // code in the cli.ExitCoder func (a *App) RunAndExitOnError() { if err := a.Run(os.Args); err != nil {