Backing out build tag for suggestions per recommendation

from @kolyshkin 🙇

.github/workflows/cli.yml

@@ -37,15 +37,9 @@ jobs:
       - name: vet
         run: go run internal/build/build.go vet
 
-      - name: test with urfave_cli_core tag
-        run: go run internal/build/build.go -tags urfave_cli_core test
-
       - name: test with urfave_cli_no_docs tag
         run: go run internal/build/build.go -tags urfave_cli_no_docs test
 
-      - name: test with urfave_cli_no_suggest tag
-        run: go run internal/build/build.go -tags urfave_cli_no_suggest test
-
       - name: test
         run: go run internal/build/build.go test
 
@@ -53,7 +47,7 @@ jobs:
         run: go run internal/build/build.go check-binary-size
 
       - name: check-binary-size with tags (informational only)
-        run: go run internal/build/build.go -tags urfave_cli_core check-binary-size
+        run: go run internal/build/build.go -tags urfave_cli_no_docs check-binary-size
 
       - name: Upload coverage to Codecov
         if: success() && matrix.go == '1.18.x' && matrix.os == 'ubuntu-latest'

Makefile

@@ -17,11 +17,11 @@ all: generate vet tag-test test check-binary-size tag-check-binary-size gfmrun t
 
 .PHONY: tag-test
 tag-test:
-	go run internal/build/build.go -tags urfave_cli_core test
+	go run internal/build/build.go -tags urfave_cli_no_docs test
 
 .PHONY: tag-check-binary-size
 tag-check-binary-size:
-	go run internal/build/build.go -tags urfave_cli_core check-binary-size
+	go run internal/build/build.go -tags urfave_cli_no_docs check-binary-size
 
 .PHONY: gfmrun
 gfmrun:

README.md

@@ -59,22 +59,12 @@ import (
 
 You can use the following build tags:
 
-#### `urfave_cli_core`
-
-When set, applies all `urfave_cli_no.+` build tags to minimize resulting binary
-size.
-
 #### `urfave_cli_no_docs`
 
 When set, this removes `ToMarkdown` and `ToMan` methods, so your application
 won't be able to call those. This reduces the resulting binary size by about
 300-400 KB (measured using Go 1.18.1 on Linux/amd64), due to fewer dependencies.
 
-#### `urfave_cli_no_suggest`
-
-When set, the capability enabled by setting `App.Suggest` will be a no-op. This
-reduces the resulting binary size due to fewer dependencies.
-
 ### GOPATH
 
 Make sure your `PATH` includes the `$GOPATH/bin` directory so your commands can

docs.go

@@ -1,5 +1,5 @@
-//go:build !urfave_cli_no_docs && !urfave_cli_core
+//go:build !urfave_cli_no_docs
-// +build !urfave_cli_no_docs,!urfave_cli_core
+// +build !urfave_cli_no_docs
 
 package cli
 

docs_test.go

@@ -1,5 +1,5 @@
-//go:build !urfave_cli_no_docs && !urfave_cli_core
+//go:build !urfave_cli_no_docs
-// +build !urfave_cli_no_docs,!urfave_cli_core
+// +build !urfave_cli_no_docs
 
 package cli
 

internal/build/build.go

@@ -242,7 +242,7 @@ func checkBinarySizeActionFunc(c *cli.Context) (err error) {
 
 	tags := c.String("tags")
 
-	if strings.Contains(tags, "urfave_cli_core") || strings.Contains(tags, "urfave_cli_no_docs") {
+	if strings.Contains(tags, "urfave_cli_no_docs") {
 		desiredMinBinarySize = 1.39
 	}
 

suggestions.go

@@ -1,6 +1,3 @@
-//go:build !urfave_cli_no_suggest && !urfave_cli_core
-// +build !urfave_cli_no_suggest,!urfave_cli_core
-
 package cli
 
 import (

suggestions_stubs.go

@@ -1,12 +0,0 @@
-//go:build urfave_cli_no_suggest || urfave_cli_core
-// +build urfave_cli_no_suggest urfave_cli_core
-
-package cli
-
-func (a *App) suggestFlagFromError(err error, _ string) (string, error) {
-	return "", err
-}
-
-func suggestCommand([]*Command, string) string {
-	return ""
-}

suggestions_test.go

@@ -1,6 +1,3 @@
-//go:build !urfave_cli_no_suggest && !urfave_cli_core
-// +build !urfave_cli_no_suggest,!urfave_cli_core
-
 package cli
 
 import (