From 2a5a092888029d130b40e2849aab312543df91cb Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Sat, 31 Oct 2020 00:08:57 +0530 Subject: [PATCH 1/2] Add Support for Go 1.15 And also drop support for Go 1.12 in line with Go's Release Policy https://golang.org/doc/devel/release.html#policy --- .github/workflows/cli.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index d79a314..9fa056e 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -16,7 +16,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macos-latest, windows-latest] - go: [1.12, 1.13, 1.14] + go: [1.13, 1.14, 1.15] name: ${{ matrix.os }} @ Go ${{ matrix.go }} runs-on: ${{ matrix.os }} steps: @@ -39,7 +39,7 @@ jobs: ref: ${{ github.ref }} - name: GOFMT Check - if: matrix.go == 1.14 && matrix.os == 'ubuntu-latest' + if: matrix.go == 1.15 && matrix.os == 'ubuntu-latest' run: test -z $(gofmt -l .) - name: vet @@ -62,10 +62,10 @@ jobs: name: test-docs runs-on: ubuntu-latest steps: - - name: Set up Go 1.14 + - name: Set up Go 1.15 uses: actions/setup-go@v1 with: - go-version: 1.14 + go-version: 1.15 - name: Use Node.js 12.x uses: actions/setup-node@v1 From 06e570991ca9a60e3d959d8865b6605ce1de99d7 Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Sat, 31 Oct 2020 00:14:08 +0530 Subject: [PATCH 2/2] Reduce desiredMinBinarySize Updating the Go version has also optimized the binary size, so the desiredMinBinarySize is being updated to be 1.9 --- internal/build/build.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/build/build.go b/internal/build/build.go index 197cfa5..d0be855 100644 --- a/internal/build/build.go +++ b/internal/build/build.go @@ -193,7 +193,7 @@ func checkBinarySizeActionFunc(c *cli.Context) (err error) { cliBuiltFilePath = "./internal/example-cli/built-example" helloSourceFilePath = "./internal/example-hello-world/example-hello-world.go" helloBuiltFilePath = "./internal/example-hello-world/built-example" - desiredMinBinarySize = 2.0 + desiredMinBinarySize = 1.9 desiredMaxBinarySize = 2.1 badNewsEmoji = "🚨" goodNewsEmoji = "✨"