x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #497 from urfave/error-behavior-changelog-mention

Browse Source 
Refine error handling behavior
This commit is contained in:
Dan Buch 2016-07-24 14:53:24 -04:00 committed by GitHub
commit e43a9fbf1e
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -5,6 +5,7 @@
## [Unreleased] ## [Unreleased]
### Added ### Added
- Flag type code generation via `go generate` - Flag type code generation via `go generate`
- Write to stderr and exit 1 if action returns non-nil error
### Changed ### Changed
- Raise minimum tested/supported Go version to 1.2+ - Raise minimum tested/supported Go version to 1.2+

2
errors.go
View File

@ -93,6 +93,6 @@ func HandleExitCoder(err error) {
if err.Error() != "" { if err.Error() != "" {
fmt.Fprintln(ErrWriter, err) fmt.Fprintln(ErrWriter, err)
}
OsExiter(1) OsExiter(1)
} }
}

4
errors_test.go
View File

@ -100,7 +100,7 @@ func TestHandleExitCoder_ErrorWithoutMessage(t *testing.T) {
err := errors.New("") err := errors.New("")
HandleExitCoder(err) HandleExitCoder(err)
expect(t, exitCode, 0) expect(t, exitCode, 1)
expect(t, called, false) expect(t, called, true)
expect(t, ErrWriter.(*bytes.Buffer).String(), "") expect(t, ErrWriter.(*bytes.Buffer).String(), "")
} }