x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cleanup tests

Browse Source
This commit is contained in:
[[ BOT ]] Lynn Cyrin 2019-08-22 21:22:37 -07:00
parent 4381738fb5
commit e265f5087f
No known key found for this signature in database
GPG Key ID: 4E7214CB460A2400
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app_test.go
View File

@ -1190,12 +1190,11 @@ func TestRequiredFlagAppRunBehavior(t *testing.T) {
func TestAppRunPassThroughRegression(t *testing.T) { func TestAppRunPassThroughRegression(t *testing.T) {
tdata := []struct { tdata := []struct {
testCase string testCase string
appFlags []Flag
appRunInput []string appRunInput []string
appCommands []Command appCommands []Command
expectedAnError bool
}{ }{
{ // docker run --rm ubuntu bash {
testCase: "test_case",
appRunInput: []string{"myCLI", "myCommand", "--someFlag", "someInput", "docker", "run", "--rm", "ubuntu", "bash"}, appRunInput: []string{"myCLI", "myCommand", "--someFlag", "someInput", "docker", "run", "--rm", "ubuntu", "bash"},
appCommands: []Command{{ appCommands: []Command{{
Name: "myCommand", Name: "myCommand",
@ -1207,17 +1206,13 @@ func TestAppRunPassThroughRegression(t *testing.T) {
t.Run(test.testCase, func(t *testing.T) { t.Run(test.testCase, func(t *testing.T) {
// setup // setup
app := NewApp() app := NewApp()
app.Flags = test.appFlags
app.Commands = test.appCommands app.Commands = test.appCommands
// logic under test // logic under test
err := app.Run(test.appRunInput) err := app.Run(test.appRunInput)
// assertions // assertions
if test.expectedAnError && err == nil { if err != nil {
t.Errorf("expected an error, but there was none")
}
if !test.expectedAnError && err != nil {
t.Errorf("did not expected an error, but there was one: %s", err) t.Errorf("did not expected an error, but there was one: %s", err)
} }
}) })