x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #438 from urfave/show-bool-default

Browse Source 
Show BoolFlag default value in help usage
This commit is contained in:
Jesse Szwedko 2016-05-28 12:03:46 -07:00
commit dddab48818
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
flag.go
View File

@ -670,8 +670,8 @@ func stringifyFlag(f Flag) string {
defaultValueString := "" defaultValueString := ""
val := fv.FieldByName("Value") val := fv.FieldByName("Value")
if val.IsValid() && val.Kind() != reflect.Bool { if val.IsValid() {
needsPlaceholder = true needsPlaceholder = val.Kind() != reflect.Bool
defaultValueString = fmt.Sprintf(" (default: %v)", val.Interface()) defaultValueString = fmt.Sprintf(" (default: %v)", val.Interface())
if val.Kind() == reflect.String && val.String() != "" { if val.Kind() == reflect.String && val.String() != "" {

4
flag_test.go
View File

@ -15,8 +15,8 @@ var boolFlagTests = []struct {
name string name string
expected string expected string
}{ }{
{"help", "--help\t"}, {"help", "--help\t(default: false)"},
{"h", "-h\t"}, {"h", "-h\t(default: false)"},
} }
func TestBoolFlagHelpOutput(t *testing.T) { func TestBoolFlagHelpOutput(t *testing.T) {