Attempt to better handle python(2|3) tempfile differences

This commit is contained in:
Dan Buch
2017-08-12 22:20:50 -04:00
parent 1505b9f046
commit d83210ca77
2 changed files with 17 additions and 6 deletions

View File

@@ -13,6 +13,7 @@ import tempfile
from subprocess import check_call, check_output
_PY3 = sys.version_info.major == 3
_WINDOWS = platform.system().lower() == 'windows'
_PACKAGE_NAME = os.environ.get(
'CLI_PACKAGE_NAME', 'github.com/urfave/cli'
@@ -148,9 +149,11 @@ def _go_version():
def _combine_coverprofiles(coverprofiles):
combined = tempfile.NamedTemporaryFile(
suffix='.coverprofile', delete=False
)
tmp_args = dict(suffix='.coverprofile', delete=False)
if _PY3:
tmp_args['encoding'] = 'utf-8'
combined = tempfile.NamedTemporaryFile(**tmp_args)
combined.write(b'mode: set\n')
for coverprofile in coverprofiles: