x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #109 from modcloth/go-vetting

Browse Source 
Go vetting
This commit is contained in:
Jeremy Saenz 2014-07-11 15:57:55 -07:00
commit d38a3b82a6
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@ -137,7 +137,7 @@ Setting and querying flags is simple.
``` go ``` go
... ...
app.Flags = []cli.Flag { app.Flags = []cli.Flag {
cli.StringFlag{"lang", "english", "language for the greeting"}, cli.StringFlag{Name: "lang", Value: "english", Usage: "language for the greeting"},
} }
app.Action = func(c *cli.Context) { app.Action = func(c *cli.Context) {
name := "someone" name := "someone"
@ -159,7 +159,7 @@ You can set alternate (or short) names for flags by providing a comma-delimited
``` go ``` go
app.Flags = []cli.Flag { app.Flags = []cli.Flag {
cli.StringFlag{"lang, l", "english", "language for the greeting"}, cli.StringFlag{Name: "lang, l", Value: "english", Usage: "language for the greeting"},
} }
``` ```

6
app_test.go
View File

@ -43,7 +43,7 @@ func ExampleAppSubcommand() {
Usage: "sends a greeting in english", Usage: "sends a greeting in english",
Description: "greets someone in english", Description: "greets someone in english",
Flags: []cli.Flag{ Flags: []cli.Flag{
cli.StringFlag{"name", "Bob", "Name of the person to greet"}, cli.StringFlag{Name: "name", Value: "Bob", Usage: "Name of the person to greet"},
}, },
Action: func(c *cli.Context) { Action: func(c *cli.Context) {
fmt.Println("Hello,", c.String("name")) fmt.Println("Hello,", c.String("name"))
@ -255,11 +255,11 @@ func TestApp_ParseSliceFlags(t *testing.T) {
var expectedStringSlice = []string{"8.8.8.8", "8.8.4.4"} var expectedStringSlice = []string{"8.8.8.8", "8.8.4.4"}
if !IntsEquals(parsedIntSlice, expectedIntSlice) { if !IntsEquals(parsedIntSlice, expectedIntSlice) {
t.Errorf("%s does not match %s", parsedIntSlice, expectedIntSlice) t.Errorf("%v does not match %v", parsedIntSlice, expectedIntSlice)
} }
if !StrsEquals(parsedStringSlice, expectedStringSlice) { if !StrsEquals(parsedStringSlice, expectedStringSlice) {
t.Errorf("%s does not match %s", parsedStringSlice, expectedStringSlice) t.Errorf("%v does not match %v", parsedStringSlice, expectedStringSlice)
} }
} }

9
cli_test.go
View File

@ -1,8 +1,9 @@
package cli_test package cli_test
import ( import (
"github.com/codegangsta/cli"
"os" "os"
"github.com/codegangsta/cli"
) )
func Example() { func Example() {
@ -47,7 +48,7 @@ func ExampleSubcommand() {
Usage: "sends a greeting in english", Usage: "sends a greeting in english",
Description: "greets someone in english", Description: "greets someone in english",
Flags: []cli.Flag{ Flags: []cli.Flag{
cli.StringFlag{"name", "Bob", "Name of the person to greet"}, cli.StringFlag{Name: "name", Value: "Bob", Usage: "Name of the person to greet"},
}, },
Action: func(c *cli.Context) { Action: func(c *cli.Context) {
println("Hello, ", c.String("name")) println("Hello, ", c.String("name"))
@ -57,7 +58,7 @@ func ExampleSubcommand() {
ShortName: "sp", ShortName: "sp",
Usage: "sends a greeting in spanish", Usage: "sends a greeting in spanish",
Flags: []cli.Flag{ Flags: []cli.Flag{
cli.StringFlag{"surname", "Jones", "Surname of the person to greet"}, cli.StringFlag{Name: "surname", Value: "Jones", Usage: "Surname of the person to greet"},
}, },
Action: func(c *cli.Context) { Action: func(c *cli.Context) {
println("Hola, ", c.String("surname")) println("Hola, ", c.String("surname"))
@ -67,7 +68,7 @@ func ExampleSubcommand() {
ShortName: "fr", ShortName: "fr",
Usage: "sends a greeting in french", Usage: "sends a greeting in french",
Flags: []cli.Flag{ Flags: []cli.Flag{
cli.StringFlag{"nickname", "Stevie", "Nickname of the person to greet"}, cli.StringFlag{Name: "nickname", Value: "Stevie", Usage: "Nickname of the person to greet"},
}, },
Action: func(c *cli.Context) { Action: func(c *cli.Context) {
println("Bonjour, ", c.String("nickname")) println("Bonjour, ", c.String("nickname"))