Use goimports as formatting standard

given some disagreement with gofmt that seems to have shown up in 1.19
This commit is contained in:
Dan Buch 2022-08-14 10:47:42 -04:00
parent a5313eb2d5
commit cbc7f1ad1d
Signed by: meatballhat
GPG Key ID: A12F782281063434
2 changed files with 19 additions and 15 deletions

View File

@ -30,12 +30,16 @@ jobs:
- name: Set PATH - name: Set PATH
run: echo "${GITHUB_WORKSPACE}/.local/bin" >>"${GITHUB_PATH}" run: echo "${GITHUB_WORKSPACE}/.local/bin" >>"${GITHUB_PATH}"
- name: install goimports
if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
run: GOBIN=${PWD}/.local/bin go install golang.org/x/tools/cmd/goimports@latest
- name: Checkout Code - name: Checkout Code
uses: actions/checkout@v3 uses: actions/checkout@v3
- name: GOFMT Check - name: goimports check
if: matrix.go == '1.18.x' && matrix.os == 'ubuntu-latest' if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
run: test -z $(gofmt -l .) run: test -z $(goimports -l .)
- name: vet - name: vet
run: go run internal/build/build.go vet run: go run internal/build/build.go vet

24
cli.go
View File

@ -3,23 +3,23 @@
// cli application can be written as follows: // cli application can be written as follows:
// //
// func main() { // func main() {
// (&cli.App{}).Run(os.Args) // (&cli.App{}).Run(os.Args)
// } // }
// //
// Of course this application does not do much, so let's make this an actual application: // Of course this application does not do much, so let's make this an actual application:
// //
// func main() { // func main() {
// app := &cli.App{ // app := &cli.App{
// Name: "greet", // Name: "greet",
// Usage: "say a greeting", // Usage: "say a greeting",
// Action: func(c *cli.Context) error { // Action: func(c *cli.Context) error {
// fmt.Println("Greetings") // fmt.Println("Greetings")
// return nil // return nil
// }, // },
// } // }
// //
// app.Run(os.Args) // app.Run(os.Args)
// } // }
package cli package cli
//go:generate go run cmd/urfave-cli-genflags/main.go //go:generate go run cmd/urfave-cli-genflags/main.go