From c64d74a5d989d144e33854e303f20981f9e8f049 Mon Sep 17 00:00:00 2001 From: Jesse Szwedko Date: Mon, 24 Apr 2017 14:54:35 -0700 Subject: [PATCH] Do not double print errors from Before() They should be handled by HandleExitCoder() as `After()` errors are. --- app.go | 1 - command.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/app.go b/app.go index 26a4d4d..51fc45d 100644 --- a/app.go +++ b/app.go @@ -240,7 +240,6 @@ func (a *App) Run(arguments []string) (err error) { if a.Before != nil { beforeErr := a.Before(context) if beforeErr != nil { - fmt.Fprintf(a.Writer, "%v\n\n", beforeErr) ShowAppHelp(context) HandleExitCoder(beforeErr) err = beforeErr diff --git a/command.go b/command.go index bb0733c..23de294 100644 --- a/command.go +++ b/command.go @@ -197,8 +197,6 @@ func (c Command) Run(ctx *Context) (err error) { if c.Before != nil { err = c.Before(context) if err != nil { - fmt.Fprintln(context.App.Writer, err) - fmt.Fprintln(context.App.Writer) ShowCommandHelp(context, c.Name) HandleExitCoder(err) return err