From 3e145076abdbaf5c6e47e311b5e659251604a49b Mon Sep 17 00:00:00 2001 From: Christopher Waldon Date: Fri, 12 Oct 2018 11:30:46 -0400 Subject: [PATCH 1/5] Clarify that altsrc supports both TOML and JSON --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index f2baef4..e2df4ec 100644 --- a/README.md +++ b/README.md @@ -679,6 +679,7 @@ from other file input sources. Currently supported input source formats: * YAML +* JSON * TOML In order to get values for a flag from an alternate input source the following @@ -701,7 +702,7 @@ the yaml input source for any flags that are defined on that command. As a note the "load" flag used would also have to be defined on the command flags in order for this code snipped to work. -Currently only YAML and JSON files are supported but developers can add support +Currently only YAML, JSON, and TOML files are supported but developers can add support for other input sources by implementing the altsrc.InputSourceContext for their given sources. From e8eac43d9d73e96f6b034f89770ab2fdbec2cb5b Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Fri, 2 Aug 2019 18:26:41 -0700 Subject: [PATCH 2/5] Update CHANGELOG.md --- CHANGELOG.md | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 401eae5..f7c4de0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,20 @@ ## [Unreleased] +## 1.21.0 - 2019-08-02 + +### Fixed + +* + +### Changed + +* + +### Added + +* + ## 1.20.0 - 2017-08-10 ### Fixed @@ -407,7 +421,10 @@ signature of `func(*cli.Context) error`, as defined by `cli.ActionFunc`. ### Added - Initial implementation. -[Unreleased]: https://github.com/urfave/cli/compare/v1.18.0...HEAD +[Unreleased]: https://github.com/urfave/cli/compare/v1.21.0...HEAD +[1.21.0]: https://github.com/urfave/cli/compare/v1.20.0...v1.21.0 +[1.20.0]: https://github.com/urfave/cli/compare/v1.19.0...v1.20.0 +[1.19.0]: https://github.com/urfave/cli/compare/v1.18.0...v1.19.0 [1.18.0]: https://github.com/urfave/cli/compare/v1.17.0...v1.18.0 [1.17.0]: https://github.com/urfave/cli/compare/v1.16.0...v1.17.0 [1.16.0]: https://github.com/urfave/cli/compare/v1.15.0...v1.16.0 From 8a7f65e05215a76a2246b7b42cb9c082b5eae483 Mon Sep 17 00:00:00 2001 From: "Lynn Cyrin (they/them)" Date: Fri, 2 Aug 2019 19:30:41 -0700 Subject: [PATCH 3/5] Update CHANGELOG.md --- CHANGELOG.md | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f7c4de0..1e49d54 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,21 +4,28 @@ ## [Unreleased] -## 1.21.0 - 2019-08-02 +## [1.21.0] - 2019-08-02 ### Fixed -* +* Fix using "slice" flag types with `EnvVar` in [urfave/cli/pull/687](https://github.com/urfave/cli/pull/687) via [@joshuarubin](https://github.com/joshuarubin) +* Fix regression of `SkipFlagParsing` behavior in [urfave/cli/pull/697](https://github.com/urfave/cli/pull/697) via [@jszwedko](https://github.com/jszwedko) +* Fix handling `ShortOptions` and `SkipArgReorder` in [urfave/cli/pull/686](https://github.com/urfave/cli/pull/686) via [@baude](https://github.com/baude) +* Fix args reordering when bool flags are present in [urfave/cli/pull/712](https://github.com/urfave/cli/pull/712) via [@windler](https://github.com/windler) +* Fix parsing of short options in [urfave/cli/pull/758](https://github.com/urfave/cli/pull/758) via [@vrothberg](https://github.com/vrothberg) -### Changed - -* - -### Added +### Added / Changed -* +* Added _"required flags"_ support in [urfave/cli/pull/819](https://github.com/urfave/cli/pull/819) via [@lynncyrin](https://github.com/lynncyrin/) +* Cleaned up help output in [urfave/cli/pull/664](https://github.com/urfave/cli/pull/664) via [@maguro](https://github.com/maguro) +* Case is now considered when sorting strings in [urfave/cli/pull/676](https://github.com/urfave/cli/pull/676) via [@rliebz](https://github.com/rliebz) +* Backport JSON `InputSource` to v1 in [urfave/cli/pull/598](https://github.com/urfave/cli/pull/598) via [@jszwedko](https://github.com/jszwedko) +* Allow more customization of flag help strings in [urfave/cli/pull/661](https://github.com/urfave/cli/pull/661) via [@rliebz](https://github.com/rliebz) +* Allow custom `ExitError` handler function in [urfave/cli/pull/628](https://github.com/urfave/cli/pull/628) via [@phinnaeus](https://github.com/phinnaeus) +* Allow loading a variable from a file in [urfave/cli/pull/675](https://github.com/urfave/cli/pull/675) via [@jmccann](https://github.com/jmccann) +* Allow combining short bool names in [urfave/cli/pull/684](https://github.com/urfave/cli/pull/684) via [@baude](https://github.com/baude) -## 1.20.0 - 2017-08-10 +## [1.20.0] - 2017-08-10 ### Fixed @@ -423,7 +430,8 @@ signature of `func(*cli.Context) error`, as defined by `cli.ActionFunc`. [Unreleased]: https://github.com/urfave/cli/compare/v1.21.0...HEAD [1.21.0]: https://github.com/urfave/cli/compare/v1.20.0...v1.21.0 -[1.20.0]: https://github.com/urfave/cli/compare/v1.19.0...v1.20.0 +[1.20.0]: https://github.com/urfave/cli/compare/v1.19.1...v1.20.0 +[1.19.1]: https://github.com/urfave/cli/compare/v1.19.0...v1.19.1 [1.19.0]: https://github.com/urfave/cli/compare/v1.18.0...v1.19.0 [1.18.0]: https://github.com/urfave/cli/compare/v1.17.0...v1.18.0 [1.17.0]: https://github.com/urfave/cli/compare/v1.16.0...v1.17.0 From 97dbddb32db290fdc6392e6a669a92acbadef9ff Mon Sep 17 00:00:00 2001 From: "[[ BOT ]] Lynn Cyrin" Date: Sat, 3 Aug 2019 10:23:29 -0700 Subject: [PATCH 4/5] use codeowners instead of maintainers --- .github/CODEOWNERS | 4 ++++ MAINTAINERS.md | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 .github/CODEOWNERS delete mode 100644 MAINTAINERS.md diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..4f138e8 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,4 @@ +# See https://help.github.com/articles/about-codeowners/ +# for more info about CODEOWNERS file + +* @urfave/cli diff --git a/MAINTAINERS.md b/MAINTAINERS.md deleted file mode 100644 index 5b7a6ea..0000000 --- a/MAINTAINERS.md +++ /dev/null @@ -1,4 +0,0 @@ -- @meatballhat -- @lynncyrin -- @AudriusButkevicius -- @asahasrabuddhe From 9938dec695d6a0ba5a4d84b703766333cd7d10e8 Mon Sep 17 00:00:00 2001 From: "[[ BOT ]] Lynn Cyrin" Date: Sat, 3 Aug 2019 10:26:07 -0700 Subject: [PATCH 5/5] update contributing docs --- CONTRIBUTING.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 329195e..9a4640a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,11 +1,10 @@ ## Contributing -**NOTE**: the primary maintainer(s) may be found in -[./MAINTAINERS.md](./MAINTAINERS.md). +Use @urfave/cli to ping the maintainers. -Feel free to put up a pull request to fix a bug or maybe add a feature. I will +Feel free to put up a pull request to fix a bug or maybe add a feature. We will give it a code review and make sure that it does not break backwards -compatibility. If I or any other collaborators agree that it is in line with +compatibility. If collaborators agree that it is in line with the vision of the project, we will work with you to get the code into a mergeable state and merge it into the master branch. @@ -15,5 +14,5 @@ to merge others pull requests. It is very important that new code does not break existing code, so be careful about what code you do choose to merge. If you feel like you have contributed to the project but have not yet been added -as a collaborator, we probably forgot to add you :sweat_smile:. Please open an +as a collaborator, we probably forgot to add you :sweat_smile:. Please open an issue!