From ab81cf7eac462a00aabbdaf2e78857d04f5d1eb1 Mon Sep 17 00:00:00 2001 From: j0n3lson <620536+j0n3lson@users.noreply.github.com> Date: Thu, 9 Jan 2020 17:11:23 -0800 Subject: [PATCH 1/3] Use a more k8s/release friendly PR template. --- .github/pull_request_template.md | 56 +++++++++++++++++++------------- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8e80f9c..ef36d27 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,38 +4,57 @@ If a section of the PR template does not apply to this PR, then delete that section. --> -## Motivation +## What type of PR is this? -_(fill-in or delete this section)_ +_(REQUIRED)_ + + + +## What this PR does / why we need it: + +_(REQUIRED)_ + +## Which issue(s) this PR fixes: + +_(REQUIRED)_ + -## Release Notes +## Special notes for your reviewer: _(fill-in or delete this section)_ -## Changes +## Release Notes -_(fill-in or delete this section)_ +_(REQUIRED)_ ## Testing @@ -44,13 +63,4 @@ _(fill-in or delete this section)_ - -## Reviewer Guidelines - -_(fill-in or delete this section)_ - - +--> \ No newline at end of file From dadc675f58cc29ca77bda8148ee7f4d9cd4e581a Mon Sep 17 00:00:00 2001 From: "lynn [they]" Date: Thu, 9 Jan 2020 17:48:35 -0800 Subject: [PATCH 2/3] Update stale.yml --- .github/stale.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/stale.yml b/.github/stale.yml index 563a9b5..a3282a2 100644 --- a/.github/stale.yml +++ b/.github/stale.yml @@ -14,7 +14,7 @@ onlyLabels: [] exemptLabels: - pinned - security - - "type: maintenance" + - "kind/maintenance" # Set to true to ignore issues in a project (defaults to false) exemptProjects: false @@ -26,7 +26,7 @@ exemptMilestones: false exemptAssignees: false # Label to use when marking as stale -staleLabel: "status: stale" +staleLabel: "status/stale" # Comment to post when marking as stale. Set to `false` to disable markComment: > From 78ba678e4e37ea87e7f8dd8823b8a202a0522041 Mon Sep 17 00:00:00 2001 From: j0n3lson <620536+j0n3lson@users.noreply.github.com> Date: Fri, 10 Jan 2020 01:04:12 -0800 Subject: [PATCH 3/3] Modifications per review --- .github/pull_request_template.md | 39 +++++++++++++++++--------------- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ef36d27..4a30f8f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,12 +8,10 @@ _(REQUIRED)_ - +- [ ] bug +- [ ] cleanup +- [ ] documentation +- [ ] feature ## What this PR does / why we need it: @@ -46,21 +44,26 @@ _(fill-in or delete this section)_ Which parts of the code should reviewers focus on? --> -## Release Notes - -_(REQUIRED)_ - - - ## Testing _(fill-in or delete this section)_ \ No newline at end of file +--> + +## Release Notes + +_(REQUIRED)_ + + +```release-note + +``` \ No newline at end of file