x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: allow required flag with one character (#1449)

Browse Source 
* fix: allow required flag with one character

* fix: update test case
This commit is contained in:
Gerrard-YNWA 2022-08-29 19:25:55 +08:00 committed by GitHub
parent 8b23e7b1e9
commit b98c059269
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
context.go
View File

@ -170,9 +170,7 @@ func (cCtx *Context) checkRequiredFlags(flags []Flag) requiredFlagsErr {
var flagName string var flagName string
for _, key := range f.Names() { for _, key := range f.Names() {
if len(key) > 1 { flagName = key
flagName = key
}
if cCtx.IsSet(strings.TrimSpace(key)) { if cCtx.IsSet(strings.TrimSpace(key)) {
flagPresent = true flagPresent = true

8
context_test.go
View File

@ -556,6 +556,14 @@ func TestCheckRequiredFlags(t *testing.T) {
&StringSliceFlag{Name: "names, n", Required: true}, &StringSliceFlag{Name: "names, n", Required: true},
}, },
}, },
{
testCase: "required_flag_with_one_character",
expectedAnError: true,
expectedErrorContents: []string{"Required flag \"n\" not set"},
flags: []Flag{
&StringFlag{Name: "n", Required: true},
},
},
} }
for _, test := range tdata { for _, test := range tdata {