x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1026 from vkd/refactor-tests-drop-buffer-writer

Browse Source 
Refactor tests - drop mock writer
This commit is contained in:
lynn [they] 2019-12-29 17:08:06 -08:00 committed by GitHub
commit 995ba0a892
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app_test.go
View File

@ -859,30 +859,12 @@ func TestApp_DefaultStdout(t *testing.T) {
} }
} }
type mockWriter struct {
written []byte
}
func (fw *mockWriter) Write(p []byte) (n int, err error) {
if fw.written == nil {
fw.written = p
} else {
fw.written = append(fw.written, p...)
}
return len(p), nil
}
func (fw *mockWriter) GetWritten() (b []byte) {
return fw.written
}
func TestApp_SetStdout(t *testing.T) { func TestApp_SetStdout(t *testing.T) {
w := &mockWriter{} var w bytes.Buffer
app := &App{ app := &App{
Name: "test", Name: "test",
Writer: w, Writer: &w,
} }
err := app.Run([]string{"help"}) err := app.Run([]string{"help"})
@ -891,7 +873,7 @@ func TestApp_SetStdout(t *testing.T) {
t.Fatalf("Run error: %s", err) t.Fatalf("Run error: %s", err)
} }
if len(w.written) == 0 { if w.Len() == 0 {
t.Error("App did not write output to desired writer.") t.Error("App did not write output to desired writer.")
} }
} }