x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

replace log.Print with t.Log

Browse Source
This commit is contained in:
Ajitem Sahasrabuddhe 2019-12-07 12:15:17 +05:30
parent 078d14335a
commit 969535eec6
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app_test.go
View File

@ -7,7 +7,6 @@ import (
"fmt" "fmt"
"io" "io"
"io/ioutil" "io/ioutil"
"log"
"os" "os"
"reflect" "reflect"
"strings" "strings"
@ -1423,7 +1422,7 @@ func TestApp_Run_CommandWithSubcommandHasHelpTopic(t *testing.T) {
} }
for _, flagSet := range subcommandHelpTopics { for _, flagSet := range subcommandHelpTopics {
log.Printf("==> checking with flags %v", flagSet) t.Logf("==> checking with flags %v", flagSet)
app := &App{} app := &App{}
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
@ -1613,7 +1612,7 @@ func TestApp_Run_Help(t *testing.T) {
for _, args := range helpArguments { for _, args := range helpArguments {
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
log.Printf("==> checking with arguments %v", args) t.Logf("==> checking with arguments %v", args)
app := &App{ app := &App{
Name: "boom", Name: "boom",
@ -1631,7 +1630,7 @@ func TestApp_Run_Help(t *testing.T) {
} }
output := buf.String() output := buf.String()
log.Printf("output: %q\n", buf.Bytes()) t.Logf("output: %q\n", buf.Bytes())
if !strings.Contains(output, "boom - make an explosive entrance") { if !strings.Contains(output, "boom - make an explosive entrance") {
t.Errorf("want help to contain %q, did not: \n%q", "boom - make an explosive entrance", output) t.Errorf("want help to contain %q, did not: \n%q", "boom - make an explosive entrance", output)
@ -1645,7 +1644,7 @@ func TestApp_Run_Version(t *testing.T) {
for _, args := range versionArguments { for _, args := range versionArguments {
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
log.Printf("==> checking with arguments %v", args) t.Logf("==> checking with arguments %v", args)
app := &App{ app := &App{
Name: "boom", Name: "boom",
@ -1664,7 +1663,7 @@ func TestApp_Run_Version(t *testing.T) {
} }
output := buf.String() output := buf.String()
log.Printf("output: %q\n", buf.Bytes()) t.Logf("output: %q\n", buf.Bytes())
if !strings.Contains(output, "0.1.0") { if !strings.Contains(output, "0.1.0") {
t.Errorf("want version to contain %q, did not: \n%q", "0.1.0", output) t.Errorf("want version to contain %q, did not: \n%q", "0.1.0", output)
@ -2121,7 +2120,7 @@ func TestWhenExitSubCommandWithCodeThenAppQuitUnexpectedly(t *testing.T) {
var exitCodeFromExitErrHandler int var exitCodeFromExitErrHandler int
app.ExitErrHandler = func(c *Context, err error) { app.ExitErrHandler = func(c *Context, err error) {
if exitErr, ok := err.(ExitCoder); ok { if exitErr, ok := err.(ExitCoder); ok {
log.Print(exitErr) t.Log(exitErr)
exitCodeFromExitErrHandler = exitErr.ExitCode() exitCodeFromExitErrHandler = exitErr.ExitCode()
} }
} }