x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ensure all flag aliases are set when Destination given

Browse Source 
and extend "Incorrect Usage" message to show the error.

Closes #430
This commit is contained in:
Dan Buch
2016-05-23 22:00:59 -04:00
parent 685865d2d9
commit 8f25dbb615
4 changed files with 92 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
flag.go
View File

@@ -104,7 +104,7 @@ func (f GenericFlag) Apply(set *flag.FlagSet) {
}
for _, name := range f.Names() {
set.Var(f.Value, name, f.Usage)
set.Var(val, name, f.Usage)
}
}
@@ -349,7 +349,7 @@ func (f BoolFlag) Apply(set *flag.FlagSet) {
for _, name := range f.Names() {
if f.Destination != nil {
set.BoolVar(f.Destination, name, f.Value, f.Usage)
return
continue
}
set.Bool(name, f.Value, f.Usage)
}
@@ -391,7 +391,7 @@ func (f StringFlag) Apply(set *flag.FlagSet) {
for _, name := range f.Names() {
if f.Destination != nil {
set.StringVar(f.Destination, name, f.Value, f.Usage)
return
continue
}
set.String(name, f.Value, f.Usage)
}
@@ -437,7 +437,7 @@ func (f IntFlag) Apply(set *flag.FlagSet) {
for _, name := range f.Names() {
if f.Destination != nil {
set.IntVar(f.Destination, name, f.Value, f.Usage)
return
continue
}
set.Int(name, f.Value, f.Usage)
}
@@ -483,7 +483,7 @@ func (f DurationFlag) Apply(set *flag.FlagSet) {
for _, name := range f.Names() {
if f.Destination != nil {
set.DurationVar(f.Destination, name, f.Value, f.Usage)
return
continue
}
set.Duration(name, f.Value, f.Usage)
}
@@ -528,7 +528,7 @@ func (f Float64Flag) Apply(set *flag.FlagSet) {
for _, name := range f.Names() {
if f.Destination != nil {
set.Float64Var(f.Destination, name, f.Value, f.Usage)
return
continue
}
set.Float64(name, f.Value, f.Usage)
}