In some windows setups, os.TempDir() will return something like "C:\WINDOWS" if none of the expected environment variables (TMP, TEMP, USERPROFILE) are set, and then functions that try to create temporary files or directories will fail since this is not writable. Several tests in flag_test.go clear the environment and then set a small number of specific environment variables for the test, triggering the following error in TestFlagFromFile when I run `go test ./...` on a new windows machine: flag_test.go:1667: open C:\WINDOWS\urfave_cli_test851254863: Access is denied. To work around this, we can check the temp directory before calling os.Clearenv() and use that directory explcitly in functions that take the temp directory. This fixes part of #1105.main
parent
7a390105cb
commit
8d907b5329
Loading…
Reference in new issue