x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Changes from code review

Browse Source
This commit is contained in:
Naveen Gogineni 2022-04-23 19:30:34 -04:00
parent dd7065671f
commit 8c5f1fb359
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
flag_test.go
View File

@ -2063,17 +2063,19 @@ func TestTimestampFlagApply_WithDestination(t *testing.T) {
// Test issue #1254 // Test issue #1254
// StringSlice() with UseShortOptionHandling causes duplicated entries, depending on the ordering of the flags // StringSlice() with UseShortOptionHandling causes duplicated entries, depending on the ordering of the flags
func TestSliceShortOptionHandle(t *testing.T) { func TestSliceShortOptionHandle(t *testing.T) {
_ = (&App{ wasCalled := false
err := (&App{
Commands: []*Command{ Commands: []*Command{
{ {
Name: "foobar", Name: "foobar",
UseShortOptionHandling: true, UseShortOptionHandling: true,
Action: func(ctx *Context) error { Action: func(ctx *Context) error {
wasCalled = true
if ctx.Bool("i") != true { if ctx.Bool("i") != true {
t.Errorf("bool i not set") t.Error("bool i not set")
} }
if ctx.Bool("t") != true { if ctx.Bool("t") != true {
t.Errorf("bool i not set") t.Error("bool i not set")
} }
ss := ctx.StringSlice("net") ss := ctx.StringSlice("net")
if !reflect.DeepEqual(ss, []string{"foo"}) { if !reflect.DeepEqual(ss, []string{"foo"}) {
@ -2089,4 +2091,10 @@ func TestSliceShortOptionHandle(t *testing.T) {
}, },
}, },
}).Run([]string{"run", "foobar", "--net=foo", "-it"}) }).Run([]string{"run", "foobar", "--net=foo", "-it"})
if err != nil {
t.Fatal(err)
}
if !wasCalled {
t.Fatal("Action callback was never called")
}
} }