x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

only display app version and help message once

Browse Source 
When processing the flags for -h/--help and -v/--version, only check
the flags in checkVersion() and checkHelp() instead of also printing
the associated message.

This fixes the problem of `app -h` and `app -v` printing their output
twice. The doubling was caused by printing the message once for each
registred alias for the given flags (-h/--help and -v/--version).

Resolves #285
This commit is contained in:
Ryan Graham 2015-10-18 17:02:23 -07:00
parent aba9469083
commit 732e97aee8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app.go
View File

@ -138,10 +138,12 @@ func (a *App) Run(arguments []string) (err error) {
} }
if !a.HideHelp && checkHelp(context) { if !a.HideHelp && checkHelp(context) {
ShowAppHelp(context)
return nil return nil
} }
if !a.HideVersion && checkVersion(context) { if !a.HideVersion && checkVersion(context) {
ShowVersion(context)
return nil return nil
} }

2
help.go
View File

@ -190,7 +190,6 @@ func checkVersion(c *Context) bool {
if VersionFlag.Name != "" { if VersionFlag.Name != "" {
eachName(VersionFlag.Name, func(name string) { eachName(VersionFlag.Name, func(name string) {
if c.GlobalBool(name) || c.Bool(name) { if c.GlobalBool(name) || c.Bool(name) {
ShowVersion(c)
found = true found = true
} }
}) })
@ -203,7 +202,6 @@ func checkHelp(c *Context) bool {
if HelpFlag.Name != "" { if HelpFlag.Name != "" {
eachName(HelpFlag.Name, func(name string) { eachName(HelpFlag.Name, func(name string) {
if c.GlobalBool(name) || c.Bool(name) { if c.GlobalBool(name) || c.Bool(name) {
ShowAppHelp(c)
found = true found = true
} }
}) })