Merge pull request #890 from urfave/issue-878

Fix #878

context.go

@@ -313,9 +313,20 @@ func checkRequiredFlags(flags []Flag, context *Context) requiredFlagsErr {
 	var missingFlags []string
 	for _, f := range flags {
 		if rf, ok := f.(RequiredFlag); ok && rf.IsRequired() {
-			key := strings.Split(f.GetName(), ",")[0]
+			var flagPresent bool
-			if !context.IsSet(key) {
+			var flagName string
-				missingFlags = append(missingFlags, key)
+			for _, key := range strings.Split(f.GetName(), ",") {
+				if len(key) > 1 {
+					flagName = key
+				}
+
+				if context.IsSet(strings.TrimSpace(key)) {
+					flagPresent = true
+				}
+			}
+
+			if !flagPresent && flagName != "" {
+				missingFlags = append(missingFlags, flagName)
 			}
 		}
 	}

context_test.go

@@ -517,6 +517,20 @@ func TestCheckRequiredFlags(t *testing.T) {
 			},
 			parseInput: []string{"--requiredFlag", "myinput", "--requiredFlagTwo", "myinput"},
 		},
+		{
+			testCase: "required_flag_with_short_name",
+			flags: []Flag{
+				StringSliceFlag{Name: "names, N", Required: true},
+			},
+			parseInput: []string{"-N", "asd", "-N", "qwe"},
+		},
+		{
+			testCase: "required_flag_with_multiple_short_names",
+			flags: []Flag{
+				StringSliceFlag{Name: "names, N, n", Required: true},
+			},
+			parseInput: []string{"-n", "asd", "-n", "qwe"},
+		},
 	}
 	for _, test := range tdata {
 		t.Run(test.testCase, func(t *testing.T) {