From 33744eb004bfc4ec76049bba7f7b264ff6191817 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alo=C3=AFs=20Micard?= Date: Mon, 27 Apr 2020 19:49:29 +0200 Subject: [PATCH 1/2] Harmonize BeforeError handling --- app.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/app.go b/app.go index 4122596..59bf68d 100644 --- a/app.go +++ b/app.go @@ -292,8 +292,6 @@ func (a *App) RunContext(ctx context.Context, arguments []string) (err error) { if a.Before != nil { beforeErr := a.Before(context) if beforeErr != nil { - _, _ = fmt.Fprintf(a.Writer, "%v\n\n", beforeErr) - _ = ShowAppHelp(context) a.handleExitCoder(context, beforeErr) err = beforeErr return err From c261e4dbd3c72bc9baec4072b5f866d3349a6b3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alo=C3=AFs=20Micard?= Date: Tue, 28 Apr 2020 08:03:26 +0200 Subject: [PATCH 2/2] Harmonize BeforeError usage in Command#Run --- command.go | 1 - 1 file changed, 1 deletion(-) diff --git a/command.go b/command.go index 95840f3..daa58c8 100644 --- a/command.go +++ b/command.go @@ -150,7 +150,6 @@ func (c *Command) Run(ctx *Context) (err error) { if c.Before != nil { err = c.Before(context) if err != nil { - _ = ShowCommandHelp(context, c.Name) context.App.handleExitCoder(context, err) return err }