From 45dc37629c02aab24826c9c18e6aec973056939a Mon Sep 17 00:00:00 2001
From: Naveen Gogineni <dear.chap@gmail.com>
Date: Fri, 4 Nov 2022 08:36:32 -0400
Subject: [PATCH] Code review comment

---
 cmd/urfave-cli-genflags/main.go | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/cmd/urfave-cli-genflags/main.go b/cmd/urfave-cli-genflags/main.go
index 2706614..240b597 100644
--- a/cmd/urfave-cli-genflags/main.go
+++ b/cmd/urfave-cli-genflags/main.go
@@ -177,25 +177,28 @@ func runGenFlags(cCtx *cli.Context) error {
 		return err
 	}
 
-	if !cCtx.IsSet("altsrc") {
-		genTestTmpl, err := template.New("gen_test").Parse(TestTemplateString)
-		if err != nil {
-			return err
-		}
+	if cCtx.IsSet("altsrc") {
+		return nil
+	}
 
-		genTestBuf := &bytes.Buffer{}
-		if err := genTestTmpl.Execute(genTestBuf, spec); err != nil {
-			return err
-		}
+	genTestTmpl, err := template.New("gen_test").Parse(TestTemplateString)
+	if err != nil {
+		return err
+	}
 
-		if err := os.WriteFile(cCtx.Path("generated-test-output"), genTestBuf.Bytes(), 0644); err != nil {
-			return err
-		}
+	genTestBuf := &bytes.Buffer{}
+	if err := genTestTmpl.Execute(genTestBuf, spec); err != nil {
+		return err
+	}
 
-		if _, err := sh(cCtx.Context, cCtx.Path("goimports"), "-w", cCtx.Path("generated-test-output")); err != nil {
-			return err
-		}
+	if err := os.WriteFile(cCtx.Path("generated-test-output"), genTestBuf.Bytes(), 0644); err != nil {
+		return err
 	}
+
+	if _, err := sh(cCtx.Context, cCtx.Path("goimports"), "-w", cCtx.Path("generated-test-output")); err != nil {
+		return err
+	}
+
 	return nil
 }