Close temporary file before running go tool cover

This commit is contained in:
Dan Buch 2016-05-22 19:44:21 -04:00
parent 9491a91336
commit 4566119b39
No known key found for this signature in database
GPG Key ID: FAEF12936DD3E3EC

View File

@ -49,9 +49,9 @@ def _test():
('{}/{}'.format(PACKAGE_NAME, subpackage)).rstrip('/') ('{}/{}'.format(PACKAGE_NAME, subpackage)).rstrip('/')
]) ])
combined = _combine_coverprofiles(coverprofiles) combined_name = _combine_coverprofiles(coverprofiles)
_run('go tool cover -func={}'.format(combined.name).split()) _run('go tool cover -func={}'.format(combined_name).split())
combined.close() os.remove(combined_name)
def _gfmxr(): def _gfmxr():
@ -78,7 +78,9 @@ def _is_go_runnable(line):
def _combine_coverprofiles(coverprofiles): def _combine_coverprofiles(coverprofiles):
combined = tempfile.NamedTemporaryFile(suffix='.coverprofile') combined = tempfile.NamedTemporaryFile(
suffix='.coverprofile', delete=False
)
combined.write('mode: set\n') combined.write('mode: set\n')
for coverprofile in coverprofiles: for coverprofile in coverprofiles:
@ -88,7 +90,9 @@ def _combine_coverprofiles(coverprofiles):
combined.write(line) combined.write(line)
combined.flush() combined.flush()
return combined name = combined.name
combined.close()
return name
if __name__ == '__main__': if __name__ == '__main__':