Merge pull request #626 from urfave/do-not-double-print-before-errors

Do not double print errors from Before()
main
Jesse Szwedko 7 years ago committed by GitHub
commit 3ddfc81916

@ -240,7 +240,6 @@ func (a *App) Run(arguments []string) (err error) {
if a.Before != nil { if a.Before != nil {
beforeErr := a.Before(context) beforeErr := a.Before(context)
if beforeErr != nil { if beforeErr != nil {
fmt.Fprintf(a.Writer, "%v\n\n", beforeErr)
ShowAppHelp(context) ShowAppHelp(context)
HandleExitCoder(beforeErr) HandleExitCoder(beforeErr)
err = beforeErr err = beforeErr

@ -197,8 +197,6 @@ func (c Command) Run(ctx *Context) (err error) {
if c.Before != nil { if c.Before != nil {
err = c.Before(context) err = c.Before(context)
if err != nil { if err != nil {
fmt.Fprintln(context.App.Writer, err)
fmt.Fprintln(context.App.Writer)
ShowCommandHelp(context, c.Name) ShowCommandHelp(context, c.Name)
HandleExitCoder(err) HandleExitCoder(err)
return err return err

Loading…
Cancel
Save