x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1198 from ErinCall/paths-take-files

Browse Source 
Support PathFlag.TakesFile in fish completion
This commit is contained in:
Robert Liebowitz 2020-10-31 11:54:41 -04:00 committed by GitHub
commit 3be15f7525
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fish.go
View File

@ -171,6 +171,10 @@ func fishAddFileFlag(flag Flag, completion *strings.Builder) {
if f.TakesFile { if f.TakesFile {
return return
} }
case *PathFlag:
if f.TakesFile {
return
}
} }
completion.WriteString(" -f") completion.WriteString(" -f")
} }

4
fish_test.go
View File

@ -7,6 +7,10 @@ import (
func TestFishCompletion(t *testing.T) { func TestFishCompletion(t *testing.T) {
// Given // Given
app := testApp() app := testApp()
app.Flags = append(app.Flags, &PathFlag{
Name: "logfile",
TakesFile: true,
})
// When // When
res, err := app.ToFishCompletion() res, err := app.ToFishCompletion()

1
testdata/expected-fish-full.fish vendored
View File

@ -12,6 +12,7 @@ end
complete -c greet -n '__fish_greet_no_subcommand' -l socket -s s -r -d 'some \'usage\' text' complete -c greet -n '__fish_greet_no_subcommand' -l socket -s s -r -d 'some \'usage\' text'
complete -c greet -n '__fish_greet_no_subcommand' -f -l flag -s fl -s f -r complete -c greet -n '__fish_greet_no_subcommand' -f -l flag -s fl -s f -r
complete -c greet -n '__fish_greet_no_subcommand' -f -l another-flag -s b -d 'another usage text' complete -c greet -n '__fish_greet_no_subcommand' -f -l another-flag -s b -d 'another usage text'
complete -c greet -n '__fish_greet_no_subcommand' -l logfile -r
complete -c greet -n '__fish_greet_no_subcommand' -f -l help -s h -d 'show help' complete -c greet -n '__fish_greet_no_subcommand' -f -l help -s h -d 'show help'
complete -c greet -n '__fish_greet_no_subcommand' -f -l version -s v -d 'print the version' complete -c greet -n '__fish_greet_no_subcommand' -f -l version -s v -d 'print the version'
complete -c greet -n '__fish_seen_subcommand_from config c' -f -l help -s h -d 'show help' complete -c greet -n '__fish_seen_subcommand_from config c' -f -l help -s h -d 'show help'