x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ensure that EnvVar struct field exists before interrogating it

Browse Source 
Otherwise you end up with `<invalid Value>` which, in practice, would
probably work, but this is cleaner.
This commit is contained in:
Jesse Szwedko 2016-07-31 20:09:57 -07:00
parent d60469024a
commit 168c95418e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
context.go
View File

@ -79,9 +79,12 @@ func (c *Context) IsSet(name string) bool {
return return
} }
envVars := reflect.ValueOf(f).FieldByName("EnvVar").String() envVarValue := reflect.ValueOf(f).FieldByName("EnvVar")
if !envVarValue.IsValid() {
return
}
eachName(envVars, func(envVar string) { eachName(envVarValue.String(), func(envVar string) {
envVar = strings.TrimSpace(envVar) envVar = strings.TrimSpace(envVar)
if envVal := os.Getenv(envVar); envVal != "" { if envVal := os.Getenv(envVar); envVal != "" {
c.setFlags[name] = true c.setFlags[name] = true