expand test cases

app_regression_test.go

@@ -9,24 +9,36 @@ import (
 // Relevant PR: https://github.com/urfave/cli/pull/872
 func TestVersionOneTwoOneRegression(t *testing.T) {
 	testData := []struct {
-		testCase    string
+		testCase       string
-		appRunInput []string
+		appRunInput    []string
+		skipArgReorder bool
 	}{
 		{
 			testCase:    "with_dash_dash",
 			appRunInput: []string{"cli", "command", "--flagone", "flagvalue", "--", "docker", "image", "ls", "--no-trunc"},
 		},
+		{
+			testCase:       "with_dash_dash_and_skip_reorder",
+			appRunInput:    []string{"cli", "command", "--flagone", "flagvalue", "--", "docker", "image", "ls", "--no-trunc"},
+			skipArgReorder: true,
+		},
 		{
 			testCase:    "without_dash_dash",
 			appRunInput: []string{"cli", "command", "--flagone", "flagvalue", "docker", "image", "ls", "--no-trunc"},
 		},
+		{
+			testCase:       "without_dash_dash_and_skip_reorder",
+			appRunInput:    []string{"cli", "command", "--flagone", "flagvalue", "docker", "image", "ls", "--no-trunc"},
+			skipArgReorder: true,
+		},
 	}
 	for _, test := range testData {
 		t.Run(test.testCase, func(t *testing.T) {
 			// setup
 			app := NewApp()
 			app.Commands = []Command{{
-				Name: "command",
+				Name:           "command",
+				SkipArgReorder: test.skipArgReorder,
 				Flags: []Flag{
 					StringFlag{
 						Name: "flagone",